* Re: [PATCH v5 03/13] coresight-tpdm: Introduce TPDM subtype to TPDM driver
[not found] ` <1686553666-5811-4-git-send-email-quic_taozha@quicinc.com>
@ 2023-06-12 15:35 ` Suzuki K Poulose
2023-06-15 9:09 ` Tao Zhang
0 siblings, 1 reply; 2+ messages in thread
From: Suzuki K Poulose @ 2023-06-12 15:35 UTC (permalink / raw)
To: Tao Zhang, Mathieu Poirier, Alexander Shishkin, Konrad Dybcio,
Mike Leach, Rob Herring, Krzysztof Kozlowski
Cc: Jinlong Mao, Leo Yan, Greg Kroah-Hartman, coresight,
linux-arm-kernel, linux-kernel, devicetree, Tingwei Zhang,
Yuanfang Zhang, Trilok Soni, Hao Zhang, linux-arm-msm, andersson
On 12/06/2023 08:07, Tao Zhang wrote:
> Introduce the new subtype of "CORESIGHT_DEV_SUBTYPE_SOURCE_TPDM"
> for TPDM components in driver.
>
> Signed-off-by: Tao Zhang <quic_taozha@quicinc.com>
> ---
> drivers/hwtracing/coresight/coresight-core.c | 1 +
> drivers/hwtracing/coresight/coresight-tpdm.c | 2 +-
> include/linux/coresight.h | 1 +
> 3 files changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/hwtracing/coresight/coresight-core.c b/drivers/hwtracing/coresight/coresight-core.c
> index 118fcf2..23b18c2 100644
> --- a/drivers/hwtracing/coresight/coresight-core.c
> +++ b/drivers/hwtracing/coresight/coresight-core.c
> @@ -1093,6 +1093,7 @@ static int coresight_validate_source(struct coresight_device *csdev,
>
> if (subtype != CORESIGHT_DEV_SUBTYPE_SOURCE_PROC &&
> subtype != CORESIGHT_DEV_SUBTYPE_SOURCE_SOFTWARE &&
> + subtype != CORESIGHT_DEV_SUBTYPE_SOURCE_TPDM &&
minor nit: Alignment. Please always double check your patch for
styling issues.
Otherwise looks good to me
Suzuki
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH v5 03/13] coresight-tpdm: Introduce TPDM subtype to TPDM driver
2023-06-12 15:35 ` [PATCH v5 03/13] coresight-tpdm: Introduce TPDM subtype to TPDM driver Suzuki K Poulose
@ 2023-06-15 9:09 ` Tao Zhang
0 siblings, 0 replies; 2+ messages in thread
From: Tao Zhang @ 2023-06-15 9:09 UTC (permalink / raw)
To: Suzuki K Poulose, Mathieu Poirier, Alexander Shishkin,
Konrad Dybcio, Mike Leach, Rob Herring, Krzysztof Kozlowski
Cc: Jinlong Mao, Leo Yan, Greg Kroah-Hartman, coresight,
linux-arm-kernel, linux-kernel, devicetree, Tingwei Zhang,
Yuanfang Zhang, Trilok Soni, Hao Zhang, linux-arm-msm, andersson
On 6/12/2023 11:35 PM, Suzuki K Poulose wrote:
> On 12/06/2023 08:07, Tao Zhang wrote:
>> Introduce the new subtype of "CORESIGHT_DEV_SUBTYPE_SOURCE_TPDM"
>> for TPDM components in driver.
>>
>> Signed-off-by: Tao Zhang <quic_taozha@quicinc.com>
>> ---
>> drivers/hwtracing/coresight/coresight-core.c | 1 +
>> drivers/hwtracing/coresight/coresight-tpdm.c | 2 +-
>> include/linux/coresight.h | 1 +
>> 3 files changed, 3 insertions(+), 1 deletion(-)
>>
>> diff --git a/drivers/hwtracing/coresight/coresight-core.c
>> b/drivers/hwtracing/coresight/coresight-core.c
>> index 118fcf2..23b18c2 100644
>> --- a/drivers/hwtracing/coresight/coresight-core.c
>> +++ b/drivers/hwtracing/coresight/coresight-core.c
>> @@ -1093,6 +1093,7 @@ static int coresight_validate_source(struct
>> coresight_device *csdev,
>> if (subtype != CORESIGHT_DEV_SUBTYPE_SOURCE_PROC &&
>> subtype != CORESIGHT_DEV_SUBTYPE_SOURCE_SOFTWARE &&
>> + subtype != CORESIGHT_DEV_SUBTYPE_SOURCE_TPDM &&
>
> minor nit: Alignment. Please always double check your patch for
> styling issues.
>
>
> Otherwise looks good to me
Sure, I will check all the patches and update to the next patch series soon.
Do you have more review comments on other patches?
Best,
Tao
>
> Suzuki
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-06-15 9:10 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <1686553666-5811-1-git-send-email-quic_taozha@quicinc.com>
[not found] ` <1686553666-5811-4-git-send-email-quic_taozha@quicinc.com>
2023-06-12 15:35 ` [PATCH v5 03/13] coresight-tpdm: Introduce TPDM subtype to TPDM driver Suzuki K Poulose
2023-06-15 9:09 ` Tao Zhang
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).