From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 083EBC88CB4 for ; Mon, 12 Jun 2023 15:36:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=6UegQeLc7X1BNMbwannOZx5Qv437pzb11XbYgXT8/i4=; b=IrTD/hN3JIq5Uq l3PMNJqToGAUPhwJLuF54P8XrmdrrVFr8CjPxc+ZxSzDSBwni6U0MS0W9Z1Tipeh8ZKBtQ9UpDhIN E1vlXVuloyw86qAemQPNzO73dv38RtG7vbSKLY+E4hHJDEa12GNxyKxckxRu1f/LjgYeFh17OIN8X 9FQFTwHCN+kcMw7QVCK3THp/GGEYTvmfGqQzaX2hEXr1z3ZN1vOjm6FJMaK0KhEWA4enU+GonvNmI lNptquKSHLaXw490/Pzx2F8BLd6+KDvJ8ZDFBwu8iIUtqPPwFhGTlWSS7dlj4J81rhk2X3XFrYu6e y6//RIqrosJNC/e7n3Mg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1q8jaF-004WLg-1K; Mon, 12 Jun 2023 15:35:55 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1q8jaC-004WJt-1w for linux-arm-kernel@lists.infradead.org; Mon, 12 Jun 2023 15:35:54 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id EBF511FB; Mon, 12 Jun 2023 08:36:33 -0700 (PDT) Received: from [10.57.27.113] (unknown [10.57.27.113]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 2E9163F5A1; Mon, 12 Jun 2023 08:35:46 -0700 (PDT) Message-ID: <16b08ba8-f23e-af24-881c-61fe4e4c92e1@arm.com> Date: Mon, 12 Jun 2023 16:35:44 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.11.1 Subject: Re: [PATCH v5 03/13] coresight-tpdm: Introduce TPDM subtype to TPDM driver To: Tao Zhang , Mathieu Poirier , Alexander Shishkin , Konrad Dybcio , Mike Leach , Rob Herring , Krzysztof Kozlowski Cc: Jinlong Mao , Leo Yan , Greg Kroah-Hartman , coresight@lists.linaro.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, Tingwei Zhang , Yuanfang Zhang , Trilok Soni , Hao Zhang , linux-arm-msm@vger.kernel.org, andersson@kernel.org References: <1686553666-5811-1-git-send-email-quic_taozha@quicinc.com> <1686553666-5811-4-git-send-email-quic_taozha@quicinc.com> From: Suzuki K Poulose In-Reply-To: <1686553666-5811-4-git-send-email-quic_taozha@quicinc.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230612_083552_705302_6784BFF5 X-CRM114-Status: GOOD ( 14.33 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 12/06/2023 08:07, Tao Zhang wrote: > Introduce the new subtype of "CORESIGHT_DEV_SUBTYPE_SOURCE_TPDM" > for TPDM components in driver. > > Signed-off-by: Tao Zhang > --- > drivers/hwtracing/coresight/coresight-core.c | 1 + > drivers/hwtracing/coresight/coresight-tpdm.c | 2 +- > include/linux/coresight.h | 1 + > 3 files changed, 3 insertions(+), 1 deletion(-) > > diff --git a/drivers/hwtracing/coresight/coresight-core.c b/drivers/hwtracing/coresight/coresight-core.c > index 118fcf2..23b18c2 100644 > --- a/drivers/hwtracing/coresight/coresight-core.c > +++ b/drivers/hwtracing/coresight/coresight-core.c > @@ -1093,6 +1093,7 @@ static int coresight_validate_source(struct coresight_device *csdev, > > if (subtype != CORESIGHT_DEV_SUBTYPE_SOURCE_PROC && > subtype != CORESIGHT_DEV_SUBTYPE_SOURCE_SOFTWARE && > + subtype != CORESIGHT_DEV_SUBTYPE_SOURCE_TPDM && minor nit: Alignment. Please always double check your patch for styling issues. Otherwise looks good to me Suzuki _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel