From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3B8EFC433B4 for ; Mon, 12 Apr 2021 10:24:41 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id BE1FC61288 for ; Mon, 12 Apr 2021 10:24:40 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org BE1FC61288 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=ACULAB.COM Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:In-Reply-To:References:Message-ID:Date: Subject:CC:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=+oeD2P7au+04xcVx3eyk5mct96XAgmip+0eyzxnq/rc=; b=VbqLo0BTHYXbCvS+HcpVTi3mI fArRAHTWD+gnpYMhZquwvO23jRw3jQY7K9awCt8c0IQlKztvQlsrN3OyB8Uqlm4l5yARxiVBPFPLx T40BKUyMyr7JThP4/rNvKSJ9nqoDeH9eacNxNvZ5Hgrt7pRzXmHUlckIFrTnKyMacAmncDDwN8M7g FwJYocaDo19CD/+Nk5W21nKpqHz+p5+LOMaw9Fb0iKWTnGp2TL2jYzYkJ/N7sGoS36a/XLWIjW494 0xn+K9PZDkMJVDIl/qzXnoZXGlMW3e5CA1/WBm/DmOe9h+iT3rcWdali3rqUiCxE0R23qwg1rFzDS QqZUqiC+g==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lVtiU-006Qfv-LE; Mon, 12 Apr 2021 10:22:50 +0000 Received: from bombadil.infradead.org ([2607:7c80:54:e::133]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lVtiR-006Qfa-3H for linux-arm-kernel@desiato.infradead.org; Mon, 12 Apr 2021 10:22:48 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Content-Transfer-Encoding: Content-Type:MIME-Version:In-Reply-To:References:Message-ID:Date:Subject:CC: To:From:Sender:Reply-To:Content-ID:Content-Description; bh=jGR16cMqQqdKFKuUUg1ZBjqVvqGFwZzKC1aCFf2Vgw0=; b=HBOOQKx0fVmVdwZi0tMWAf42S7 2YG0I91h5TKgng31GB+MKs2mkn3hHlWqvjTjiaStb7Ie7jfr+mjVQCteyE6c+6dnpkjQbQSuSrVh3 Mo3DSts2O2j6uIc7S4ul8qn8gA7KUqZGTNsGrb2mHSh7FKG+JarBd4t4Go8vJr124zrOErY36QkR1 CZ56cmDxP+/RNlVa9xQp0x42aYyG8Ipw3yGU2fsqB0Z0OZnaCgtD0/2DkQuOi+bo/zGrWHKpoi0kE XJnuCtD7LbujZJsui8saS+FFz3/IlN+5TS7/UFbEjHfYb3GnDTfj5WIR/xnultUwZoskyLejV8cPy raRMGM/w==; Received: from eu-smtp-delivery-151.mimecast.com ([185.58.85.151]) by bombadil.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lVtiO-00686y-8C for linux-arm-kernel@lists.infradead.org; Mon, 12 Apr 2021 10:22:45 +0000 Received: from AcuMS.aculab.com (156.67.243.121 [156.67.243.121]) (Using TLS) by relay.mimecast.com with ESMTP id uk-mta-128-DnwYs6UTM2mO74AA5I6jBQ-1; Mon, 12 Apr 2021 11:22:40 +0100 X-MC-Unique: DnwYs6UTM2mO74AA5I6jBQ-1 Received: from AcuMS.Aculab.com (fd9f:af1c:a25b:0:994c:f5c2:35d6:9b65) by AcuMS.aculab.com (fd9f:af1c:a25b:0:994c:f5c2:35d6:9b65) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Mon, 12 Apr 2021 11:22:38 +0100 Received: from AcuMS.Aculab.com ([fe80::994c:f5c2:35d6:9b65]) by AcuMS.aculab.com ([fe80::994c:f5c2:35d6:9b65%12]) with mapi id 15.00.1497.012; Mon, 12 Apr 2021 11:22:38 +0100 From: David Laight To: 'Arnd Bergmann' , Christoph Hellwig CC: linux-arch , linux-s390 , Thomas Bogendoerfer , Parisc List , Vasily Gorbik , linuxppc-dev , Catalin Marinas , Helge Deller , the arch/x86 maintainers , Linux Kernel Mailing List , "David S. Miller" , "James E.J. Bottomley" , Christian Borntraeger , sparclinux , "open list:BROADCOM NVRAM DRIVER" , Will Deacon , Heiko Carstens , Linux ARM Subject: RE: consolidate the flock uapi definitions Thread-Topic: consolidate the flock uapi definitions Thread-Index: AQHXL4M0xqfui6+bp0WfMrJF+xIqXKqwqyrg Date: Mon, 12 Apr 2021 10:22:38 +0000 Message-ID: <16c471554aa5424fbe2f6a4fd60bd662@AcuMS.aculab.com> References: <20210412085545.2595431-1-hch@lst.de> In-Reply-To: Accept-Language: en-GB, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-exchange-transport-fromentityheader: Hosted x-originating-ip: [10.202.205.107] MIME-Version: 1.0 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=C51A453 smtp.mailfrom=david.laight@aculab.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: aculab.com Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210412_032244_585847_52413E41 X-CRM114-Status: GOOD ( 17.71 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org From: Arnd Bergmann > Sent: 12 April 2021 11:04 > > On Mon, Apr 12, 2021 at 10:55 AM Christoph Hellwig wrote: > > > > Hi all, > > > > currently we deal with the slight differents in the various architecture > > variants of the flock and flock64 stuctures in a very cruft way. This > > series switches to just use small arch hooks and define the rest in > > asm-generic and linux/compat.h instead. > > Nice cleanup. I can merge it through the asm-generic tree if you like, > though it's a little late just ahead of the merge window. > > I would not want to change the compat_loff_t definition to compat_s64 > to avoid the padding at this time, though that might be a useful cleanup > for a future cycle. Is x86 the only architecture that has 32bit and 64bit variants where the 32bit variant aligns 64bit items on 32bit boundaries? I've just checked MIPS and ARM, and I'm fairly sure sparc 64bit aligns them. Are there any others? Might also be interesting to check whether compat_loff_t gets used anywhere else - where the x64-64 compat code will get it wrong. ISTM that fixing compat_loff_t shouldn't have any fallout. David - Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK Registration No: 1397386 (Wales) _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel