From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 8F21FC48BF6 for ; Thu, 29 Feb 2024 08:55:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Content-ID:In-Reply-To: References:Message-ID:Date:Subject:To:From:Reply-To:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=DCEEJKTu+AHn9KGh2mRZmzOB8NuYxDz+8NJSnl48Guk=; b=VTMkD5ucBryx0Z 45vUs5/0Ou2P09K8P+UTKNwKpUUJh63DeFWUVZeHvExjl/WERLWbzQV+hVjm+VsfkMqdRIN3rklhV C88+Tv9MDOtl/VK8oqklUsG0ir05E6HmnbUv33KqUc/G3XeLehuqeYNUJGNwOiVrZVsMvWRzPUmmK Bi5PTQkb0R+cLt8c1OAP5GSf4sfzAIS5DweS69rrfK0Amo9NL7y1bq2xJEVxCdDzlO+9ifFfdx6cK c/uZbJM/ZXOYjSey3tTMVExskOohYJPVd4aCkLhDKTcZUnvzHxsU2OXnCdMi4CTIYPjDycVrpb2Gu 3tsKnPPE6kQeshKjiZkA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rfcCa-0000000Clj8-30c5; Thu, 29 Feb 2024 08:55:40 +0000 Received: from esa.microchip.iphmx.com ([68.232.154.123]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rfcCX-0000000CliK-475F for linux-arm-kernel@lists.infradead.org; Thu, 29 Feb 2024 08:55:39 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=microchip.com; i=@microchip.com; q=dns/txt; s=mchp; t=1709196938; x=1740732938; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-id:content-transfer-encoding: mime-version; bh=+waadFx1VTu1DA9Gb4IDZa01N5JRWVEVdcJy7IWL4TY=; b=YT5ujWBSTzGwGwes88JS0sPN1nyPxx+QcxJ0QZCnUl8VH1GjbQRGR/oa EnKfWppmvSDCXhiJhS89JnDp+xcaoEOW6J8s9B40AGl09tPguXNiSpdax Ydlm3TGptsluQ2HifUPsEfNpaTI4bt3WjLydtD/xkltkYDD3XMZuU70/f RrsKfxdqbVqeMeC1dmfAULTb9Hnmswm9aZ0ivNItLnIZJS59gyikfVWG9 GRruVJlWkxx0T8e7g+FAHTlhIu90lz92ciE+OGZ+1mO1NZlRWgVIg2ujt VZ4iwC7R5s/PLeMpqqfUpZU9dFKBVtAbmWc4DsigmM9r8LPslImNx/luL Q==; X-CSE-ConnectionGUID: 5bdFyTMaTXyfg+TtmkWY6Q== X-CSE-MsgGUID: oFENGAbPQ0uLG1mSEofqtw== X-IronPort-AV: E=Sophos;i="6.06,192,1705388400"; d="scan'208";a="17532723" X-Amp-Result: SKIPPED(no attachment in message) Received: from unknown (HELO email.microchip.com) ([170.129.1.10]) by esa2.microchip.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 29 Feb 2024 01:55:34 -0700 Received: from chn-vm-ex02.mchp-main.com (10.10.85.144) by chn-vm-ex04.mchp-main.com (10.10.85.152) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Thu, 29 Feb 2024 01:55:13 -0700 Received: from NAM10-DM6-obe.outbound.protection.outlook.com (10.10.215.250) by email.microchip.com (10.10.87.72) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35 via Frontend Transport; Thu, 29 Feb 2024 01:55:13 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=nGK/hmklzlPr9//JsRvx8ZUYJb0CrhdafjwaAxSH8rXoxBXSC0TgzGOAy1Iw864ivomTbccNr3ONFKtxwDp6o9uZaSizz1iGFUeWc9rQ3zGKuTFUW9258RfOw51vnfkCGBnwQCgGzTwUcV3M26yoGFOm0E3Er/48t+AhTA5P4lB9DDIaaE0mYgigEtXQeClzTuYloA+evX8DkByUgL/L9okZqIu0mqGWr0HTF1XlAVvIYiufTQeIL6cydkATlKjQ/awSF+3OVFeD3B8E/CQhepzmdOaWR0PuEjHKymJIaUJ4H75gn7b7iOesX4OWYWxVzTiNAKekMxFji78MTRwCqQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=+waadFx1VTu1DA9Gb4IDZa01N5JRWVEVdcJy7IWL4TY=; b=FvIfoJPR/s6lMYEbPhyWBSsOYkFe3wT0GVjzTHfNaN1Nm3CwlHxSjj6s4zs7qTdJLCTwSIIfbZNtZ0HSwMMWuZFVMHBkXwkFu7a1FICah2Sr7uSuP51ipwRNsfwIZMd1GbUFQx2xHf6kLXesDFh+B5OdIjviV9unwZzt0pScUUbikXKKGI2dsTJajwxy0f+JKwpUKBY+lohUCUis6Y7pnMTr0gzSpm61TQ2vPnzlQTDMHFzKQHUu0cG50ECtdtSe7jm94PlMUTNYDa9HYukiplLNdifVkbXd5qOEQAuOXRC0jUuh4JSuda6ASkXvfTdrz3kVyYNmHdZEccRMqWSkBQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=microchip.com; dmarc=pass action=none header.from=microchip.com; dkim=pass header.d=microchip.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=microchip.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=+waadFx1VTu1DA9Gb4IDZa01N5JRWVEVdcJy7IWL4TY=; b=ayNVoUoLTUf1+u7Nf5LDYegFOVjf+N3o+CR9w/bYIlfwckt/vO4Udo+oMC+SfwXEtPiIUYGIu7eAGpN6sCTLCLz9hwnb3hjuarFuInFUBzN4wrh7fSDWNEw9MtpDMg73Ca6/ury6nqJzzZf7YRytbcwMuKIAiJOShD0gLFTZzcKDw6qyIyyzn3MLfcZFJmRCqFMiGh60hZSqpaBuAjGYopz59u8jAPnehZovONJl02wcBhiHjwIC8FkOx6chnamqC7RLuReJKT5/0cFabs81M1phs95qF6Dzn95g9i3hNWr3iWSTcN2rI1oFpYQVi9WEQRVexpVH2cdvoRfUVXl3iA== Received: from SA0PR11MB4719.namprd11.prod.outlook.com (2603:10b6:806:95::17) by IA1PR11MB7319.namprd11.prod.outlook.com (2603:10b6:208:425::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7362.12; Thu, 29 Feb 2024 08:55:11 +0000 Received: from SA0PR11MB4719.namprd11.prod.outlook.com ([fe80::f65f:f05e:4faf:4433]) by SA0PR11MB4719.namprd11.prod.outlook.com ([fe80::f65f:f05e:4faf:4433%4]) with mapi id 15.20.7339.024; Thu, 29 Feb 2024 08:55:11 +0000 From: To: Subject: Re: [PATCH v4 12/39] dt-bindings: serial: atmel,at91-usart: add compatible for sam9x7. Thread-Topic: [PATCH v4 12/39] dt-bindings: serial: atmel,at91-usart: add compatible for sam9x7. Thread-Index: AQHaZn14iyGqXAZ1bkm2FnuRR0qAfbEZ68sAgAVvkYCAAFAXAIABYZeA Date: Thu, 29 Feb 2024 08:55:11 +0000 Message-ID: <16e37a0e-74d0-4632-b0a2-403f74a3a379@microchip.com> References: <20240223171342.669133-1-varshini.rajendran@microchip.com> <20240223172559.672142-1-varshini.rajendran@microchip.com> <20240224-kimono-stress-898eae80abd3@spud> <20240228-capital-nickname-696dfcd655de@spud> In-Reply-To: <20240228-capital-nickname-696dfcd655de@spud> Accept-Language: en-GB, en-US Content-Language: en-GB X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=microchip.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: SA0PR11MB4719:EE_|IA1PR11MB7319:EE_ x-ms-office365-filtering-correlation-id: cdee4a1e-6ba1-4848-faf7-08dc3904237e x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: U1hsysBjwRk5kr0EhW0HoA0n94B8ISOlAjD4nLpV58qcmukEEO8Xxq6QRrYcVirxcnm1qf5cLuTAsKlFx6JxGSUw4TWhhLUKoFDwhCBNZhbbwWb8O3YXk6uJmrUstgzj3/oMgjlfnMONYGO35HMXu3bMyoaxqxw9p+XLNUjUVFDU+oY6Yq1lHe7DTTJ/Iabau5zaWtop3WrqkY1ohnvwcQO/SVV+qOGfRX6hjhJ8mYwzpFnc0eG6+Ei9u5GWUUJ8FsDQL5EIUkixLlAA4m3ezo16B2urqNNvzHA6dmPHsHp2R3yhYQdwmjuiLbaJyhwIKcdiuL7agjeLNc+EtQog0NwPSCIR/a2ZlGPFx0NfvgDSoGOrwjsjDWWzsZ+3RnGb1h7HiOK71TGFOgI23XIj7M1Bi7+QbgXwp6D4OATQEwWjj2RQZNnZGocwKutXK36jFhAiDdky91AU0WLwdPdUtP6DqATuhoZ1DS9QneRG12JLrwGSa2/lP4V8e9WsDJPGejpTMsoRfFLTrZRIVbBPN+nshm26lbSWXqD0iP7V5Y7JdMSIvFKjpKQ0d6AAFOJCjfWBhhVX1+6M6m7LRomOzIYgFyu2jhYryZTEnk9c4ZMpHA8C+RTxFRGjJNdVp+kfJLHsc4ajR6QPlH9QGnW6jaci0Ie6cjJL+ZK4sFFjNo/OTuaabrU+GT78fEifzrkT1enMLdlVCLED7+raFwURrw== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SA0PR11MB4719.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230031)(38070700009);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?dVd0YTlsajBOQlNWM3NIOWwxZ0haNTJXRTZ2Vi9hYlQ3cjlvK0ZnWGxlMTVU?= =?utf-8?B?c0dlWXV1YnUweisrZ0VoOFliU05EZUdpMWFySitIaUFhVDZhWmtBaGg2L2tJ?= =?utf-8?B?UHlleVJLZzZPUm8wVXNEY3pUSEpyK1VKYTdwVzg4NmQvTVJRblByZzZNZTBh?= =?utf-8?B?QW9jc2t2NnBNaWRFakxqY0w2bmNoVzllSUQ1a0c2TUlMNWtoOG92OEtjNnRr?= =?utf-8?B?OVhYK0RpRDFJUCthYU1uN3AyNXo2eGdQQkd2UmpNMVBIZ1RTQzU2bEp2TVhK?= =?utf-8?B?OGllMXVtRXJFVUNQT1ZWL1ZsMXlpSzRNdG9KOU1HajhWMkwrNTRmNHZaSHdS?= =?utf-8?B?VGR6eUk5MnR3d2xkMGZxWG51U0lycFY5UE56ZWh6MytTZCt0d1hKOEpMeTVP?= =?utf-8?B?OThzTEw4TnQvOGF4a3Q4VXMrTC91ZXdtWVp2b1RtNk1rVnZGM3J2SnRkbjQz?= =?utf-8?B?RGQ5RkVnTURPZ2Evb2lkU2NTR3pabm1QL0NUc093bnlhbEhIclNLdUJoK3pG?= =?utf-8?B?WHFEd2V5WCt0cFNKc3dyeUV4TEhxVE00QTlkNVJoQVlyY0RkWlV3VWJNcitL?= =?utf-8?B?NEk4VFh0ODc2Mk9wSGRsVG9CSVZJK2NHUjFLNjM2a3BVYkQwZkVPYjEzTlJo?= =?utf-8?B?aDNNWW02c0JFNlRZSTI5VE4zeGUvbnA4MklPNXV2cFFxYzJPRG0vbEEwN0g1?= =?utf-8?B?QUEwV1Z0QlF1b20zRDZQUE54VlZtNE9hakJXVTRubHMxUzA4VUJsTkdId1Ra?= =?utf-8?B?WlJwNzAvKzRkMkFkTUdERjFodjd4Y2grYjJnRUl3KzJqR2FMWkNyK2UxTjdR?= =?utf-8?B?eStDNUgzVER6akQ0RFJjK3RGQUdXV3Bnb1M0b3NNUC9UMG5EWXYwbG5RNXY2?= =?utf-8?B?QUdHVHFrSnBPSUExVkZ3QUhBM2ZlR1ZQQzR5bFNCU1dtYTBDUExKZVo5czlz?= =?utf-8?B?OUNpbkEzeFcySVhhQkVZemZWc3BqZ09wbnpuWEhWWGNySWhvT1l4TVZPQ2RO?= =?utf-8?B?L244MWFITHp6ZHNIWXkra1NzMTRmNVcxT1F0dEJDc3NLMmZIWWZQcDdWcTNR?= =?utf-8?B?VWxNMHd6dTFsYVhyZTJlMUpqQVRYVnkzNU9aY1dDMVd2UHMybkNaTEh5VUIx?= =?utf-8?B?YklBL0djMEZyeWdUYnF3aG5scGFOR3ExVlRRS0xvSitoRmdsNEh4NjU3ZGpj?= =?utf-8?B?VnZCaVRTSTFFWHhCeHBiWVZ5aW81b2I1aVFuSVI0aDViOHJWVkVXbzhZcDdE?= =?utf-8?B?RjlOZXBWZWdKeFlKMWhQaDRSc3lRQzRiaExqS3lNT2tGNGZmR0wyYVZwTnFn?= =?utf-8?B?NFRzSmdGbmxNS2d5WFBJMXVTb3FMNHJyWUtGTHNLdGxMV0VnQkR5U1hzbTA5?= =?utf-8?B?NzRxZjBzRUJyM0lMREtqR0NnTXc1aXJNcHBOdW1xelpTNVhjVHBrYXFCRXdT?= =?utf-8?B?RVJ6RFc0WjlaVmdDM2VBdDU4SlNPSXlTMzd2WTdOZlFkRVNRaXkvSFV1Mk90?= =?utf-8?B?WmRWWVVDVVYya1cyTHpPem1TaWlyMnpLWHJKZE9SdncrcTd6cUMzUFArSndh?= =?utf-8?B?elF5aTdMVTZUN0QxRisvYXFEQkVKMGF4NExoRGxpakxRV1g2M0ZrNDRldkgz?= =?utf-8?B?aXpOWS9IZG04Ri9RRXdYbmhLd1FkUFpLbXdtcDZ2ano2OHZsazhUWFAxV21Y?= =?utf-8?B?VVVWQmMxdnhDQTlGcTB1WmFaMk9nRE96YnZ0WGphN0U2c3NMNU9ZVFNRckJH?= =?utf-8?B?a3FGbFQ4Syt4Mzg0dkoxYXlJaVhaT04ycndHVmxGTnFYK2t2Z3RxVDNxejdo?= =?utf-8?B?SEl3MldNZmxxcko2KzZ4RW5VNUZWQlhYUUJSZHdFeGh4TS8wQmgvOFh1bEFs?= =?utf-8?B?b25qelcvcnY4cEY0M3gwbXRBWjNPTzlVSEtKaXlNbE5rOGpGSDhuMWdGNmlP?= =?utf-8?B?V01JMWcwR1ZMNGFIclBlcTZJNy8yc0FhMDRpYkt5YXZ4SzRURE5IMEVhZUg1?= =?utf-8?B?TXJZeWpLSXIvN0NKVXRoSDh0U0lOVEdsVWxPQ3FHSnE5VnQrNnRVbkZqWEdU?= =?utf-8?B?NmxiV0V0UFRQT1FubUV6WkJDbTdUbDJYeWtZUEFsSHBWdEY3bjdFdnk1dkc3?= =?utf-8?B?QWg4TnVGWlgvTERuZ0FtYTdNNzlGOC9qRXkzeFZCU2pZdWtrQ0tzeG1uNGwv?= =?utf-8?B?ZVE9PQ==?= Content-ID: <0D7573CECE1DE74D97D21C9F0CA66D15@namprd11.prod.outlook.com> MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: SA0PR11MB4719.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: cdee4a1e-6ba1-4848-faf7-08dc3904237e X-MS-Exchange-CrossTenant-originalarrivaltime: 29 Feb 2024 08:55:11.7867 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 3f4057f3-b418-4d4e-ba84-d55b4e897d88 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: mCtBQCEukZ9E3zVWMqyKblZKX87Fcix5II32SfuUWC4X4CmDYttlQOafwN+p5Mi+CM54PiIasuagK4D99Qd2IZTGYZa5Q1NjNBWAS1rhppzpod7+JrtT6xURH3E/haaY X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA1PR11MB7319 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240229_005538_319865_65686C2C X-CRM114-Status: GOOD ( 24.38 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, conor+dt@kernel.org, linux-serial@vger.kernel.org, alexandre.belloni@bootlin.com, richard.genoud@gmail.com, gregkh@linuxfoundation.org, radu_nicolae.pirea@upb.ro, claudiu.beznea@tuxon.dev, robh+dt@kernel.org, linux-arm-kernel@lists.infradead.org, krzysztof.kozlowski+dt@linaro.org, linux-spi@vger.kernel.org, jirislaby@kernel.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Conor, On 28/02/24 5:19 pm, Conor Dooley wrote: > EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe > On Wed, Feb 28, 2024 at 07:03:01AM +0000, Varshini.Rajendran@microchip.com wrote: >> Hi Conor, >> >> On 25/02/24 1:32 am, Conor Dooley wrote: >>> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe >>> On Fri, Feb 23, 2024 at 10:55:59PM +0530, Varshini Rajendran wrote: >>>> Add sam9x7 compatible to DT bindings documentation. >>>> >>>> Signed-off-by: Varshini Rajendran >>>> --- >>>> Changes in v4: >>>> - Fixed the wrong addition of compatible >>>> - Added further compatibles that are possible correct (as per DT) >>>> --- >>>> .../devicetree/bindings/serial/atmel,at91-usart.yaml | 12 +++++++++--- >>>> 1 file changed, 9 insertions(+), 3 deletions(-) >>>> >>>> diff --git a/Documentation/devicetree/bindings/serial/atmel,at91-usart.yaml b/Documentation/devicetree/bindings/serial/atmel,at91-usart.yaml >>>> index 65cb2e5c5eee..30af537e8e81 100644 >>>> --- a/Documentation/devicetree/bindings/serial/atmel,at91-usart.yaml >>>> +++ b/Documentation/devicetree/bindings/serial/atmel,at91-usart.yaml >>>> @@ -23,11 +23,17 @@ properties: >>>> - const: atmel,at91sam9260-dbgu >>>> - const: atmel,at91sam9260-usart >>>> - items: >>>> - - const: microchip,sam9x60-usart >>>> + - enum: >>>> + - microchip,sam9x60-usart >>>> + - microchip,sam9x7-usart >>>> - const: atmel,at91sam9260-usart >>>> - items: >>>> - - const: microchip,sam9x60-dbgu >>>> - - const: microchip,sam9x60-usart >>>> + - enum: >>>> + - microchip,sam9x60-dbgu >>>> + - microchip,sam9x7-dbgu >>> >>>> + - enum: >>>> + - microchip,sam9x60-usart >>>> + - microchip,sam9x7-usart >>> >>> This doesn't make sense - this enum should be a const. >>> I don't really understand the idea behind of the original binding here that >>> allowed: >>> "microchip,sam9x60-dbgu", "microchip,sam9x60-usart", "atmel,at91sam9260-dbgu", "atmel,at91sam9260-usart" >>> >>> Specifically, I don't get the purpose of the "microchip,sam9x60-usart". >>> Either make it >>> - items: >>> - enum: >>> - microchip,sam9x60-dbgu >>> - microchip,sam9x7-dbgu >>> - const: microchip,sam9x60-usart >>> - const: atmel,at91sam9260-dbgu >>> - const: atmel,at91sam9260-usart >>> or add >>> - items: >>> - const: microchip,sam9x60-dbgu >>> - const: atmel,at91sam9260-dbgu >>> - const: atmel,at91sam9260-usart >>> or explain exactly why this needs to be >>> "chipa-dgbu", "chipa-usart", "chipb-dbgu", "chipb-dbgu" >> The compatible has to be "chipa-usart", "chipb-usart", "chipa-dbgu", >> "chipb-dbgu" for the device to work as a debug console over UART >> wher the chipa- is the device specific compatible >> and the chipb- is the fallback compatible that the driver >> actually uses. > > This examples why you have "microchip,sam9x60-dbgu", "atmel,at91sam9260-dbgu" > and "atmel,at91sam9260-usart". > It does not explain "microchip,sam9x60-usart" though, I don't see what > purpose that serves. If used as a debug uart, you fall back to the > sam9260 debug uart compatible and if not you fall back to the sam9260 > usart compatible. > Here, if it is not used as debug uart it has to fallback to the default usart compatible which in this case should have a device specific compatible too right? The common usart compatible looks as follows, compatible = "microchip,sam9x60-usart", "atmel,at91sam9260-usart"; meaning the 1st one is the device specific usart compatible and the 2nd one is the fallback compatible which the driver actually supports. The debug uart looks as follows, compatible = "microchip,sam9x60-dbgu", "atmel,at91sam9260-dbgu", "microchip,sam9x60-usart", "atmel,at91sam9260-usart"; In this case, there is a device specific debug uart compatible, a fallback tot he debug uart compatible and as you said if not used as a debug uart it should fallback and work as a normal uart device which has both a device specific compatible and a fallback to work. In case the device specific compatible is supported with some other features in the driver in the future, the debug uart also should get its perk. Does this make sense? > In addition, the current setup implies that sam9x60 usart supports all > the features that the sam9260 debug usart does. I doubt that that is > true. > > Thanks, > Conor. -- Thanks and Regards, Varshini Rajendran. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel