From: kgene.kim@samsung.com (Kukjin Kim)
To: linux-arm-kernel@lists.infradead.org
Subject: [GIT PULL] Samsung fixes-1 for v3.12
Date: Mon, 14 Oct 2013 09:24:54 +0900 [thread overview]
Message-ID: <16f101cec873$ce47a880$6ad6f980$%kim@samsung.com> (raw)
In-Reply-To: <CAOesGMirL+uR0xL9o0oqhfVa4KKsDeaCjkJyarAJr5vmZPg4Eg@mail.gmail.com>
Olof Johansson wrote:
>
> Hi,
>
Hi,
> On Sun, Oct 13, 2013 at 2:56 PM, Kukjin Kim <kgene.kim@samsung.com> wrote:
> > Alexander Shiyan (1):
> > ARM: SAMSUNG: Fix switching FIFO in arch_enable_uart_fifo function
>
> What's the regression that this is fixing? As far as I can tell, the
> code has been the same since 2008. Or did something surrounding it
> change?
>
Yeah, you're right. Actually I has queued it into non-critical before but
missed to sent out. OK, I agree with you and let me sort out again.
> >
> > Bartlomiej Zolnierkiewicz (1):
> > ARM: dts: fix PL330 MDMA1 address in DT for Universal C210 board
> >
> > Jingoo Han (1):
> > ARM: dts: Remove DP PHY node from exynos5250.dtsi
>
> You are sending this in pretty late. Please be careful about conflicts
> due to this late revert, in particular if you plan on re-introducing
> something in 3.13.
>
As you know, unfortunately, DP PHY node change applied in DTS without
changing driver in 3.12 so current 3.12 kernel cannot support it. I want
3.12 kernel to support it properly and yes, I have a plan to re-introduce DP
PHY node in 3.13. BTW if you have objection, maybe I will send it to stable
3.12 instead...
> > Tomasz Figa (1):
> > ARM: dts: Work around lack of cpufreq regulator lookup for
> > exynos4210-origen and trats boards
> >
> > Youngmin Nam (1):
> > ARM: dts: Fix a typo on Exynos5440 DTS files
>
> This is a bad patch subject, it can be way more specific. Also, this
> is a good reason not to have these elaborate bootargs in the DTS, in
> particular for modern platforms -- the bootargs should come from
> firmware for your platform.
>
Agreed. The subject should be clear...Anyway current bootargs in DTS is
wrong so I think, it should be fixed, I agree with you about bootargs
though.
Thanks,
Kukjin
prev parent reply other threads:[~2013-10-14 0:24 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-13 21:56 [GIT PULL] Samsung fixes-1 for v3.12 Kukjin Kim
2013-10-13 23:02 ` Olof Johansson
2013-10-14 0:24 ` Kukjin Kim [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='16f101cec873$ce47a880$6ad6f980$%kim@samsung.com' \
--to=kgene.kim@samsung.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox