From: arnd@arndb.de (Arnd Bergmann)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 1/3] dmaengine: Add support for APM X-Gene SoC DMA engine driver
Date: Mon, 12 Jan 2015 19:55:02 +0100 [thread overview]
Message-ID: <1701652.4qUlzcU1j2@wuerfel> (raw)
In-Reply-To: <CAFd313xp5rZZZSSKk-DDTC4ccY9ZucGgmWrc9oG-TiK2FMBS1g@mail.gmail.com>
On Monday 12 January 2015 14:40:09 Rameshwar Sahu wrote:
> > +
> > + dma_set_mask_and_coherent(&pdev->dev,
> > + (sizeof(dma_addr_t) == sizeof(u64)) ?
> > + DMA_BIT_MASK(64) : DMA_BIT_MASK(32));
> > +
>
I commented on this on v1 already: always set the device specific mask here,
it's independent of the CPU architecture, but do check the return value.
Also add the correct dma-ranges property in the parent, or else this will
fail in the future once we add proper checks to dma_set_mask.
Arnd
next prev parent reply other threads:[~2015-01-12 18:55 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-07 11:09 [PATCH v2 0/3] dmaengine: APM X-Gene SoC DMA engine driver support Rameshwar Prasad Sahu
2015-01-07 11:09 ` [PATCH v2 1/3] dmaengine: Add support for APM X-Gene SoC DMA engine driver Rameshwar Prasad Sahu
2015-01-12 9:10 ` Rameshwar Sahu
2015-01-12 18:55 ` Arnd Bergmann [this message]
2015-01-14 9:26 ` Rameshwar Sahu
2015-01-14 11:54 ` Arnd Bergmann
2015-01-07 11:09 ` [PATCH v2 2/3] arm64: dts: Add APM X-Gene DMA device and DMA clock DTS nodes Rameshwar Prasad Sahu
2015-01-07 11:09 ` [PATCH v2 3/3] Documentation: dma: Add APM X-Gene SoC DMA engine driver documentation Rameshwar Prasad Sahu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1701652.4qUlzcU1j2@wuerfel \
--to=arnd@arndb.de \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox