* [PATCH] arm64: dts: exynos: fix type of thermal trip points for Exynos7
[not found] <CGME20180515123755eucas1p278a9c1e9cb0101e406e3839e27f8b3b1@eucas1p2.samsung.com>
@ 2018-05-15 12:37 ` Bartlomiej Zolnierkiewicz
2018-05-15 12:59 ` Krzysztof Kozlowski
0 siblings, 1 reply; 3+ messages in thread
From: Bartlomiej Zolnierkiewicz @ 2018-05-15 12:37 UTC (permalink / raw)
To: linux-arm-kernel
Currently Exynos thermal driver treats as "active" all specified
trip points before reaching maximum number of hardware supported
trip points. Moreover polling-delay-passive is specified as "0"
in exynos7.dtsi (IOW passive polling is disabled). Therefore fix
type of cpu-alert-0 to cpu-alert6 trip points to be "active"
instead of "passive" (cpu-alert-7 type is "critical" so it
doesn't need a fixup).
Cc: Alim Akhtar <alim.akhtar@samsung.com>
Signed-off-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
---
arch/arm64/boot/dts/exynos/exynos7-trip-points.dtsi | 14 +++++++-------
1 file changed, 7 insertions(+), 7 deletions(-)
Index: b/arch/arm64/boot/dts/exynos/exynos7-trip-points.dtsi
===================================================================
--- a/arch/arm64/boot/dts/exynos/exynos7-trip-points.dtsi 2018-05-15 13:57:55.822172496 +0200
+++ b/arch/arm64/boot/dts/exynos/exynos7-trip-points.dtsi 2018-05-15 14:23:12.594016481 +0200
@@ -10,37 +10,37 @@ trips {
cpu-alert-0 {
temperature = <75000>; /* millicelsius */
hysteresis = <10000>; /* millicelsius */
- type = "passive";
+ type = "active";
};
cpu-alert-1 {
temperature = <80000>; /* millicelsius */
hysteresis = <10000>; /* millicelsius */
- type = "passive";
+ type = "active";
};
cpu-alert-2 {
temperature = <85000>; /* millicelsius */
hysteresis = <10000>; /* millicelsius */
- type = "passive";
+ type = "active";
};
cpu-alert-3 {
temperature = <90000>; /* millicelsius */
hysteresis = <10000>; /* millicelsius */
- type = "passive";
+ type = "active";
};
cpu-alert-4 {
temperature = <95000>; /* millicelsius */
hysteresis = <10000>; /* millicelsius */
- type = "passive";
+ type = "active";
};
cpu-alert-5 {
temperature = <100000>; /* millicelsius */
hysteresis = <10000>; /* millicelsius */
- type = "passive";
+ type = "active";
};
cpu-alert-6 {
temperature = <110000>; /* millicelsius */
hysteresis = <10000>; /* millicelsius */
- type = "passive";
+ type = "active";
};
cpu-crit-0 {
temperature = <115000>; /* millicelsius */
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH] arm64: dts: exynos: fix type of thermal trip points for Exynos7
2018-05-15 12:37 ` [PATCH] arm64: dts: exynos: fix type of thermal trip points for Exynos7 Bartlomiej Zolnierkiewicz
@ 2018-05-15 12:59 ` Krzysztof Kozlowski
2018-05-15 16:02 ` Bartlomiej Zolnierkiewicz
0 siblings, 1 reply; 3+ messages in thread
From: Krzysztof Kozlowski @ 2018-05-15 12:59 UTC (permalink / raw)
To: linux-arm-kernel
On Tue, May 15, 2018 at 2:37 PM, Bartlomiej Zolnierkiewicz
<b.zolnierkie@samsung.com> wrote:
> Currently Exynos thermal driver treats as "active" all specified
> trip points before reaching maximum number of hardware supported
> trip points.
The trip point type describe the way how system should act - use
active or passive cooling. It is independent of thermal driver. I do
not understand what is exactly wrong... maybe except whether the trip
point is active/passive looks like property of board, not SoC itself,
but your patch does not address it.
> Moreover polling-delay-passive is specified as "0"
> in exynos7.dtsi (IOW passive polling is disabled).
Which is perfectly fine. TMU driver for Exynos7 supports up to eight
trip points in interrupt mode so having polling mode = 0 is good. IOW
passive polling is disabled just like active polling is disabled so
what did you want to say here?
Best regards,
Krzysztof
> Therefore fix
> type of cpu-alert-0 to cpu-alert6 trip points to be "active"
> instead of "passive" (cpu-alert-7 type is "critical" so it
> doesn't need a fixup).
>
> Cc: Alim Akhtar <alim.akhtar@samsung.com>
> Signed-off-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
> ---
> arch/arm64/boot/dts/exynos/exynos7-trip-points.dtsi | 14 +++++++-------
> 1 file changed, 7 insertions(+), 7 deletions(-)
>
> Index: b/arch/arm64/boot/dts/exynos/exynos7-trip-points.dtsi
> ===================================================================
> --- a/arch/arm64/boot/dts/exynos/exynos7-trip-points.dtsi 2018-05-15 13:57:55.822172496 +0200
> +++ b/arch/arm64/boot/dts/exynos/exynos7-trip-points.dtsi 2018-05-15 14:23:12.594016481 +0200
> @@ -10,37 +10,37 @@ trips {
> cpu-alert-0 {
> temperature = <75000>; /* millicelsius */
> hysteresis = <10000>; /* millicelsius */
> - type = "passive";
> + type = "active";
> };
> cpu-alert-1 {
> temperature = <80000>; /* millicelsius */
> hysteresis = <10000>; /* millicelsius */
> - type = "passive";
> + type = "active";
> };
> cpu-alert-2 {
> temperature = <85000>; /* millicelsius */
> hysteresis = <10000>; /* millicelsius */
> - type = "passive";
> + type = "active";
> };
> cpu-alert-3 {
> temperature = <90000>; /* millicelsius */
> hysteresis = <10000>; /* millicelsius */
> - type = "passive";
> + type = "active";
> };
> cpu-alert-4 {
> temperature = <95000>; /* millicelsius */
> hysteresis = <10000>; /* millicelsius */
> - type = "passive";
> + type = "active";
> };
> cpu-alert-5 {
> temperature = <100000>; /* millicelsius */
> hysteresis = <10000>; /* millicelsius */
> - type = "passive";
> + type = "active";
> };
> cpu-alert-6 {
> temperature = <110000>; /* millicelsius */
> hysteresis = <10000>; /* millicelsius */
> - type = "passive";
> + type = "active";
> };
> cpu-crit-0 {
> temperature = <115000>; /* millicelsius */
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH] arm64: dts: exynos: fix type of thermal trip points for Exynos7
2018-05-15 12:59 ` Krzysztof Kozlowski
@ 2018-05-15 16:02 ` Bartlomiej Zolnierkiewicz
0 siblings, 0 replies; 3+ messages in thread
From: Bartlomiej Zolnierkiewicz @ 2018-05-15 16:02 UTC (permalink / raw)
To: linux-arm-kernel
On Tuesday, May 15, 2018 02:59:33 PM Krzysztof Kozlowski wrote:
> On Tue, May 15, 2018 at 2:37 PM, Bartlomiej Zolnierkiewicz
> <b.zolnierkie@samsung.com> wrote:
> > Currently Exynos thermal driver treats as "active" all specified
> > trip points before reaching maximum number of hardware supported
> > trip points.
>
> The trip point type describe the way how system should act - use
> active or passive cooling. It is independent of thermal driver. I do
OK, I see it now. Please disregard this patch.
Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung R&D Institute Poland
Samsung Electronics
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-05-15 16:02 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <CGME20180515123755eucas1p278a9c1e9cb0101e406e3839e27f8b3b1@eucas1p2.samsung.com>
2018-05-15 12:37 ` [PATCH] arm64: dts: exynos: fix type of thermal trip points for Exynos7 Bartlomiej Zolnierkiewicz
2018-05-15 12:59 ` Krzysztof Kozlowski
2018-05-15 16:02 ` Bartlomiej Zolnierkiewicz
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox