From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B8DC1C4332F for ; Tue, 12 Dec 2023 17:23:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=YFvaxHoKOtmhTJju49NHPxTkHF3DPZXoDRDFqvEJ8uE=; b=xt7uEMNXxz9Vkj 7gMaKMn3+IBjdHkHTreJ1eTPWYkSQok8wLqbNg7644I6dtWXnF5yApucEzKN/V2C9L0JTduHSfsJb /N6KoCXn+lpagacfXytviFuU/5ZezQJL2B15/h16K4g4Nribj7AgvVk6kc6zBuRFW3yhsqN+Dfw3Z Nd8tnHGYSo1OTBgbZg2DWJRchYIdrGpVRHmwB/ZPNYJA+Ftzcy4vHoczMAeNVCfbJFbWZrwZfCrFW 6uLZXpj1cEEyRyJqjCJpim4qqlMCJM10EnE10e9MDBefS9yfUUMzS7c5C3KZ0LxT+VW7L45EL7MF/ wg1Sz+Pb2GvTRsKV5Shg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1rD6TF-00CNGX-1F; Tue, 12 Dec 2023 17:23:01 +0000 Received: from dfw.source.kernel.org ([139.178.84.217]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1rD6TD-00CNFr-01 for linux-arm-kernel@lists.infradead.org; Tue, 12 Dec 2023 17:23:00 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 7279361919; Tue, 12 Dec 2023 17:22:58 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 75D12C433C7; Tue, 12 Dec 2023 17:22:56 +0000 (UTC) From: Catalin Marinas To: will@kernel.org, Robin Murphy Cc: mark.rutland@arm.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, jeremy.linton@arm.com, ilkka@os.amperecomputing.com, renyu.zj@linux.alibaba.com Subject: Re: [PATCH] perf/arm-cmn: Fail DTC counter allocation correctly Date: Tue, 12 Dec 2023 17:22:54 +0000 Message-Id: <170240171501.947884.15604728153384166017.b4-ty@arm.com> X-Mailer: git-send-email 2.39.2 In-Reply-To: References: MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231212_092259_082908_9F826680 X-CRM114-Status: UNSURE ( 7.71 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, 11 Dec 2023 19:27:28 +0000, Robin Murphy wrote: > Calling arm_cmn_event_clear() before all DTC indices are allocated is > wrong, and can lead to arm_cmn_event_add() erroneously clearing live > counters from full DTCs where allocation fails. Since the DTC counters > are only updated by arm_cmn_init_counter() after all DTC and DTM > allocations succeed, nothing actually needs cleaning up in this case > anyway, and it should just return directly as it did before. > > [...] Applied to arm64 (for-next/fixes), thanks! [1/1] perf/arm-cmn: Fail DTC counter allocation correctly https://git.kernel.org/arm64/c/1892fe103c3a -- Catalin _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel