From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id BCBEDC46CD3 for ; Tue, 26 Dec 2023 19:40:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Date:Subject:Message-Id:References: In-Reply-To:Cc:To:From:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=zUrvPxUOSgXEFCv3bch8+R+TC/Gn7vLq6B30fHlqAvI=; b=IzP5DfhdCeKchD aYCgawXXKKKlT9g/c5NcSkUUZd+RYNXbMEc2gxpHpx4Y4oIo5zmebuHgf1AcPuvt3UfjCunNhhYUw eAJqnuX78brWhoD3mlSwA8YliqGlL+qMr2mvnycYsQn+JYdVDfWuA3suAnv/bQwyy/g5uXRqO93AP ps+U9HmdcJgidaH9G7sEvN+yasEqUkzat6IUB9UGvox63YF8aqSypkwjeh4cr9it1t9csN+2MfI5L mPATWafCMOQ7Q2iNGVjXhzwiOvFIM6sEcL9D0yn9QYR6UB5lyA1oMmT6Z2KLPmNUiBycAh+LmKsWp tU0YNAyuuVlEki0OwEIA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1rIDHh-00DS7k-1O; Tue, 26 Dec 2023 19:40:13 +0000 Received: from ams.source.kernel.org ([145.40.68.75]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1rIDHe-00DS72-38 for linux-arm-kernel@lists.infradead.org; Tue, 26 Dec 2023 19:40:12 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by ams.source.kernel.org (Postfix) with ESMTP id 1091DB80C6A; Tue, 26 Dec 2023 19:40:08 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id C4920C433C8; Tue, 26 Dec 2023 19:40:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1703619607; bh=VdzXZVqMOKGhvwNwMXvswZIyJ8DA6T8nwMQ7xFwsHv4=; h=From:To:Cc:In-Reply-To:References:Subject:Date:From; b=RFu/e+JWiObWOJx9KIZT9o9FClFdgV0+lxK7WI5/6askgSyKlVXfPq82Z+l0qVBla Dt9YcYriIiinnT8WZ/fzus6zssV4lOTy5/ZLJYRdmcq2GxE0yPBFylpTWrRyM8UBiX Hu1DEtkzxta7nQP0bytHqipuOb+T1nP9cMS7kCLzz08uWYjGAkhlWDCkzAnc+AIQl2 J2YIER106f4hyLrKHm8off+pz1t8FVQJbUXTs+9dQ9burMY2G2A21sssz94b7StHne avXwDiRFLJcdm9vbmcdLPK4NVN/Ez2DwNSKBf4AD/wDOMqGNpTMPN/5OHoY0Q2pvJf RCNanfgfvF+vw== Received: (nullmailer pid 2887138 invoked by uid 1000); Tue, 26 Dec 2023 19:40:03 -0000 MIME-Version: 1.0 From: Rob Herring To: Josua Mayer Cc: Gregory Clement , devicetree@vger.kernel.org, Andrew Lunn , linux-arm-kernel@lists.infradead.org, Conor Dooley , Sebastian Hesselbarth , Krzysztof Kozlowski , Rob Herring , linux-kernel@vger.kernel.org In-Reply-To: <20231226-support-clearfog-gtr-l8-sfp-v3-3-fd1ac2d6bf2e@solid-run.com> References: <20231226-support-clearfog-gtr-l8-sfp-v3-0-fd1ac2d6bf2e@solid-run.com> <20231226-support-clearfog-gtr-l8-sfp-v3-3-fd1ac2d6bf2e@solid-run.com> Message-Id: <170361960357.2887119.16192958166206698998.robh@kernel.org> Subject: Re: [PATCH v3 3/8] dt-bindings: marvell: a38x: add solidrun armada 388 clearfog boards Date: Tue, 26 Dec 2023 13:40:03 -0600 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231226_114011_330427_04F2EABD X-CRM114-Status: GOOD ( 19.50 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, 26 Dec 2023 19:11:34 +0100, Josua Mayer wrote: > Add DT compatible for SolidRun Armada-388 based Clearfog Base and Pro > boards, which are already in place in-tree. > > There are already 3 distinct dts in tree for these *two* boards, > declaring particular compatible strings: > - armada-388-clearfog.dts: > compatible = "solidrun,clearfog-a1", "marvell,armada388", > "marvell,armada385, "marvell,armada380"; > - armada-388-clearfog-base.dts: > compatible = "solidrun,clearfog-base-a1", "solidrun,clearfog-a1", > "marvell,armada388", "marvell,armada385, > "marvell,armada380"; > - armada-388-clearfog-pro.dts: > compatible = "solidrun,clearfog-base-a1", "solidrun,clearfog-a1", > "marvell,armada388", "marvell,armada385, > "marvell,armada380"; > > This has historic reasons, the first entry is a legacy name for the > "pro" version, old versions of u-boot built when only one variant > existed explicitly boot by this name. > > Note that both compatibles and model field include the string "A1". > At least up to revision 2.0 of the board, this had been printed > on the pcb. However in marketing material and conversations it is > usually omitted. "Clearfog Pro" and "Clearfog Pro A1" always mean > exactly the same product. > > Technically Base and Pro variants are similar enough that they can > successfully boot with each other's dts. Hence it makes (some) > sense for them to share the "clearfog-a1" compatible. > > Add bindings for the explicit variants including base / pro suffix. > The legacy "armada-388-clearfog.dts" is not supported by these > bindings" as it does not make sense having two bindings for one board. > > Signed-off-by: Josua Mayer > --- > .../devicetree/bindings/arm/marvell/armada-38x.yaml | 12 ++++++++++++ > 1 file changed, 12 insertions(+) > My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check' on your patch (DT_CHECKER_FLAGS is new in v5.13): yamllint warnings/errors: ./Documentation/devicetree/bindings/arm/marvell/armada-38x.yaml:46:14: [warning] wrong indentation: expected 14 but found 13 (indentation) dtschema/dtc warnings/errors: doc reference errors (make refcheckdocs): See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20231226-support-clearfog-gtr-l8-sfp-v3-3-fd1ac2d6bf2e@solid-run.com The base for the series is generally the latest rc1. A different dependency should be noted in *this* patch. If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure 'yamllint' is installed and dt-schema is up to date: pip3 install dtschema --upgrade Please check and re-submit after running the above command yourself. Note that DT_SCHEMA_FILES can be set to your schema file to speed up checking your schema. However, it must be unset to test all examples with your schema. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel