From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 848C3C47077 for ; Tue, 9 Jan 2024 03:50:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=a0p/gjF6y+U1H80fGcc0MqJylK7yDy5ITM4jOb+1AYQ=; b=3aA1liWW27sDs+ htBgPTjVeP805EVduou7hMT3GMuoAsOAMtxTKEWH7ubPBtnKxuUtvjSU8ARKZ1FpR4Ta1ZvW4tmFW OBq5GaaIt6t8MkROv2C5KBozw1auOc/mHN08TeCx6T78B7rnex5owM2DqZPEMGGoyKeG86c6Ajn99 He+ZSYt9355w01lGSo1Mh7fw0wxpyEDDQMr+pupmExdpjtP82xti+ykuCJD0MPGS1TLzG7PzGfOB7 xXxARVTfp+N5gNc18Nd6Uh6GyJcfz6AGJAydAd80jk6vA2A1LzZx4yvqUiX5QUU2JWRBAa7Z6rMfz wtzKfIFZQWssYrzOE5Lw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1rN37m-006pfv-0w; Tue, 09 Jan 2024 03:49:58 +0000 Received: from dfw.source.kernel.org ([139.178.84.217]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1rN37j-006peP-0n for linux-arm-kernel@lists.infradead.org; Tue, 09 Jan 2024 03:49:56 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 829DD60DEF; Tue, 9 Jan 2024 03:49:54 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 0E57FC433F1; Tue, 9 Jan 2024 03:49:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1704772194; bh=rahJBlD6WKCnL7cz/47HayRSqAAM+zBHOL83nb/2+0E=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=cXADbiyaO/IrZRpiIPE/9Wio7oQ4ImFbFhONLDiODb/FhvXfBbWh2yW6TDsRE5TZH YRhx5B/AGjAIIKht0p0eYMGXtYpLkOk+1ifkAa9LTww2irVTfCW6InHCJIe4NbirGn Jcz+HJnBVPZYVQ6pb9JYrgrKCvTuRKA2f+nNVJSznqH3ZqG+jOZiB+9iOVmJd/t8GA i0LljqEJEIeCGSqsYsYxr+VbcNAyI7V2T92tmJNBAMrATwcmCqZDz89Vl1vd1hZVue PZAo2kUMRdzR7CDPeC3qD0hWZkO9pdiP5YDCOL7Yu4TZKkkB3XzCbgsArUSoiRYceF yXwTsP/oCYpSw== Received: (nullmailer pid 2607265 invoked by uid 1000); Tue, 09 Jan 2024 03:49:52 -0000 Date: Mon, 8 Jan 2024 20:49:52 -0700 From: Rob Herring To: Frank Li Cc: s.hauer@pengutronix.de, hongxing.zhu@nxp.com, helgaas@kernel.org, manivannan.sadhasivam@linaro.org, shawnguo@kernel.org, kw@linux.com, linux-imx@nxp.com, krzysztof.kozlowski+dt@linaro.org, devicetree@vger.kernel.org, imx@lists.linux.dev, krzysztof.kozlowski@linaro.org, bhelgaas@google.com, conor+dt@kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, l.stach@pengutronix.de, linux-pci@vger.kernel.org, festevam@gmail.com, lpieralisi@kernel.org, kernel@pengutronix.de Subject: Re: [PATCH v7 04/16] dt-bindings: imx6q-pcie: Add linux,pci-domain as required for iMX8MQ Message-ID: <170477219183.2607205.10766546617113088833.robh@kernel.org> References: <20231227182727.1747435-1-Frank.Li@nxp.com> <20231227182727.1747435-5-Frank.Li@nxp.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20231227182727.1747435-5-Frank.Li@nxp.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240108_194955_328048_38BBB761 X-CRM114-Status: GOOD ( 15.76 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, 27 Dec 2023 13:27:15 -0500, Frank Li wrote: > iMX8MQ have two pci controllers. Adds "linux,pci-domain" as required > proptery for iMX8MQ to indicate pci controller index. > > This adjustment paves the way for eliminating the hardcoded check on the > base register for acquiring the controller_id. > > ... > if (dbi_base->start == IMX8MQ_PCIE2_BASE_ADDR) > imx6_pcie->controller_id = 1; > ... > > The controller_id is crucial and utilized for certain register bit > positions. It must align precisely with the controller index in the SoC. > An auto-incremented ID don't fit this case. The DTS or fuse configurations > may deactivate specific PCI controllers. > > Signed-off-by: Frank Li > --- > > Notes: > Change from v5 to v6 > - rework commit message to explain why need required and why auto increase > id not work > > Change from v4 to v5 > - new patch at v5 > > .../bindings/pci/fsl,imx6q-pcie-common.yaml | 11 +++++++++++ > 1 file changed, 11 insertions(+) > Reviewed-by: Rob Herring _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel