From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id DA2D5C4829E for ; Fri, 9 Feb 2024 18:31:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=nQX62sDOXUlcIn45UAkoHte6Qteuky+h/zAFuZQW0Uo=; b=n7ZENvpQ6Ea1us i7dgPKt0jdec1prUMXS1LjEznPE2A/udFs3/YKQPetHHhRQHcc5NR8wk+yysF7JLLOSo21ZnUarAA 2GROw+zZ9meyx04Q+6jwTjf254aLdLRlfsnWNqs4PN5NfCeLSZcT2NZ39s4NDLTRZUM8PlSFCvIV6 ddR5ymVqxUtN3K+Dw7F0VmRpQRmFdcl+h+S0vySodF1WcK4faO1n4wlMVf5DAyPrm5nYCJMmPsSZJ GoYFW+PsJBHvTNmxiG0ymz20Up9yKk6vsuoSLORpHSipZkvp+VKwcfPePjwnHAgGUOpd20jH/qE+E m8tzKfH2dwgKv/XRokQQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rYVev-00000000FY8-3ksH; Fri, 09 Feb 2024 18:31:33 +0000 Received: from dfw.source.kernel.org ([139.178.84.217]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rYVen-00000000FTL-2hqr for linux-arm-kernel@lists.infradead.org; Fri, 09 Feb 2024 18:31:27 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id B4C9F62156; Fri, 9 Feb 2024 18:31:24 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 3E320C433C7; Fri, 9 Feb 2024 18:31:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1707503484; bh=yMevUDxLK0NwGJ8Z8pZ5Sin6BlhE8eNPdZ5e6aErPGA=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=ALal7hRT51AXkooxAQe7tbFSCnXqsv1P8A49tGycGrPr0G/Nt/XfREhi1LEjzRdKP iYdxGyAvYp+JTAvxy+oxXMTjrQZ8urT0iOlEgclt4fiS2EBxglUfCPgkusSw5bS+1Z RHrFlIE6GsqJMaC70d1f2gXpPMR6hqB76bOJuuOlStzkCLtndrMlQxLtCAZohbxAwS lANWZNjWkfvEOj7rHxhRin0Us2HIc3i3yx9PAls8BE6L1lToC3qbWnTBGgIcPqEO3M 7vBQnF8lolqpO6OXE/Lz9A7eP/Chhr1a9Fe0gJi5wg1au7AMib/cXFOiAyclggdYlX Z6DSZC3fFSCPg== From: Will Deacon To: linux-arm-kernel@lists.infradead.org, Catalin Marinas , Fangrui Song Cc: kernel-team@android.com, Will Deacon , Ard Biesheuvel , Peter Smith , Jisheng Zhang , linux-kernel@vger.kernel.org, llvm@lists.linux.dev, Dave Martin Subject: Re: [PATCH v2] arm64: jump_label: use constraints "Si" instead of "i" Date: Fri, 9 Feb 2024 18:31:08 +0000 Message-Id: <170749826521.2630324.4507897270923627883.b4-ty@kernel.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20240206074552.541154-1-maskray@google.com> References: <20240206074552.541154-1-maskray@google.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240209_103125_802422_052E4DD8 X-CRM114-Status: GOOD ( 11.19 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, 5 Feb 2024 23:45:52 -0800, Fangrui Song wrote: > The generic constraint "i" seems to be copied from x86 or arm (and with > a redundant generic operand modifier "c"). It works with -fno-PIE but > not with -fPIE/-fPIC in GCC's aarch64 port. > > The machine constraint "S", which denotes a symbol or label reference > with a constant offset, supports PIC and has been available in GCC since > 2012 and in Clang since 7.0. However, Clang before 19 does not support > "S" on a symbol with a constant offset [1] (e.g. > `static_key_false(&nf_hooks_needed[pf][hook])` in > include/linux/netfilter.h), so we use "i" as a fallback. > > [...] Applied to arm64 (for-next/fixes), thanks! [1/1] arm64: jump_label: use constraints "Si" instead of "i" https://git.kernel.org/arm64/c/f9daab0ad01c Cheers, -- Will https://fixes.arm64.dev https://next.arm64.dev https://will.arm64.dev _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel