From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id EFC7CC4829A for ; Tue, 13 Feb 2024 15:40:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Subject:Message-Id:References: In-Reply-To:Cc:To:From:MIME-Version:Date:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Owner; bh=JZNtMj/LMxlB+4QfelMk99HJpTQe4M8kaunN+J/dHNw=; b=xobW+CwTy4sgN0T58BVG9RHI5H BBAul5f6FU3MVzkG7L8wDWWg0aq+RVLwilmefttDQpsvC8FYgpCQxlWNv0lkMeTfAdfsXOK1iQs8t wZp2R8kxNLpPfA0icR+jK/3EP6/vHbzlu/ayEkLdoIGDY0hvcK5adhDD0E8eCw2wJi7fsp9/VbhSy JVKqP+86wYGP3E8W43R6Q8rpsRrMx6ePiAZ9Ns3ImrzQSTPhsQBM3Jy2M+6wpY7F3oh8MNWPuGdws 3MupW6/FMq2uLTS3k5KFVwN7DWDUNHvsgvX6At6irWcla62suBgSVXbh9NGM4QafjBznKAJxGvhVh s8cnEEjg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rZutO-00000009nOV-1vnC; Tue, 13 Feb 2024 15:40:18 +0000 Received: from dfw.source.kernel.org ([2604:1380:4641:c500::1]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rZutM-00000009nO6-13xe; Tue, 13 Feb 2024 15:40:17 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 933C560F5A; Tue, 13 Feb 2024 15:40:15 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id B3F76C433C7; Tue, 13 Feb 2024 15:40:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1707838815; bh=JmajiVMeGbUG4HFBYyxTca1KGVT1oSh0/LH/LKEkvJ4=; h=Date:From:To:Cc:In-Reply-To:References:Subject:From; b=g6dYGbKPjQQFYCbry4zR+rem49mPuNDPIM+DPkrvT05yrocfAqVm3uQ4M98mmKxFa lbFW13RvwixjzA8BQzzv1PzjMgqmKbx6CLBwcDkdzhgnB24DZUohfib/NN2RzknBK0 VKVu8/KCvML2VSiCoqfTX9y4hf2fMXpaVYzGHpRDxYcl7t+zk0JVvPe40da/KxW7dh O98a798e4PUH5+AAuk6zYhBFJa/5okuQdAgrj16DPoVDm8Gv3T4/dJUktcIa7cmHS2 Thi4uFRnjHJed30/JZmYhIzmRv8IzxHfQZbFqK8negW2pKfaRvuS/BrQoiHFa1Oml4 FW+mLYxfuTg3w== Date: Tue, 13 Feb 2024 09:40:13 -0600 MIME-Version: 1.0 From: Rob Herring To: Manojkiran Eda Cc: Rob Herring , Patrick Rudolph , Vignesh Raghavendra , linux-aspeed@lists.ozlabs.org, Conor Dooley , linux-mtd@lists.infradead.org, Joel Stanley , Andrew Jeffery , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, zev@bewilderbeest.net, openbmc@lists.ozlabs.org, Miquel Raynal , Chia-Wei Wang , devicetree@vger.kernel.org, Krzysztof Kozlowski , jk@codeconstruct.com.au, Ryan Chen , Richard Weinberger In-Reply-To: <20240213-espi_driver-v1-1-92741c812843@gmail.com> References: <20240213-espi_driver-v1-1-92741c812843@gmail.com> Message-Id: <170783881259.1420281.1418000696740064343.robh@kernel.org> Subject: Re: [PATCH] Add eSPI device driver (flash channel) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240213_074016_401873_B4741DA3 X-CRM114-Status: GOOD ( 21.05 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, 13 Feb 2024 20:06:08 +0530, Manojkiran Eda wrote: > This patch adds the driver support for the eSPI controller of > Aspeed 5/6th generation SoCs. This controller is a slave device > communicating with a master over Enhanced Serial Peripheral > Interface (eSPI). > > eSPI supports 4 channels, namely peripheral, virtual wire, > out-of-band, and flash, and operates at max frequency of 66MHz. > > But at the moment, this patch set only supports the flash channel. > > Signed-off-by: Manojkiran Eda > --- > Hello everyone, > > I'm presenting a revised version of the eSPI device driver patch series found at the following link: > > https://lore.kernel.org/openbmc/20220516005412.4844-1-chiawei_wang@aspeedtech.com/ > > This update addresses the issues identified during the review process. > > While the previous patch series attempted to incorporate support for all four different channels of eSPI, > this new series focuses on upstreaming the flash channel initially, ensuring that all review comments are > duly addressed, before progressing further. > > Results: > > Successfully conducted a flash update via eSPI. > > Note: > > This marks my inaugural endeavor in contributing code to the kernel subsystem. I kindly request reviewers > to incorporate as many details as possible in the review comments. > --- > .../devicetree/bindings/soc/aspeed/espi.yaml | 125 ++++++ > arch/arm/boot/dts/aspeed/aspeed-g6.dtsi | 16 +- > drivers/mtd/mtdcore.c | 2 +- > drivers/soc/aspeed/Kconfig | 10 + > drivers/soc/aspeed/Makefile | 3 + > drivers/soc/aspeed/aspeed-espi-ctrl.c | 197 +++++++++ > drivers/soc/aspeed/aspeed-espi-ctrl.h | 169 ++++++++ > drivers/soc/aspeed/aspeed-espi-flash.c | 466 +++++++++++++++++++++ > drivers/soc/aspeed/aspeed-espi-flash.h | 45 ++ > include/uapi/linux/espi/aspeed-espi-ioc.h | 103 +++++ > 10 files changed, 1134 insertions(+), 2 deletions(-) > My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check' on your patch (DT_CHECKER_FLAGS is new in v5.13): yamllint warnings/errors: ./Documentation/devicetree/bindings/soc/aspeed/espi.yaml:5:6: [error] string value is redundantly quoted with any quotes (quoted-strings) ./Documentation/devicetree/bindings/soc/aspeed/espi.yaml:6:10: [error] string value is redundantly quoted with any quotes (quoted-strings) dtschema/dtc warnings/errors: doc reference errors (make refcheckdocs): See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20240213-espi_driver-v1-1-92741c812843@gmail.com The base for the series is generally the latest rc1. A different dependency should be noted in *this* patch. If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure 'yamllint' is installed and dt-schema is up to date: pip3 install dtschema --upgrade Please check and re-submit after running the above command yourself. Note that DT_SCHEMA_FILES can be set to your schema file to speed up checking your schema. However, it must be unset to test all examples with your schema. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel