From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 8C050C4829A for ; Tue, 13 Feb 2024 19:21:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Subject:Message-Id:References: In-Reply-To:Cc:To:From:MIME-Version:Date:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Owner; bh=NGllmyyANxh91/s9lYBM0Jne+AC9lFr+CZ4MgaQp5qg=; b=qNiDipxEjjv9X7eHennactljKr 0crmizzWC2AZl4z60AuTuS9zgKwiGvcIUrfoj/RKYhCVD/R749WJmV0sSy7e37QqEEenroRDtDgSi WHg8QEvkXG3Yv7e6Zy1+07jgFMbZkDu6usSvWMRClUXQPB7rG9fUJKjxCXTr/9zT23iobu9GgyR0U iFQUuRMw4JTfzIMul1wAUijr7DEJQI/Qj1D2RVT5X0FErdMd0BW21emH5Biq5QEp8B89EktuTCHbB 13wlSvgvXclJNwuFf+rG5NPyq2iBuFZqf/ft+zSj+wrnaPZDiNBJsQygBzn9bdZ/zhYurYdt/bfrf MV+RrCcA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rZyKw-0000000ARtJ-441Z; Tue, 13 Feb 2024 19:20:58 +0000 Received: from sin.source.kernel.org ([145.40.73.55]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rZyKu-0000000ARs4-29wD for linux-arm-kernel@lists.infradead.org; Tue, 13 Feb 2024 19:20:58 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id E70DECE1E43; Tue, 13 Feb 2024 19:20:54 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id EA009C43390; Tue, 13 Feb 2024 19:20:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1707852054; bh=62+TMzhu0tgv3ZB2azIQJRCmQ4u6vlGyJMQahNrc4uk=; h=Date:From:To:Cc:In-Reply-To:References:Subject:From; b=sbd0fqH+8fvVZaS1HuE3/gKHgknB/hO//wWuduGJaEFz/hazFvc04ACkBmNqNtx8n H7mDZmu6KSOn/t5P4Msus8XXa3SnUz6qf55F1iS7YTgf1Zyrm3TPA+gr8bQjxrF7Pa E42YrmQ6GXCnMHkxl3xqCXtD9+mq+dOKgZvN8HsLGiBTtTDcUTyOZF/JBOnXi2i7Np hfKv02rU9a4xvwksbgoxZUExV3ZCoLIi9dg09ID5eb2L9nZMsOdPWCKx1LRTldneai OA0oYU1Hz6GbJiT7vCCbaG9dNXpQ92iO82K4wIHVTHRzL3Vm0oePYTO3CwsG0dcKlp 6YbKhq522Lj6w== Date: Tue, 13 Feb 2024 13:20:52 -0600 MIME-Version: 1.0 From: Rob Herring To: Tanmay Shah Cc: andersson@kernel.org, robh+dt@kernel.org, devicetree@vger.kernel.org, krzysztof.kozlowski+dt@linaro.org, linux-remoteproc@vger.kernel.org, michal.simek@amd.com, Radhey Shyam Pandey , ben.levinsky@amd.com, linux-kernel@vger.kernel.org, mathieu.poirier@linaro.org, conor+dt@kernel.org, linux-arm-kernel@lists.infradead.org In-Reply-To: <20240213175450.3097308-3-tanmay.shah@amd.com> References: <20240213175450.3097308-1-tanmay.shah@amd.com> <20240213175450.3097308-3-tanmay.shah@amd.com> Message-Id: <170785205177.2155555.1311787541370066483.robh@kernel.org> Subject: Re: [PATCH v10 2/4] dt-bindings: remoteproc: add Tightly Coupled Memory (TCM) bindings X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240213_112056_918550_BF6C3772 X-CRM114-Status: GOOD ( 16.72 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, 13 Feb 2024 09:54:48 -0800, Tanmay Shah wrote: > From: Radhey Shyam Pandey > > Introduce bindings for TCM memory address space on AMD-xilinx Zynq > UltraScale+ platform. It will help in defining TCM in device-tree > and make it's access platform agnostic and data-driven. > > Tightly-coupled memories(TCMs) are low-latency memory that provides > predictable instruction execution and predictable data load/store > timing. Each Cortex-R5F processor contains two 64-bit wide 64 KB memory > banks on the ATCM and BTCM ports, for a total of 128 KB of memory. > > The TCM resources(reg, reg-names and power-domain) are documented for > each TCM in the R5 node. The reg and reg-names are made as required > properties as we don't want to hardcode TCM addresses for future > platforms and for zu+ legacy implementation will ensure that the > old dts w/o reg/reg-names works and stable ABI is maintained. > > It also extends the examples for TCM split and lockstep modes. > > Signed-off-by: Radhey Shyam Pandey > Signed-off-by: Tanmay Shah > --- > > Changes in v10: > - modify number of "reg", "reg-names" and "power-domains" entries > based on cluster mode > - Add extra optional atcm and btcm in "reg" property for lockstep mode > - Add "reg-names" for extra optional atcm and btcm for lockstep mode > - Drop previous Ack as bindings has new change > > Changes in v9: > - None > Changes in v8: > - None > Changes in v7: > - None > Changes in v6: > - None > Changes in v5: > - None > > Changes in v4: > - Use address-cells and size-cells value 2 > - Modify ranges property as per new value of address-cells > and size-cells > - Modify child node "reg" property accordingly > - Remove previous ack for further review > > v4 link: https://lore.kernel.org/all/20230829181900.2561194-2-tanmay.shah@amd.com/ > > .../remoteproc/xlnx,zynqmp-r5fss.yaml | 192 ++++++++++++++++-- > 1 file changed, 170 insertions(+), 22 deletions(-) > My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check' on your patch (DT_CHECKER_FLAGS is new in v5.13): yamllint warnings/errors: ./Documentation/devicetree/bindings/remoteproc/xlnx,zynqmp-r5fss.yaml:118:13: [warning] wrong indentation: expected 10 but found 12 (indentation) dtschema/dtc warnings/errors: doc reference errors (make refcheckdocs): See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20240213175450.3097308-3-tanmay.shah@amd.com The base for the series is generally the latest rc1. A different dependency should be noted in *this* patch. If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure 'yamllint' is installed and dt-schema is up to date: pip3 install dtschema --upgrade Please check and re-submit after running the above command yourself. Note that DT_SCHEMA_FILES can be set to your schema file to speed up checking your schema. However, it must be unset to test all examples with your schema. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel