Re: [PATCH v1 2/6] dt-bindings: interconnect: Add MediaTek EMI Interconnect bindings

From: Rob Herring <robh@kernel.org>
To: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
Cc: keescook@chromium.org, gustavoars@kernel.org,
	 devicetree@vger.kernel.org, djakov@kernel.org,
	henryc.chen@mediatek.com,  linux-pm@vger.kernel.org,
	wenst@chromium.org,  linux-arm-kernel@lists.infradead.org,
	amergnat@baylibre.com,  matthias.bgg@gmail.com,
	lgirdwood@gmail.com,  krzysztof.kozlowski+dt@linaro.org,
	linux-mediatek@lists.infradead.org,  kernel@collabora.com,
	linux-kernel@vger.kernel.org, conor+dt@kernel.org,
	 broonie@kernel.org
Subject: Re: [PATCH v1 2/6] dt-bindings: interconnect: Add MediaTek EMI Interconnect bindings
Date: Tue, 16 Apr 2024 11:33:06 -0500	[thread overview]
Message-ID: <171328518448.2610972.14839354170690825161.robh@kernel.org> (raw)
In-Reply-To: <20240416153805.431118-3-angelogioacchino.delregno@collabora.com>

On Tue, 16 Apr 2024 17:38:01 +0200, AngeloGioacchino Del Regno wrote:
> Add bindings for the MediaTek External Memory Interface Interconnect,
> which providers support system bandwidth requirements through Dynamic
> Voltage Frequency Scaling Resource Collector (DVFSRC) hardware.
> 
> This adds bindings for MediaTek MT8183 and MT8195 SoCs.
> 
> Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
> ---
>  .../interconnect/mediatek,mt8183-emi.yaml     | 76 +++++++++++++++++++
>  .../interconnect/mediatek,mt8183.h            | 23 ++++++
>  .../interconnect/mediatek,mt8195.h            | 44 +++++++++++
>  3 files changed, 143 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/interconnect/mediatek,mt8183-emi.yaml
>  create mode 100644 include/dt-bindings/interconnect/mediatek,mt8183.h
>  create mode 100644 include/dt-bindings/interconnect/mediatek,mt8195.h
> 

My bot found errors running 'make dt_binding_check' on your patch:

yamllint warnings/errors:

dtschema/dtc warnings/errors:
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/interconnect/mediatek,mt8183-emi.example.dtb: dvfsrc@10012000: '#address-cells', '#size-cells' do not match any of the regexes: '@[0-9a-f]+$', 'pinctrl-[0-9]+'
	from schema $id: http://devicetree.org/schemas/soc/mediatek/mediatek,mt8183-dvfsrc.yaml#

doc reference errors (make refcheckdocs):

See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20240416153805.431118-3-angelogioacchino.delregno@collabora.com

The base for the series is generally the latest rc1. A different dependency
should be noted in *this* patch.

If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:

pip3 install dtschema --upgrade

Please check and re-submit after running the above command yourself. Note
that DT_SCHEMA_FILES can be set to your schema file to speed up checking
your schema. However, it must be unset to test all examples with your schema.

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel