From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 6A08AC27C79 for ; Wed, 12 Jun 2024 03:00:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Cc:To:In-Reply-To:References :Date:Message-Id:From:Subject:Content-Transfer-Encoding:MIME-Version: Content-Type:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=OrvMo0674RD2oma9PFkCvvChZaNe4sF2QirJ6zYiTdg=; b=2Svf+no9cFqH9kVtY8Lc+KHkzX 0W0Fkl1QcbO3zZWdl+jLkLg2AI9bipHVQ8AUTzBEN9ft4PGq8H3o1iYlqmghqoOK2ShBaDqHd7kRO OaCpZKiFslvodgVMRiihxZk9vbNdPWME3zVqKnqbzx0hCU1wDnmhHf8HkcqcBP8P6zfJLdPJJktm5 nuxpljaWUVV9WdU27g6kno1fDOZS6Btp5/U5Ku0IOwb+YkuvHe5T8OmlAa0+ismuXLiZQmMM+BV53 hjW2KcAaEJFdyt0wU5sYiBOkX4V10sSwl1c50QcDOekwG9+1nQWQKhc/6tDAuMmSZ3DJpaHR51fQp 2e7YHMBg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sHEE2-0000000ArHD-2TYi; Wed, 12 Jun 2024 03:00:38 +0000 Received: from dfw.source.kernel.org ([2604:1380:4641:c500::1]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sHEDz-0000000ArGo-1Eja for linux-arm-kernel@lists.infradead.org; Wed, 12 Jun 2024 03:00:36 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id CAE2C61263; Wed, 12 Jun 2024 03:00:33 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPS id 76F78C4AF1C; Wed, 12 Jun 2024 03:00:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1718161233; bh=RUXhIiQ650W0ISBjZa4FmMnAKv75xiQwfEYjljSa7Ys=; h=Subject:From:Date:References:In-Reply-To:To:Cc:From; b=egd7vYH1h06yWv8wIa6eIzpxyiFUxxsgc0Xa6iL2sUlaK5z+aOlL3Tf6Y8oMYUD5S FyT3vKJPg/pWFid861HMka3h4RIMx/eAjWQu6dp1lg85sGWvGoazpCugjZ6cb4LzWk SwUXIVazp6Z5EpI48fh4mjpncZbgu9atizAMR5dTqZnlLBCN0ldzTAHkQii6jnye8J tu0fy2/sIjNfiJqw9ZvtzFeS/ldiqSK8WJbYHdHeB77VC3BLcO3vrw6ha/0uXWLzi0 uQvCt4Zh4/NIK2JtzeZAzqYvT1pNPU84Hfv0f2aU1DrNyaAG8Qv0B9CCtGlm8uB6yH Hk/Ec/XJtCs0A== Received: from aws-us-west-2-korg-oddjob-1.ci.codeaurora.org (localhost.localdomain [127.0.0.1]) by aws-us-west-2-korg-oddjob-1.ci.codeaurora.org (Postfix) with ESMTP id 55327C43614; Wed, 12 Jun 2024 03:00:33 +0000 (UTC) Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: Re: [net v5 PATCH] net: stmmac: replace priv->speed with the portTransmitRate from the tc-cbs parameters From: patchwork-bot+netdevbpf@kernel.org Message-Id: <171816123334.11889.9944196119101092125.git-patchwork-notify@kernel.org> Date: Wed, 12 Jun 2024 03:00:33 +0000 References: <20240608143524.2065736-1-xiaolei.wang@windriver.com> In-Reply-To: <20240608143524.2065736-1-xiaolei.wang@windriver.com> To: Xiaolei Wang Cc: olteanv@gmail.com, linux@armlinux.org.uk, andrew@lunn.ch, alexandre.torgue@foss.st.com, joabreu@synopsys.com, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, mcoquelin.stm32@gmail.com, wojciech.drewek@intel.com, netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240611_200035_486132_B9BCEFC6 X-CRM114-Status: GOOD ( 10.58 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hello: This patch was applied to netdev/net.git (main) by Jakub Kicinski : On Sat, 8 Jun 2024 22:35:24 +0800 you wrote: > The current cbs parameter depends on speed after uplinking, > which is not needed and will report a configuration error > if the port is not initially connected. The UAPI exposed by > tc-cbs requires userspace to recalculate the send slope anyway, > because the formula depends on port_transmit_rate (see man tc-cbs), > which is not an invariant from tc's perspective. Therefore, we > use offload->sendslope and offload->idleslope to derive the > original port_transmit_rate from the CBS formula. > > [...] Here is the summary with links: - [net,v5] net: stmmac: replace priv->speed with the portTransmitRate from the tc-cbs parameters https://git.kernel.org/netdev/net/c/be27b8965297 You are awesome, thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html