From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 93867C27C4F for ; Tue, 18 Jun 2024 18:34:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Subject:Message-Id: References:In-Reply-To:Cc:To:From:MIME-Version:Content-Transfer-Encoding: Content-Type:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=rD3PQOi+lASihtOcf1owujd3NX7lcGayfnrFFW/NxXM=; b=QnmYMGPSXFF4BqEMCTVcCs8u2m VaCGlq3bEGGLIwG3+BGvRijLp/h1FMmB78NbL1kt2Hi5ZBXkOMzoO36dtXtNvA5S9dC3J5uttbYwn xa+D0P5KfFutD6gEcFSCwZC1DoHm73ceR2tEeyNymQriOoMAWBe34X66coUAbGS2X1Cz4Jaumi6pB oTjRMGEa9ENr55B9sYcAR/YR5Y/9HySF1sgcni736ifGaPAPgDmGrh9UQ1BL14tBJM+kXG/Surw8N 1HWpzmkeoCu8Av73Yi/XR9TBdqPTzdxvYjDgkkHB56Rr817VYx2Yk568oBkqE+OqQECjOpdWbnQ8Q uTS65teg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sJdf4-0000000GD9P-1iiu; Tue, 18 Jun 2024 18:34:30 +0000 Received: from dfw.source.kernel.org ([2604:1380:4641:c500::1]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sJdf1-0000000GD8P-1L4j for linux-arm-kernel@lists.infradead.org; Tue, 18 Jun 2024 18:34:29 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id E38EC61A3E; Tue, 18 Jun 2024 18:34:25 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 7003EC3277B; Tue, 18 Jun 2024 18:34:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1718735665; bh=/EH5ArnIxXTldmVKp85gUMBSXDolS923UymFh5hxdhU=; h=Date:From:To:Cc:In-Reply-To:References:Subject:From; b=ZFjTk/1F4gbum5LBCqzQ1QbrfVJ83DPkE+2hCqYLIy2JHZO1pQl0GzMB4oU6OgOX0 yPFduL7Cdj2fI72uf48ShzVYeg28GWwfM62YJmBM/j5eWq1D4gg4KPJvqMQjhU1XZE HKOMX0v5mJo0qYr/83ioJd3uYDap7CpiVrnLw54HN/19QvwMYaUtMJYCJ+IJASS3J0 GKlWWfB1K4VBoPaKTKv1hjOO88Abuz3pRMU4fnXABAlczQnKfxuMyaSiO0WOh0NyBo gDasgLtpw0wUMJp0MZ73gHsiJz58yEGrsF30k/QVh97QeSUPTjrKXoL/OI7SVdKFcH KHAuDAEHRLQKw== Date: Tue, 18 Jun 2024 12:34:24 -0600 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 From: "Rob Herring (Arm)" To: Nishanth Menon Cc: linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Conor Dooley , Krzysztof Kozlowski , linux-gpio@vger.kernel.org, Linus Walleij , Tony Lindgren In-Reply-To: <20240618165102.2380159-1-nm@ti.com> References: <20240618165102.2380159-1-nm@ti.com> Message-Id: <171873566448.3500109.16734660300499772836.robh@kernel.org> Subject: Re: [PATCH] dt-bindings: pinctrl: pinctrl-single: Define a max count for "pinctrl-single,gpio-range" X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240618_113427_464714_117E7C0E X-CRM114-Status: GOOD ( 21.16 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, 18 Jun 2024 11:51:02 -0500, Nishanth Menon wrote: > "pinctrl-single,gpio-range" allows us to define a dis-contiguous > range of pinctrl registers that can have different mux settings for > GPIO mode of operation. However, the maxItems seem to be set to 1 in > processed schema for some reason. This is incorrect. For example: > arch/arm64/boot/dts/hisilicon/hi6220.dtsi and others have more than > one dis-contiguous range. > > Arbitrarily define a max 100 count to override the defaults. > > Signed-off-by: Nishanth Menon > --- > I am not sure if I should call this RFC or not.. and if this is even the > right solution.. I am on 2024.05 dt-schema for this check. > > I noticed this when adding gpio-ranges for am62p platform: > https://gist.github.com/nmenon/7019cd2f24be47997640df5db60a7544 > > It is possible that this is a bug in dt-schema, but I have'nt been able > to track it down either. > > behavior seen is the following: > pinctrl-single,gpio-range = <&mcu_pmx_range 0 21 7>; > generates no warning > However, > pinctrl-single,gpio-range = <&mcu_pmx_range 0 21 7>, <&mcu_pmx_range 32 2 7>; > > generates "is too long" warning. > > > Documentation/devicetree/bindings/pinctrl/pinctrl-single.yaml | 1 + > 1 file changed, 1 insertion(+) > My bot found errors running 'make dt_binding_check' on your patch: yamllint warnings/errors: dtschema/dtc warnings/errors: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/pinctrl/pinctrl-single.yaml: properties:pinctrl-single,gpio-range: {'description': 'Optional list of pin base, nr pins & gpio function', '$ref': '/schemas/types.yaml#/definitions/phandle-array', 'maxItems': 100, 'items': [{'items': [{'description': 'phandle of a gpio-range node'}, {'description': 'pin base'}, {'description': 'number of pins'}, {'description': 'gpio function'}]}]} should not be valid under {'required': ['maxItems']} hint: "maxItems" is not needed with an "items" list from schema $id: http://devicetree.org/meta-schemas/items.yaml# doc reference errors (make refcheckdocs): See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20240618165102.2380159-1-nm@ti.com The base for the series is generally the latest rc1. A different dependency should be noted in *this* patch. If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure 'yamllint' is installed and dt-schema is up to date: pip3 install dtschema --upgrade Please check and re-submit after running the above command yourself. Note that DT_SCHEMA_FILES can be set to your schema file to speed up checking your schema. However, it must be unset to test all examples with your schema.