From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 351DCCA9ECB for ; Thu, 31 Oct 2019 16:57:56 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C869520873 for ; Thu, 31 Oct 2019 16:57:55 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="Fs+HbEZA" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C869520873 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=sntech.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=M+lcex3UsXwuIfNhoW1rjnm8Y7p+CydhIEgIXLjZElo=; b=Fs+HbEZAn8ZHLT 5u1iCJszjXDHFHiuxIIHKlwg2RKPkOZd6Ois1EJNcSnMaSvXU9OmLaeuo3jPoOoYduxIGfyQdyc9M xAlYveKxwjn/MQ97SOHSTfw0Yq5dibj/F//9SMV+BXlwnf9201NjPqauUKF8RIM7IVNNZ9iU3Ven1 +1FxdqtspANHaN9JQTZfXJdGVNLai5psm/hBw3IcpZ6qylaWVeeUikDIyOn8ONIb/P+MKvamwJkUK Ul+TwdBBeLBwPL5yAHKJaWWtnyJEZr1Im4L27lmkwCsdLeThFTNy/LKbeph1lq9+f7oYlzhWVsR+o 5aGRgdnakXkAmSQ9u4Kg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1iQDlc-0007yd-2V; Thu, 31 Oct 2019 16:57:48 +0000 Received: from gloria.sntech.de ([185.11.138.130]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1iQDlZ-0007y5-DP; Thu, 31 Oct 2019 16:57:46 +0000 Received: from dhcp-64-28.ens-lyon.fr ([140.77.64.28] helo=phil.localnet) by gloria.sntech.de with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1iQDlQ-0006YQ-Kx; Thu, 31 Oct 2019 17:57:36 +0100 From: Heiko Stuebner To: Markus Reichl Subject: Re: [PATCH] arm64: dts: rockchip: Add PCIe node on rk3399-roc-pc Date: Thu, 31 Oct 2019 17:57:35 +0100 Message-ID: <1719506.vT9a8mQdzu@phil> In-Reply-To: <09300c2d-4298-1b01-ac41-d1b2610589d4@fivetechno.de> References: <09300c2d-4298-1b01-ac41-d1b2610589d4@fivetechno.de> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20191031_095745_606638_1284998B X-CRM114-Status: GOOD ( 19.09 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-rockchip@lists.infradead.org, Rob Herring , Jagan Teki , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi, Am Montag, 28. Oktober 2019, 15:47:27 CET schrieb Markus Reichl: > rk3399-roc-pc has a PCIe interface. Enable it for use with > the M.2 NGFF M_KEY slot on roc-rk3399-mezzanine board. > Tested with Samsung 970 evo plus SSD. > > Signed-off-by: Markus Reichl > --- > .../arm64/boot/dts/rockchip/rk3399-roc-pc.dts | 38 +++++++++++++++++++ > 1 file changed, 38 insertions(+) > > diff --git a/arch/arm64/boot/dts/rockchip/rk3399-roc-pc.dts b/arch/arm64/boot/dts/rockchip/rk3399-roc-pc.dts > index 9313251765c7..2d637d54994b 100644 > --- a/arch/arm64/boot/dts/rockchip/rk3399-roc-pc.dts > +++ b/arch/arm64/boot/dts/rockchip/rk3399-roc-pc.dts > @@ -158,6 +158,21 @@ > regulator-max-microvolt = <1400000>; > vin-supply = <&vcc_sys>; > }; > + > + /* on roc-rk3399-mezzanine board */ I'm undecided on this. From what I've seen that mezzanine board is some sort of addon, like a raspberry pi hat. Therefore it's not always present, so probably should not be part of the base board dts. I'm thinking a dt-overlay that can then be activated might be the solution of choice, but I've reached out to arm-soc poeple on irc to determine the correct course. Heiko > + vcc3v3_pcie: vcc3v3-pcie { > + compatible = "regulator-fixed"; > + regulator-name = "vcc3v3_pcie"; > + enable-active-high; > + gpio = <&gpio1 RK_PC1 GPIO_ACTIVE_HIGH>; > + pinctrl-names = "default"; > + pinctrl-0 = <&vcc3v3_pcie_en>; > + regulator-always-on; > + regulator-boot-on; > + regulator-min-microvolt = <3300000>; > + regulator-max-microvolt = <3300000>; > + vin-supply = <&dc_12v>; > + }; > }; > > &cpu_l0 { > @@ -514,6 +529,19 @@ > status = "okay"; > }; > > +&pcie_phy { > + status = "okay"; > +}; > + > +&pcie0 { > + ep-gpios = <&gpio4 RK_PD1 GPIO_ACTIVE_HIGH>; > + num-lanes = <4>; > + pinctrl-names = "default"; > + pinctrl-0 = <&pcie_perst>; > + vpcie3v3-supply = <&vcc3v3_pcie>; > + status = "okay"; > +}; > + > &pinctrl { > lcd-panel { > lcd_panel_reset: lcd-panel-reset { > @@ -535,6 +563,16 @@ > }; > }; > > + pcie { > + vcc3v3_pcie_en: vcc3v3-pcie-en { > + rockchip,pins = <1 RK_PC1 RK_FUNC_GPIO &pcfg_pull_none>; > + }; > + > + pcie_perst: pcie-perst { > + rockchip,pins = <4 RK_PD1 RK_FUNC_GPIO &pcfg_pull_none>; > + }; > + }; > + > pmic { > vsel1_gpio: vsel1-gpio { > rockchip,pins = <1 RK_PC2 RK_FUNC_GPIO &pcfg_pull_down>; > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel