From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 76434C2BD09 for ; Thu, 27 Jun 2024 19:21:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Subject:Message-Id: References:In-Reply-To:Cc:To:From:MIME-Version:Content-Transfer-Encoding: Content-Type:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=MnQq/poldwgwkiWMB84IzLDgiJr1W11KJh3dyH6BQjo=; b=5GGvm3p/oPNKQlPBR8cMZTt/kJ 6SN/gf18JIXbNe6lz6pVrx7QHGE/oGrUxmbbOONcTUSkeNB0HXp0P1E85SfqGxhddraVH81Qcjvve C+x/4LFst7PnHWcyZY7IKN/C364oldmLaXMC5nFXGpU3AzI6yZDcTqZrFBJtnN9H8WB5J1ZAjoVZD waUS0nBQw+MZ1Wgplvc5nwa3bcRGchjwEiP164/cgzrtrNccXFrV5dmrk7RLOv/BYb0HANiDer0Qk daNeLUXhgK53PclDFpERz5ZEYMNYsvRGq+Lvj9JPIzk5vcvo/y44kXAtEu/Z0R5wW7S54uBFMePED 1PFrPlgQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sMugI-0000000BULj-3H0o; Thu, 27 Jun 2024 19:21:18 +0000 Received: from sin.source.kernel.org ([2604:1380:40e1:4800::1]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sMug9-0000000BUJu-2urb for linux-arm-kernel@lists.infradead.org; Thu, 27 Jun 2024 19:21:11 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id B3619CE2B3D; Thu, 27 Jun 2024 19:21:07 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id B6F05C2BBFC; Thu, 27 Jun 2024 19:21:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1719516067; bh=FOryD7S+p5aFAtNfP8udQczJBOpLw1MnsDwuV4JfYbk=; h=Date:From:To:Cc:In-Reply-To:References:Subject:From; b=rnxGjJzF8XxkpTx+dlI9ryECW9TLz9KVDTjv5lq5zjloUmY9HLXAoMPCNgP9WJt82 wMh/yHKfJiWzVA9IgsSVnYYc6vAOecjn0mxaKehy0ykVpUMcvUodDEX3v5mIxhT6Oo vd6TEVWnvCJPqDgbJV0JoTMg6EXGQpTpBPIW+5J68Z3DCQ9dLXmmSVKVNO7fQfeqgU EdfyiaztSl3Ab+H829rfpZigtyX0QvTIWZFYmSez2ZkI5ioEyK65eeHMZ+1FDz1iNI iwcrWMUKPxXAJTC07wnQAFxAXrc9erFcse920mr56wBaP9HPjKRU37HUGQenlZKxqm 5K3IF9Ei1LUQA== Date: Thu, 27 Jun 2024 13:21:05 -0600 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 From: "Rob Herring (Arm)" To: Ayush Singh Cc: Vignesh Raghavendra , Mark Brown , jkridner@beagleboard.org, devicetree@vger.kernel.org, Arnd Bergmann , Derek Kiernan , Tero Kristo , linux-arm-kernel@lists.infradead.org, Nishanth Menon , linux-spi@vger.kernel.org, Krzysztof Kozlowski , Andrew Lunn , robertcnelson@beagleboard.org, Dragan Cvetic , linux-kernel@vger.kernel.org, Conor Dooley , Vaishnav M A , Greg Kroah-Hartman , Michael Walle In-Reply-To: <20240627-mikrobus-scratch-spi-v5-3-9e6c148bf5f0@beagleboard.org> References: <20240627-mikrobus-scratch-spi-v5-0-9e6c148bf5f0@beagleboard.org> <20240627-mikrobus-scratch-spi-v5-3-9e6c148bf5f0@beagleboard.org> Message-Id: <171951606546.381506.1857123060155544778.robh@kernel.org> Subject: Re: [PATCH v5 3/7] dt-bindings: mikrobus: Add mikrobus-spi binding X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240627_122110_120785_202B4C83 X-CRM114-Status: GOOD ( 17.29 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, 27 Jun 2024 21:56:13 +0530, Ayush Singh wrote: > Add bindings for MikroBUS boards using SPI interface. > > Almost all of the properties that are valid for SPI devices can be used > except reg. Since the goal is to allow use of the same MikroBUS board > across different connectors, config needs to be independent of the actual > SPI controller in mikroBUS port(s), it is not possible to define the > chipselect by number in advance. Thus, `spi-cs-apply` property is used to > specify the chipselect(s) by name. > > Another important fact is that while there is a CS pin in the mikroBUS > connector, some boards (eg SPI Extend Click) use additional pins as > chipselect. Thus we need a way to specify the CS pin(s) in terms of > mikcrobus-connector which can then handle bindings the actual CS pin(s). > > Link: https://www.mikroe.com/spi-extend-click SPI Extend Click > > Signed-off-by: Ayush Singh > --- > .../devicetree/bindings/mikrobus/mikrobus-spi.yaml | 37 ++++++++++++++++++++++ > MAINTAINERS | 1 + > 2 files changed, 38 insertions(+) > My bot found errors running 'make dt_binding_check' on your patch: yamllint warnings/errors: dtschema/dtc warnings/errors: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/mikrobus/mikrobus-spi.example.dtb: thermo-click: compatible: ['maxim,max31855k', 'mikrobus,spi'] is too long from schema $id: http://devicetree.org/schemas/iio/temperature/maxim,max31855k.yaml# /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/mikrobus/mikrobus-spi.example.dtb: thermo-click: 'reg' is a required property from schema $id: http://devicetree.org/schemas/iio/temperature/maxim,max31855k.yaml# /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/mikrobus/mikrobus-spi.example.dtb: thermo-click: Unevaluated properties are not allowed ('compatible', 'pinctrl-apply', 'spi-cs-apply' were unexpected) from schema $id: http://devicetree.org/schemas/iio/temperature/maxim,max31855k.yaml# Documentation/devicetree/bindings/mikrobus/mikrobus-spi.example.dtb: /example-0/thermo-click: failed to match any schema with compatible: ['maxim,max31855k', 'mikrobus,spi'] doc reference errors (make refcheckdocs): See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20240627-mikrobus-scratch-spi-v5-3-9e6c148bf5f0@beagleboard.org The base for the series is generally the latest rc1. A different dependency should be noted in *this* patch. If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure 'yamllint' is installed and dt-schema is up to date: pip3 install dtschema --upgrade Please check and re-submit after running the above command yourself. Note that DT_SCHEMA_FILES can be set to your schema file to speed up checking your schema. However, it must be unset to test all examples with your schema.