From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 20C3CC3065C for ; Tue, 2 Jul 2024 18:44:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:MIME-Version:References:In-Reply-To:Message-Id:Date:Subject:Cc: To:From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=tLvowPXYMqeBAt7BtDfxirxBe2ZcEHh5rwVV7u4b9hk=; b=muItODErNHa1CNACQk7OvNwIM/ RcaE4XkWMrQVgFeVSt+rMogiRvPwz/xzVRq72Va6/Ti2mlb8XVBlTw1dVOs30HfflOFGJNFbbDrWs 0Z31LJvvBx4k9CfHYNHQOxz8O9eaTUf8YoCiUrf1s6traZsTOnmpu8FCH/5mGcFFJzAFWhWSSIlHc UriPETQ15Pls1P4CFMKRzCzlFzvA03gsBWPUQTBfQotc2tv7gB/kXC+MdQePTU/OR5YcywmIYqx/6 hyM8mQ4LQX6UBAHLxrjh16obakRjY3bDOTwStP9VecxmR91kmZPg2YObvdbVb9+92ak0e51fGt56K YelH/9KQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sOiUJ-00000007eqj-3veG; Tue, 02 Jul 2024 18:44:23 +0000 Received: from sin.source.kernel.org ([145.40.73.55]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sOiU7-00000007enH-0qgT for linux-arm-kernel@lists.infradead.org; Tue, 02 Jul 2024 18:44:12 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id 668A0CE0AB8; Tue, 2 Jul 2024 18:44:09 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 5A26CC116B1; Tue, 2 Jul 2024 18:44:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1719945848; bh=66C8i7qkSrSY41acZyFnGawC/LjDY1QgwSkwsu5VS0s=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=mozSCd3LQ4RR4NXWH3TWUirzOerfyBPpGY5vbezVXVhKptqYwaKVkHjtOMullnQms BO3Ivdyj1unEps6wUFIOk6/kPPXD+ALZ7ttiujz31i3BaFsxsGEMsv5Iqub/ofZM5P rhXBLe5PrAUO94C+iZefDL0gXyJmlPrkMo8dLBp2R9Hx+/esqZhH+JojmC6P8Re7vm AYfQ+4Gc9CGqaAeiTQF2Amw29D3ggxFGKp7wPCiLBHufPSEXFNGBiPZAs0vD2wFsz+ /JOiOoTkCuX5z9X82lW9dU3fG60c5WxOPUzK7VBGdNsDP4U9IlQzSOfhW9Mz+iDKW6 uxHj4/KKWzJBQ== From: Will Deacon To: iommu@lists.linux.dev, Joerg Roedel , linux-arm-kernel@lists.infradead.org, Robin Murphy , Jason Gunthorpe Cc: catalin.marinas@arm.com, kernel-team@android.com, Will Deacon , Michael Shavit , Nicolin Chen , patches@lists.linux.dev, Ryan Roberts , Mostafa Saleh Subject: Re: [PATCH v2 00/10] Tidy some minor things in the stream table/cd table area Date: Tue, 2 Jul 2024 19:43:57 +0100 Message-Id: <171993432202.3894040.591624933816619356.b4-ty@kernel.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <0-v2-318ed5f6983b+198f-smmuv3_tidy_jgg@nvidia.com> References: <0-v2-318ed5f6983b+198f-smmuv3_tidy_jgg@nvidia.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240702_114411_449091_50D8D7F2 X-CRM114-Status: GOOD ( 13.93 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, 10 Jun 2024 21:31:09 -0300, Jason Gunthorpe wrote: > Will pointed out that two places referring to the CD/STE struct did not > get the new types. While auditing this code a few more oddities were > noticed. Based on a feedback from Mostafa and Nicolin a few more things > were fixed up too > > - Use types for all the HW structures everywhere even for the L1 > descriptors that are just a single 8 bytes. This helps with clarity of > what everthing is pointing at > - Use indexing helpers for the STE/CD two level calculations > - Use sizeof(struct X) instead of open coded math on constants. The sizeof > naturally follows the type of the related variable in almost all cases > - Remove redundant dma_addr_t's and save some memory > - Remove redundant devm usage > - Use the modern rbtree API > > [...] Applied first two to will (for-joerg/arm-smmu/updates), thanks! [01/10] iommu/arm-smmu-v3: Do not zero the strtab twice https://git.kernel.org/will/c/c84c5ab76c9c [02/10] iommu/arm-smmu-v3: Shrink the strtab l1_desc array https://git.kernel.org/will/c/a4d75360f7a6 Cheers, -- Will https://fixes.arm64.dev https://next.arm64.dev https://will.arm64.dev