Re: [RFC PATCH 4/7] irqchip/apple-aic: Add support for Apple AIC

From: Alexander Graf <graf@amazon.com>
To: Mohamed Mediouni <mohamed.mediouni@caramail.com>,
	<linux-arm-kernel@lists.infradead.org>
Cc: Mark Rutland <mark.rutland@arm.com>,
	Catalin Marinas <catalin.marinas@arm.com>,
	Hector Martin <marcan@marcan.st>,
	linux-kernel@vger.kernel.org, Marc Zyngier <maz@kernel.org>,
	Will Deacon <will@kernel.org>,
	Stan Skowronek <stan@corellium.com>
Subject: Re: [RFC PATCH 4/7] irqchip/apple-aic: Add support for Apple AIC
Date: Wed, 20 Jan 2021 18:11:17 +0100	[thread overview]
Message-ID: <171d8c3f-aa0c-4416-b0d7-d35a47c7acc3@amazon.com> (raw)
In-Reply-To: <20210120132717.395873-5-mohamed.mediouni@caramail.com>

On 20.01.21 14:27, Mohamed Mediouni wrote:
> From: Stan Skowronek <stan@corellium.com>
> 
> Apple SoCs use the Apple AIC interrupt controller.
> The Arm architectural timers is wired over FIQ on that hardware.
> 
> Signed-off-by: Stan Skowronek <stan@corellium.com>
> Signed-off-by: Mohamed Mediouni <mohamed.mediouni@caramail.com>
> ---
>   .../interrupt-controller/apple,aic.yaml       |  49 ++++
>   MAINTAINERS                                   |   6 +
>   drivers/irqchip/Kconfig                       |   6 +
>   drivers/irqchip/Makefile                      |   1 +
>   drivers/irqchip/irq-apple-aic.c               | 211 ++++++++++++++++++
>   5 files changed, 273 insertions(+)
>   create mode 100644 Documentation/devicetree/bindings/interrupt-controller/apple,aic.yaml
>   create mode 100644 drivers/irqchip/irq-apple-aic.c
> 
> diff --git a/Documentation/devicetree/bindings/interrupt-controller/apple,aic.yaml b/Documentation/devicetree/bindings/interrupt-controller/apple,aic.yaml
> new file mode 100644
> index 000000000000..e615eaaca869
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/interrupt-controller/apple,aic.yaml
> @@ -0,0 +1,49 @@
> +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/interrupt-controller/apple,aic.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Apple Advanced Interrupt Controller (AIC)
> +
> +description:
> +  Interrupt controller present on Apple processors. AIC
> +  is used by Apple on their AArch64 SoCs since the Apple A7.
> +
> +maintainers:
> +  - Stan Skowronek <stan@corellium.com>
> +
> +properties:
> +  compatible:
> +    items:
> +      - const: apple,aic
> +
> +  reg:
> +    maxItems: 1
> +
> +  '#interrupt-cells':
> +    const: 3
> +
> +  interrupt-controller: true
> +
> +  fast-ipi:
> +    description:
> +      Fast IPI support.
> +
> +required:
> +  - compatible
> +  - '#interrupt-cells'
> +  - interrupt-controller
> +  - reg
> +
> +additionalProperties: false
> +
> +examples:
> +  - |
> +        aic: interrupt-controller@23b100000 {
> +             compatible = "apple,aic";
> +             #interrupt-cells = <3>;
> +             interrupt-controller;
> +             reg = <0x2 0x3b100000 0x0 0x8000>;
> +             fast-ipi;
> +         };
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 00836f6452f0..e609ede99dd4 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -1218,6 +1218,12 @@ T:	git git://git.kernel.org/pub/scm/linux/kernel/git/jj/linux-apparmor
>   F:	Documentation/admin-guide/LSM/apparmor.rst
>   F:	security/apparmor/
> 
> +APPLE ADVANCED INTERRUPT CONTROLLER DRIVER
> +M:	Stan Skowronek <stan@corellium.com>

Signing someone else up for maintainership is ... unusual :). Do you 
have buy in from Stan that he'll be responsive and handle patch reviews?

> +L:	linux-arm-kernel@lists.infradead.org
> +S:	Maintained
> +F:	drivers/irqchip/irq-apple-aic.c
> +

Alex

Amazon Development Center Germany GmbH
Krausenstr. 38
10117 Berlin
Geschaeftsfuehrung: Christian Schlaeger, Jonathan Weiss
Eingetragen am Amtsgericht Charlottenburg unter HRB 149173 B
Sitz: Berlin
Ust-ID: DE 289 237 879

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel