linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: colin.king@canonical.com (Colin Ian King)
To: linux-arm-kernel@lists.infradead.org
Subject: NAK: [PATCH] usb: gadget: pxa27x: Remove redundant assignment to is_short
Date: Tue, 7 Nov 2017 14:32:14 +0000	[thread overview]
Message-ID: <1721c589-d8db-7c45-dc4a-bd77122d1ece@canonical.com> (raw)
In-Reply-To: <20171107143125.5548-1-colin.king@canonical.com>

On 07/11/17 14:31, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
> 
> Variable is set to zero but this value is never read as it is
> overwritten with a new value later on, hence it is a redundant
> assignment and can be removed. Cleans up clang warning:
> 
> drivers/usb/gadget/udc/pxa27x_udc.c:1141:2: warning: Value stored
> to 'dev' is never read
> 
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
>  drivers/usb/gadget/udc/pxa27x_udc.c | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/drivers/usb/gadget/udc/pxa27x_udc.c b/drivers/usb/gadget/udc/pxa27x_udc.c
> index 14606f340325..e3d362cc47db 100644
> --- a/drivers/usb/gadget/udc/pxa27x_udc.c
> +++ b/drivers/usb/gadget/udc/pxa27x_udc.c
> @@ -984,8 +984,6 @@ static int write_fifo(struct pxa_ep *ep, struct pxa27x_request *req)
>  
>  	max = ep->fifo_size;
>  	do {
> -		is_short = 0;
> -
>  		udccsr = udc_ep_readl(ep, UDCCSR);
>  		if (udccsr & UDCCSR_PC) {
>  			ep_vdbg(ep, "Clearing Transmit Complete, udccsr=%x\n",
> 
Ignore this, sorry. It's wrong

      reply	other threads:[~2017-11-07 14:32 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-11-07 14:31 [PATCH] usb: gadget: pxa27x: Remove redundant assignment to is_short Colin King
2017-11-07 14:32 ` Colin Ian King [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1721c589-d8db-7c45-dc4a-bd77122d1ece@canonical.com \
    --to=colin.king@canonical.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).