From: "Rob Herring (Arm)" <robh@kernel.org>
To: Kevin Chen <kevin_chen@aspeedtech.com>
Cc: krzk+dt@kernel.org, linux-arm-kernel@lists.infradead.org,
andrew@codeconstruct.com.au, devicetree@vger.kernel.org,
sboyd@kernel.org, olof@lixom.net, lee@kernel.org,
u-kumar1@ti.com, conor+dt@kernel.org, quic_bjorande@quicinc.com,
dmitry.baryshkov@linaro.org, p.zabel@pengutronix.de,
linux-aspeed@lists.ozlabs.org, m.szyprowski@samsung.com,
nfraprado@collabora.com, arnd@arndb.de, mturquette@baylibre.com,
soc@kernel.org, will@kernel.org, geert+renesas@glider.be,
catalin.marinas@arm.com, neil.armstrong@linaro.org,
linux-clk@vger.kernel.org, shawnguo@kernel.org, joel@jms.id.au,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 1/9] dt-bindings: mfd: aspeed,ast2x00-scu: Add ASPEED AST2700-SCUX schema
Date: Fri, 02 Aug 2024 04:29:15 -0600 [thread overview]
Message-ID: <172259455507.2558656.18344933444213909682.robh@kernel.org> (raw)
In-Reply-To: <20240802090544.2741206-3-kevin_chen@aspeedtech.com>
On Fri, 02 Aug 2024 17:05:36 +0800, Kevin Chen wrote:
> Add compatible for two SCU of SCU0 and SCU1 in AST2700.
>
> Signed-off-by: Kevin Chen <kevin_chen@aspeedtech.com>
> ---
> .../bindings/mfd/aspeed,ast2x00-scu.yaml | 70 +++++++++++++------
> 1 file changed, 50 insertions(+), 20 deletions(-)
>
My bot found errors running 'make dt_binding_check' on your patch:
yamllint warnings/errors:
dtschema/dtc warnings/errors:
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/mfd/aspeed,ast2x00-scu.yaml: 'scu@ast2xx00-scu' is not one of ['$id', '$schema', 'title', 'description', 'examples', 'required', 'allOf', 'anyOf', 'oneOf', 'definitions', '$defs', 'additionalProperties', 'dependencies', 'dependentRequired', 'dependentSchemas', 'patternProperties', 'properties', 'not', 'if', 'then', 'else', 'unevaluatedProperties', 'deprecated', 'maintainers', 'select', '$ref']
from schema $id: http://devicetree.org/meta-schemas/base.yaml#
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/mfd/aspeed,ast2x00-scu.yaml: 'scu@ast2xx00-scux' is not one of ['$id', '$schema', 'title', 'description', 'examples', 'required', 'allOf', 'anyOf', 'oneOf', 'definitions', '$defs', 'additionalProperties', 'dependencies', 'dependentRequired', 'dependentSchemas', 'patternProperties', 'properties', 'not', 'if', 'then', 'else', 'unevaluatedProperties', 'deprecated', 'maintainers', 'select', '$ref']
from schema $id: http://devicetree.org/meta-schemas/base.yaml#
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/mfd/aspeed,ast2x00-scu.yaml: scu@ast2xx00-scu: Missing additionalProperties/unevaluatedProperties constraint
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/mfd/aspeed,ast2x00-scu.yaml: scu@ast2xx00-scux: Missing additionalProperties/unevaluatedProperties constraint
doc reference errors (make refcheckdocs):
See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20240802090544.2741206-3-kevin_chen@aspeedtech.com
The base for the series is generally the latest rc1. A different dependency
should be noted in *this* patch.
If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:
pip3 install dtschema --upgrade
Please check and re-submit after running the above command yourself. Note
that DT_SCHEMA_FILES can be set to your schema file to speed up checking
your schema. However, it must be unset to test all examples with your schema.
next prev parent reply other threads:[~2024-08-02 10:30 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-02 9:05 [PATCH v1 00/10] Introduce ASPEED AST27XX BMC SoC Kevin Chen
2024-08-02 9:05 ` [PATCH v2 0/9] " Kevin Chen
2024-08-02 9:18 ` Krzysztof Kozlowski
2024-08-02 9:05 ` [PATCH v2 1/9] dt-bindings: mfd: aspeed,ast2x00-scu: Add ASPEED AST2700-SCUX schema Kevin Chen
2024-08-02 9:13 ` Krzysztof Kozlowski
2024-08-02 10:29 ` Rob Herring (Arm) [this message]
2024-08-02 9:05 ` [PATCH v2 2/9] dt-bindings: reset: ast2700: Add ASPEED AST27xx Reset schema Kevin Chen
2024-08-02 9:15 ` Krzysztof Kozlowski
2024-08-02 9:05 ` [PATCH v2 3/9] dt-bindings: clk: ast2700: Add ASPEED AST27XX Clock schema Kevin Chen
2024-08-02 9:15 ` Krzysztof Kozlowski
2024-08-02 9:05 ` [PATCH v2 4/9] clk: ast2700: add clock controller Kevin Chen
2024-08-02 9:16 ` Krzysztof Kozlowski
2024-08-02 19:33 ` Dmitry Baryshkov
2024-10-08 3:10 ` Kevin Chen
2024-10-08 3:41 ` Ryan Chen
2024-08-02 9:05 ` [PATCH v2 5/9] dt-bindings: arm: aspeed: Add ASPEED AST27XX SoC Kevin Chen
2024-08-02 9:16 ` Krzysztof Kozlowski
2024-08-02 9:05 ` [PATCH v2 6/9] arm64: aspeed: Add support for ASPEED AST27XX BMC SoC Kevin Chen
2024-08-02 9:16 ` Krzysztof Kozlowski
2024-08-02 9:05 ` [PATCH v2 7/9] arm64: defconfig: Add ASPEED AST2700 family support Kevin Chen
2024-08-02 19:20 ` Dmitry Baryshkov
2024-08-02 19:25 ` Arnd Bergmann
2024-10-08 3:13 ` Kevin Chen
2024-10-08 3:11 ` Kevin Chen
2024-08-02 9:05 ` [PATCH v2 8/9] arm64: dts: aspeed: Add initial AST27XX device tree Kevin Chen
2024-08-02 9:12 ` Krzysztof Kozlowski
2024-08-02 9:05 ` [PATCH v2 9/9] arm64: dts: aspeed: Add initial AST2700 EVB " Kevin Chen
2024-08-02 9:17 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=172259455507.2558656.18344933444213909682.robh@kernel.org \
--to=robh@kernel.org \
--cc=andrew@codeconstruct.com.au \
--cc=arnd@arndb.de \
--cc=catalin.marinas@arm.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.baryshkov@linaro.org \
--cc=geert+renesas@glider.be \
--cc=joel@jms.id.au \
--cc=kevin_chen@aspeedtech.com \
--cc=krzk+dt@kernel.org \
--cc=lee@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-aspeed@lists.ozlabs.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=m.szyprowski@samsung.com \
--cc=mturquette@baylibre.com \
--cc=neil.armstrong@linaro.org \
--cc=nfraprado@collabora.com \
--cc=olof@lixom.net \
--cc=p.zabel@pengutronix.de \
--cc=quic_bjorande@quicinc.com \
--cc=sboyd@kernel.org \
--cc=shawnguo@kernel.org \
--cc=soc@kernel.org \
--cc=u-kumar1@ti.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox