From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B6318C52D7B for ; Tue, 13 Aug 2024 09:27:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Subject:Message-Id: References:In-Reply-To:Cc:To:From:MIME-Version:Content-Transfer-Encoding: Content-Type:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=+NliUbUqjoY0rwBVtwHrjRv82OKtfUhus9ZMrxeybB4=; b=4XgIZ1LSYsy23g+/NOahoFA4+U +b3KW/j4vShYuOz/EvTuXuJ1qMx5UJG1pzxiD8defE6oZeHLIS0lUZXb2izpULnIERPKII//ItVDV lVws7SKoZRSlIrzrhQOCXTtXnPWEvwyyesmDNEBDr1Jc3/Z11pnFZXkMtwVY32JpxCwdkeZ2BgMkJ o5Y3EDlggT8p7cRPbg5bLbiBKpyNGhfJ0OovW4vgCopJ1y1D8VDp+9tSzjQ81Z6SAmueUGnQKKMJS 2wuaIH/EAC7uuN2eyyUSqxHgj2S00u/ECIH4ARF4K6xQURgR0XOb2O+iNLEs4CwKkB5RbnnK8u3dw RonpZMQw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sdno7-000000038Ja-1NG7; Tue, 13 Aug 2024 09:27:11 +0000 Received: from dfw.source.kernel.org ([2604:1380:4641:c500::1]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sdnnV-0000000388A-1Azr for linux-arm-kernel@lists.infradead.org; Tue, 13 Aug 2024 09:26:34 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id AD2CA61363; Tue, 13 Aug 2024 09:26:32 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 40F1CC4AF09; Tue, 13 Aug 2024 09:26:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1723541192; bh=NSzsztjiA9iy3UQR7+ew34K14a/ro09VqScy6tDCXKk=; h=Date:From:To:Cc:In-Reply-To:References:Subject:From; b=QWvZq02DqjnOJ8grMe/TvFnytAuJca5DVG9WRx1yEcrcQ1RX5FRZZqPtZzzbDa936 8l22+Vqig7fwaTjtkJQOGW6B7ZetdBgbrAP1O9wISlPCGMBXrj8R0NH6uUXDvrQ6iG HS6jfqdTsbH9jSlzcwIanIpyCDu29XNUKUYE+jspQC96gYz63apMMSmAck4c0E7jKM TEN5IJtNkeXh+S4N8a4qwVlT1Ph+KbLbHorGBZ5m62LwsxuYjDk7k+90qEh5+KHrkE Fw4qR+LfR69M1QNjEwRzpQNooVYXugiLxICb3hqDfAQLYxQGGGgiDagL38fI6txIZC E5G1D9Oznapkw== Date: Tue, 13 Aug 2024 03:26:30 -0600 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 From: "Rob Herring (Arm)" To: Kevin Chen Cc: krzk+dt@kernel.org, linux-aspeed@lists.ozlabs.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, tglx@linutronix.de, conor+dt@kernel.org, andrew@codeconstruct.com.au, joel@jms.id.au, devicetree@vger.kernel.org In-Reply-To: <20240813074338.969883-2-kevin_chen@aspeedtech.com> References: <20240813074338.969883-1-kevin_chen@aspeedtech.com> <20240813074338.969883-2-kevin_chen@aspeedtech.com> Message-Id: <172354119091.52485.8216967911640529962.robh@kernel.org> Subject: Re: [PATCH v1 1/2] dt-bindings: interrupt-controller: Add support for ASPEED AST27XX INTC X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240813_022633_443692_BD2C6959 X-CRM114-Status: GOOD ( 12.80 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, 13 Aug 2024 15:43:37 +0800, Kevin Chen wrote: > The ASPEED AST27XX interrupt controller(INTC) combines 32 interrupt > sources into 1 interrupt into GIC from CPU die to CPU die. > The INTC design contains soc0_intc and soc1_intc module doing hand shake > between CPU die and IO die INTC. > > In soc0_intc11, each bit represent 1 GIC_SPI interrupt from soc1_intcX. > In soc1_intcX, each bit represent 1 device interrupt in IO die. > > By soc1_intcX in IO die, AST27XX INTC combines 32 interrupt sources to > 1 interrupt source in soc0_intc11 in CPU die, which achieve the > interrupt passing between the different die in AST27XX. > --- > .../aspeed,ast2700-intc.yaml | 120 ++++++++++++++++++ > 1 file changed, 120 insertions(+) > create mode 100644 Documentation/devicetree/bindings/interrupt-controller/aspeed,ast2700-intc.yaml > My bot found errors running 'make dt_binding_check' on your patch: yamllint warnings/errors: ./Documentation/devicetree/bindings/interrupt-controller/aspeed,ast2700-intc.yaml:24:9: [warning] wrong indentation: expected 10 but found 8 (indentation) ./Documentation/devicetree/bindings/interrupt-controller/aspeed,ast2700-intc.yaml:25:11: [warning] wrong indentation: expected 12 but found 10 (indentation) dtschema/dtc warnings/errors: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/interrupt-controller/aspeed,ast2700-intc.yaml: 'example' is not one of ['$id', '$schema', 'title', 'description', 'examples', 'required', 'allOf', 'anyOf', 'oneOf', 'definitions', '$defs', 'additionalProperties', 'dependencies', 'dependentRequired', 'dependentSchemas', 'patternProperties', 'properties', 'not', 'if', 'then', 'else', 'unevaluatedProperties', 'deprecated', 'maintainers', 'select', '$ref'] from schema $id: http://devicetree.org/meta-schemas/base.yaml# doc reference errors (make refcheckdocs): See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20240813074338.969883-2-kevin_chen@aspeedtech.com The base for the series is generally the latest rc1. A different dependency should be noted in *this* patch. If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure 'yamllint' is installed and dt-schema is up to date: pip3 install dtschema --upgrade Please check and re-submit after running the above command yourself. Note that DT_SCHEMA_FILES can be set to your schema file to speed up checking your schema. However, it must be unset to test all examples with your schema.