From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C4144C52D7C for ; Tue, 13 Aug 2024 16:33:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=+OS5voypzYBjWd1jkbftsHStM01tczv3OrKXunakJrk=; b=RbuPdJV2noxb6pui5T+hwul1Kr tPbHm50+anFwo3JJhzW73Um9hWNIeryxOpSf+vDZS52IOewi+IYFmVwlkXqpoN0gsw4CNSSmOHVke 1dJeIeIdPaAdPUw0VaZe9IVIK8HLyO8SsR+myqOG3l4t17Utsx+Di2MFHYdyZ9NIG/9scS70vnkeO /ePzjKb9nFozdd9ELtbin/vwgHd7+/l0zHQvWtPlDVXryEql47B5otoS1bZypIe9OtbJGGKYuxgVl nt3XCao4Bmj1T6Cq0wke/VSLbs5D54JNEYWPgA6X605tOkEck4tEsRA+oci7J9J7fbruF9vKzDm79 JGWR363A==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sduSl-00000004MHn-3p3u; Tue, 13 Aug 2024 16:33:35 +0000 Received: from sin.source.kernel.org ([2604:1380:40e1:4800::1]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sduS8-00000004M7X-2PWA for linux-arm-kernel@lists.infradead.org; Tue, 13 Aug 2024 16:32:58 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id 9D1DECE10CE; Tue, 13 Aug 2024 16:32:54 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 4634EC4AF11; Tue, 13 Aug 2024 16:32:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1723566773; bh=Kbdfzn/ZdPj0XIrrD6C/Hpkw88aQjKyO1BNvwwISy6Y=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=lwBxoiBsBuh7e5l3TSpyvue+rKJnz9Dh3AWCsJcyadupJ9IrzqJ8Y+0g1RxUddk4i 9MEluCXzd61wHutZbUeQ+9k/mGy6DOsW7StjapsMU9MW+9qp+o/JS/8LyUBR57Ppqk 5xtC8iES35WghvelhEKjoKDQamc+zZjYRVYIWbS/s0A+ibCYTibn/ntBXri7Otztm5 digZiTtpfMWRZkkWMCTULLIsp8DUp+V0YL3YqFiFtgMpsbsZZh/t0fM1d2SBvlgSy/ xCB5ihCiy8SmeHlhDg3F8ieMeAb0zbjzhlkcCA+V6eyWodqB+rLjFJHgOFp6gg+SkY kVOY/x4jY+fFg== Date: Tue, 13 Aug 2024 10:32:51 -0600 From: "Rob Herring (Arm)" To: Richard Zhu Cc: shawnguo@kernel.org, linux-pci@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, conor+dt@kernel.org, imx@lists.linux.dev, linux-kernel@vger.kernel.org, kernel@pengutronix.de, l.stach@pengutronix.de, krzk+dt@kernel.org Subject: Re: [PATCH v5 1/4] dt-bindings: imx6q-pcie: Add reg-name "dbi2" and "atu" for i.MX8M PCIe Endpoint Message-ID: <172356674865.1170023.6976932909595509588.robh@kernel.org> References: <1723534943-28499-1-git-send-email-hongxing.zhu@nxp.com> <1723534943-28499-2-git-send-email-hongxing.zhu@nxp.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1723534943-28499-2-git-send-email-hongxing.zhu@nxp.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240813_093256_856731_7C7B1B5B X-CRM114-Status: GOOD ( 15.70 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, 13 Aug 2024 15:42:20 +0800, Richard Zhu wrote: > Add reg-name: "dbi2", "atu" for i.MX8M PCIe Endpoint. > > For i.MX8M PCIe EP, the dbi2 and atu addresses are pre-defined in the > driver. This method is not good. > > In commit b7d67c6130ee ("PCI: imx6: Add iMX95 Endpoint (EP) support"), > Frank suggests to fetch the dbi2 and atu from DT directly. This commit is > preparation to do that for i.MX8M PCIe EP. > > These changes wouldn't break driver function. When "dbi2" and "atu" > properties are present, i.MX PCIe driver would fetch the according base > addresses from DT directly. If only two reg properties are provided, i.MX > PCIe driver would fall back to the old method. > > Signed-off-by: Richard Zhu > Reviewed-by: Frank Li > --- > .../devicetree/bindings/pci/fsl,imx6q-pcie-ep.yaml | 13 +++++++++---- > 1 file changed, 9 insertions(+), 4 deletions(-) > Please add Acked-by/Reviewed-by tags when posting new versions. However, there's no need to repost patches *only* to add the tags. The upstream maintainer will do that for acks received on the version they apply. If a tag was not added on purpose, please state why and what changed. Missing tags: Reviewed-by: Rob Herring (Arm)