From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0B520CE7B1D for ; Fri, 6 Sep 2024 14:42:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:MIME-Version:References:In-Reply-To:Message-Id:Date:Subject:Cc: To:From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=NoOgJ6sJ/Y1/lxENz3h7FQW5Guh1+cjO5Psd33i0DG8=; b=URTf6ME0AR/WohGVP4pz3Cjmr+ oreeuAT06CoxsV6tISqdyDcETTwxxRqXCiEB4ykgIl2QvGD2/JBWHmuv22ZN5z655C6bgpOLM4d8R 59klgh8oT30abEmTC97D97qbSZupS4cHSaKmNIsvteyd+CY4I9Y8FgKpCmdDP/RVH1TcG0lu1cq7r TV//jD+P6sjUdaGWuustiys6j+VLaq7ewBUs6tRmRK7SSZegJLvemM91qCwoS1dpumWXdvZMHgQ0p 1LFwDSsLw7v2waaEHcTBTv7yGQ4b2aqyo9WkrubvmMH4pT/JCel5m3le/d2FyuIQxePuVDGyS8Rt0 FLuJXEQQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sma9p-0000000CaHS-1Cmv; Fri, 06 Sep 2024 14:41:53 +0000 Received: from dfw.source.kernel.org ([2604:1380:4641:c500::1]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sma3b-0000000CYjd-2GeW for linux-arm-kernel@lists.infradead.org; Fri, 06 Sep 2024 14:35:29 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 4AF1D5C54FB; Fri, 6 Sep 2024 14:35:23 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id E71F2C4CEC4; Fri, 6 Sep 2024 14:35:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1725633326; bh=j9DGI9QJ1v/pRS53VlEA60o8aePK4CIqnJTb7NfSxvA=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=oWEHntdXWyToe3C3vUEaNwXdb7680FcOLSzcojsdp1uNpfqK2Z0RATbGcr9U8ZDSG V4HHXZoXE8bAbWZaonBAXID7SSMnr78805yPZczgIP9gxyHGeARG/QIZJZhRlt2Svb WBd0slKmXU3pN/y3fpE2qujWsbrktOmC6SN77HYDuQ7bufu35QgGau5E7mIl27gTvd 5uOoFHxhKDTfx+ZY5goUymhDwLcK8zCxIrwW8WaWX6DSeoRqvw760JdC9mBR6ghyp3 18PWQSvfjYAbVYBzPPJLogG9yU6ypuhdBBTx5A12Yxr3F+ZZ1le1Zv75+rJvkVO25+ up/MYh476nAmg== From: Will Deacon To: iommu@lists.linux.dev, Joerg Roedel , linux-arm-kernel@lists.infradead.org, Robin Murphy , Jason Gunthorpe Cc: catalin.marinas@arm.com, kernel-team@android.com, Will Deacon , Michael Shavit , Nicolin Chen , patches@lists.linux.dev, Ryan Roberts , Mostafa Saleh Subject: Re: [PATCH v3 0/9] Tidy some minor things in the stream table/cd table area Date: Fri, 6 Sep 2024 15:35:17 +0100 Message-Id: <172562904958.411706.13455091898578049664.b4-ty@kernel.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <0-v3-9fef8cdc2ff6+150d1-smmuv3_tidy_jgg@nvidia.com> References: <0-v3-9fef8cdc2ff6+150d1-smmuv3_tidy_jgg@nvidia.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240906_073527_644608_8322D212 X-CRM114-Status: GOOD ( 13.24 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, 06 Aug 2024 20:31:14 -0300, Jason Gunthorpe wrote: > Will pointed out that two places referring to the CD/STE struct did not > get the new types. While auditing this code a few more oddities were > noticed. Based on a feedback from Mostafa and Nicolin a few more things > were fixed up too > > - Use types for all the HW structures everywhere even for the L1 > descriptors that are just a single 8 bytes. This helps with clarity of > what everthing is pointing at > - Use indexing helpers for the STE/CD two level calculations > - Use sizeof(struct X) instead of open coded math on constants. The sizeof > naturally follows the type of the related variable in almost all cases > - Remove redundant dma_addr_t's and save some memory > - Remove redundant devm usage > - Use the modern rbtree API > > [...] Applied first change to will (for-joerg/arm-smmu/updates), thanks! [1/9] iommu/arm-smmu-v3: Use the new rb tree helpers https://git.kernel.org/will/c/a2bb820e862d Cheers, -- Will https://fixes.arm64.dev https://next.arm64.dev https://will.arm64.dev