From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 40764CDD552 for ; Wed, 18 Sep 2024 19:38:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Subject:Message-Id: References:In-Reply-To:Cc:To:From:MIME-Version:Content-Transfer-Encoding: Content-Type:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=Bs3GTX8qaPjUReOwvqZCIYhrNsGoqMw9UYTQ6PDNqI8=; b=31jMQanNoNFbSTRNk1OM++1Vgs g4ZGqzyFd7mljcISMFmIu2KaWj0j3arz4HhXXJbv8c795Mr3FAdToAzij+Prssuq04Utmjv6pqzSk OcTYdRjrjLWgNiYqdKdW9vq9ZZqTqRSLul3BqBvdskXCAhL3otFShSHauZFGoHKrzlbYOBhAqd5lx 3Wi1yyJlb9B4WTcsVapn0/QwkcudqjSC4u1qVcLnij7EefvMQXlf4X8/I6XA5ws7bnrSZh2X71P5X gBQY1SLvcOtUsuXGazDKJp7BRUar8VS73PHzJMA5i1/4BWdscXpmIu+oS14nysTSPUkkaiYj7cXeS ZPyLBW4Q==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1sr0V3-00000008tmw-1aUZ; Wed, 18 Sep 2024 19:38:05 +0000 Received: from dfw.source.kernel.org ([139.178.84.217]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1sr0Tw-00000008tco-0Mrk for linux-arm-kernel@lists.infradead.org; Wed, 18 Sep 2024 19:36:57 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 7277D5C5955; Wed, 18 Sep 2024 19:36:51 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 9C097C4CEC2; Wed, 18 Sep 2024 19:36:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1726688214; bh=5bZ1Yoj6niUYHDQb1J8phNqCotVR8fsQiObDLwdQHjc=; h=Date:From:To:Cc:In-Reply-To:References:Subject:From; b=EcwQzjPC9CaubYEDs7x9Z7+tBDpe3i+Nrm0uxqCk3SuHrtamBvgtk1kEfJLyProkR 47AYnWV6xNTd6jJGKmK+RKX+p80hQUOUHeWCLcW/I33Y5PszqlEfI3wf/sz3pjjmtz Cd9HKm/12ACZwi0IExzyWb1GloGVy5QbzgON5nyw4OuSxCKmzAyveWU58LkOJJ5Cy+ iYEjy+mha63NWJGJv6LKwNptiuf+HCB6UWXkz9FgiUeeumbDoPeQF5AnXHfvNKxzbG cJkgfW7LpCPCuckLDSeFO9FWUJbHt0qBVXbGs+jv2atpYBeR2NE1bHoQ/Q7/Y/ZD5C n7v0wQArrrRPQ== Date: Wed, 18 Sep 2024 14:36:53 -0500 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 From: "Rob Herring (Arm)" To: Laurentiu Mihalcea Cc: Conor Dooley , Krzysztof Kozlowski , Daniel Baluta , Shengjiu Wang , Iuliana Prodan , linux-kernel@vger.kernel.org, Sascha Hauer , linux-arm-kernel@lists.infradead.org, imx@lists.linux.dev, Shawn Guo , devicetree@vger.kernel.org In-Reply-To: <20240918182117.86221-2-laurentiumihalcea111@gmail.com> References: <20240918182117.86221-1-laurentiumihalcea111@gmail.com> <20240918182117.86221-2-laurentiumihalcea111@gmail.com> Message-Id: <172668821340.2009095.10209806970812964896.robh@kernel.org> Subject: Re: [PATCH 1/5] dt-bindings: dsp: fix power domain count X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240918_123656_285241_8CEA781F X-CRM114-Status: GOOD ( 16.98 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, 18 Sep 2024 14:21:13 -0400, Laurentiu Mihalcea wrote: > From: Laurentiu Mihalcea > > Per the current binding, QM/QXP DSPs are supposed > to have 4 power domains, while the rest just 1. > For QM/QXP, the 4 power domains are: DSP, DSP_RAM, > MU13A, MU13B. > > First off, drop MU13A from the count. This is attached > to the platform device of lsio_mu13. This decreases the > count to 3. > > Secondly, drop DSP and DSP_RAM from the count for QXP. > These are attached to the platform devices of the lpcgs > (used as clock providers for the DSP). > > With this in mind, the number of required power domains for > QXP is 1 (MU13B), while for QM it's 3 (MU13B, DSP, DSP_RAM). > > Additionally, two extra power domains may be required in the > case of QM/QXP DSPs. These are IRQSTR_DSP and MU2A. For the nodes > using the "-hifi4" compatibles these PDs are optional, while for > nodes using the "-dsp" compatibles these are mandatory. > > These changes reflect all of this information. > > Signed-off-by: Laurentiu Mihalcea > --- > .../devicetree/bindings/dsp/fsl,dsp.yaml | 62 +++++++++++++++---- > 1 file changed, 49 insertions(+), 13 deletions(-) > My bot found errors running 'make dt_binding_check' on your patch: yamllint warnings/errors: dtschema/dtc warnings/errors: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/mailbox/arm,mhuv2.example.dtb: dsp@596e8000: power-domains: [[4294967295, 0], [4294967295, 1], [4294967295, 2], [4294967295, 3]] is too long from schema $id: http://devicetree.org/schemas/dsp/fsl,dsp.yaml# doc reference errors (make refcheckdocs): See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20240918182117.86221-2-laurentiumihalcea111@gmail.com The base for the series is generally the latest rc1. A different dependency should be noted in *this* patch. If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure 'yamllint' is installed and dt-schema is up to date: pip3 install dtschema --upgrade Please check and re-submit after running the above command yourself. Note that DT_SCHEMA_FILES can be set to your schema file to speed up checking your schema. However, it must be unset to test all examples with your schema.