From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 6B9A6CFB448 for ; Mon, 7 Oct 2024 15:50:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:MIME-Version:Date:Message-Id:Subject:References:In-Reply-To:Cc: To:From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=BfRjTc9Dq75Gr0UmEQ1NsEFNu5s5z4DSfAsEt4CvtjA=; b=aSZbBn7Rk8s6myKUQ7+RSia/G5 bLrS+pmiS6M2qu9KGatAavet/gBHEGY0GonBbKcjV/GqU/iHLN5C39lrzwtsb9jjsoAUBK/DMNijJ Oz/20jp0VPeLh5+6IYpZbTcqhlVOh02egY/BAwvGVP+FCOolzit34fn+A0u6AbZe5eqznapDOS3da esznT68jUXd376+EWsef54LzYpW0NR0ZcSA9C3L5TalWkaru5uWCl0cXZ/bsKup7pcN1W/DbRPIRn iq5ryqEtpl8NeNHxqnww4+X5HblF1zYCMvJapz535aur0B2YdGgZ8lv3M14qAdbk398CZFEpZUfmS oCfTdl+Q==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1sxq05-0000000321c-0o51; Mon, 07 Oct 2024 15:50:21 +0000 Received: from dfw.source.kernel.org ([2604:1380:4641:c500::1]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1sxpyl-000000031et-22nW; Mon, 07 Oct 2024 15:49:01 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 8D8915C5C1B; Mon, 7 Oct 2024 15:48:54 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 806ABC4CECF; Mon, 7 Oct 2024 15:48:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1728316138; bh=AmnZGoC6d9JOz7Nbe+RZvuUjltSac8yKHkvPAr+paMM=; h=From:To:Cc:In-Reply-To:References:Subject:Date:From; b=Dx525gKB/36rAxVVOUKDXn7PHyEgnKQMOOUP6Yqc965PrhHfL+nzYX8n8c7V/7/14 qPphRKBLhYt0feXqHz1SinDI0oGjZy/A+ua6oGpNIfOhKwlTDb/zn3/JsbD4M6GYC0 wk/vnweQW8aiq0IRs1qYlnRK17h3mYlJbocXiqp78xpuPxDxHWSY1S8pU10kVOrIlY GFW5+RXGiOORnfsnRsfM+KSulrqzgl5DZKpkwNGmMp+TN9+TJMM7iJHczYyizPurSQ 2Adsy2R5+HSQf5YHmWp26fASq9gOf7yCw7jvXUfwsQdzhHb2q9/Am0yosLSCcDWc+o B0ZVzSph/zW1g== From: Vinod Koul To: linux-rockchip@lists.infradead.org, linux-phy@lists.infradead.org, Dragan Simic Cc: kishon@kernel.org, heiko@sntech.de, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org In-Reply-To: References: Subject: Re: [PATCH v3 0/3] Improve error handling in Rockchip Inno USB 2.0 PHY driver Message-Id: <172831613615.134526.763385674253589863.b4-ty@kernel.org> Date: Mon, 07 Oct 2024 21:18:56 +0530 MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-Mailer: b4 0.14.2 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20241007_084859_609389_BA107D67 X-CRM114-Status: GOOD ( 11.03 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, 05 Sep 2024 10:28:21 +0200, Dragan Simic wrote: > This is a small series that improves error handling in the probe path > of the Rockchip Innosilicon USB 2.0 PHY driver, by returning the actual > error code in one place and by using dev_err_probe() properly in multiple > places. It also performs a bunch of small, rather trivial code cleanups, > to make the code neater and a bit easier to read. > > Changes in v3: > - Collected Reviewed-by tags from Heiko for patches 1/3 and 2/3 > - Brought back one empty line as a separator of dissimilar operations > in patch 1/3, as suggested by Heiko [2] > - Dropped one backward conversion of dev_err_probe() to dev_err() in > patch 3/3, as suggested by Heiko, [3] and adjusted the summary and > description of patch 3/3 accordingly > > [...] Applied, thanks! [1/3] phy: phy-rockchip-inno-usb2: Perform trivial code cleanups commit: 449d2a523a0c3ca8f4c993b8e37795c2aa174da6 [2/3] phy: phy-rockchip-inno-usb2: Handle failed extcon allocation better commit: 595ad7a336bf21f9d111a033820cd95d70343bd1 [3/3] phy: phy-rockchip-inno-usb2: Use dev_err_probe() in the probe path commit: 40452520850683f6771094ca218ff206d1fcb022 Best regards, -- ~Vinod