From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id EBB61D15DBB for ; Tue, 22 Oct 2024 11:38:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:MIME-Version:References:In-Reply-To:Message-Id:Date:Subject:Cc: To:From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=k8cuNoyu5FERr0l0hQmQRFwoHaj4S1CpmSQ5JDWFmzg=; b=Utk36jQiBhsAkm90uFnMT1MPzh iVYTEBMtR5lVunyE2FALHlB5P2r5tlI+KmW+E3KpU6gTn9FoZuaS+Ay42dHs5M2qJrG9iBz44R8kb 8NJlF521tVijg4NAvBx/4yrYutupx7QbVPgSt82Qi79CGbWfF7Tb+ug6EBohyxczS5WH6jvdVdC33 PK4HbwXr/EI4BxSrlwbTXHAVEfQUg+v89MUjx4Jm6hJZHodg1cY+hLrHIw47OY64UU+UwoXwUzfSt UirryDu46Z9jK4hKVrFhwzahG0wdcwbh7AFGXr0p+y4Sj3MVqCpws4BHkfSPvBxrRH/n2IQRpALkB S9fFUPhg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1t3DDa-0000000AiYF-0dyY; Tue, 22 Oct 2024 11:38:30 +0000 Received: from dfw.source.kernel.org ([139.178.84.217]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1t3DC3-0000000AiNb-0TVV for linux-arm-kernel@lists.infradead.org; Tue, 22 Oct 2024 11:36:56 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id E1C505C543F; Tue, 22 Oct 2024 11:36:49 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 55B9BC4CECD; Tue, 22 Oct 2024 11:36:52 +0000 (UTC) From: Catalin Marinas To: linux-arm-kernel@lists.infradead.org, Ard Biesheuvel Cc: Will Deacon , linux-kernel@vger.kernel.org, linux-crypto@vger.kernel.org, herbert@gondor.apana.org.au, Ard Biesheuvel , Eric Biggers , Kees Cook Subject: Re: [PATCH v4 0/3] arm64: Speed up CRC-32 using PMULL instructions Date: Tue, 22 Oct 2024 12:36:49 +0100 Message-Id: <172959700464.951219.12544487122968669454.b4-ty@arm.com> X-Mailer: git-send-email 2.39.5 In-Reply-To: <20241018075347.2821102-5-ardb+git@google.com> References: <20241018075347.2821102-5-ardb+git@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20241022_043655_216319_CAD9B9B4 X-CRM114-Status: GOOD ( 10.32 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, 18 Oct 2024 09:53:48 +0200, Ard Biesheuvel wrote: > The CRC-32 code is library code, and is not part of the crypto > subsystem. This means that callers may not generally be aware of the > kind of implementation that backs it, and so we've refrained from using > FP/SIMD code in the past, as it disables preemption, and this may incur > scheduling latencies that the caller did not anticipate. > > This was solved a while ago, and on arm64, kernel mode FP/SIMD no longer > disables preemption. > > [...] Applied to arm64 (for-next/crc32), thanks! [1/3] arm64/lib: Handle CRC-32 alternative in C code https://git.kernel.org/arm64/c/fc7454107d1b [2/3] arm64/crc32: Reorganize bit/byte ordering macros https://git.kernel.org/arm64/c/b98b23e19492 [3/3] arm64/crc32: Implement 4-way interleave using PMULL https://git.kernel.org/arm64/c/a6478d69cf56 -- Catalin