[PATCH 0/5] drm: add missing dependencies

[PATCH 0/5] drm: add missing dependencies

[Arnd Bergmann]

I did lots of randconfig tests over time, which resulted in many patches,
five of which are for drm. In each of these cases, the Kconfig dependencies
are incomplete, which can lead to broken builds, and specifying the
complete dependencies solves it.

The patches are all independent from one another and solve separate
issues. Please apply.

Arnd Bergmann (5):
  drm: panel/sharp: add backlight dependency
  drm: panel/simple: add backlight dependency
  drm: rockchip: add reset controller dependency
  drm: sti: add panel dependency
  drm: msm: add missing dependencies on OF and COMMON_CLK

 drivers/gpu/drm/msm/Kconfig      | 1 +
 drivers/gpu/drm/panel/Kconfig    | 2 ++
 drivers/gpu/drm/rockchip/Kconfig | 1 +
 drivers/gpu/drm/sti/Kconfig      | 1 +
 4 files changed, 5 insertions(+)

-- 
2.1.0.rc2

[PATCH 1/5] drm: panel/sharp: add backlight dependency

[Arnd Bergmann]

The sharp panel code uses the backlight interface to
find a device, which fails when backlight is disabled:

drivers/built-in.o: In function `sharp_panel_probe':
:(.text+0x5ceac): undefined reference to `of_find_backlight_by_node'

Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
 drivers/gpu/drm/panel/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/gpu/drm/panel/Kconfig b/drivers/gpu/drm/panel/Kconfig
index 024e98ef8e4d..84506053a7ca 100644
--- a/drivers/gpu/drm/panel/Kconfig
+++ b/drivers/gpu/drm/panel/Kconfig
@@ -31,6 +31,7 @@ config DRM_PANEL_SHARP_LQ101R1SX01
 	tristate "Sharp LQ101R1SX01 panel"
 	depends on OF
 	depends on DRM_MIPI_DSI
+	depends on BACKLIGHT_CLASS_DEVICE
 	help
 	  Say Y here if you want to enable support for Sharp LQ101R1SX01
 	  TFT-LCD modules. The panel has a 2560x1600 resolution and uses
-- 
2.1.0.rc2

[PATCH 2/5] drm: panel/simple: add backlight dependency

[Arnd Bergmann]

The simple panel code uses the backlight interface to
find a device, which fails when backlight is disabled:

drivers/built-in.o: In function `panel_simple_platform_probe':
:(.text+0xd3c48): undefined reference to `of_find_backlight_by_node'

Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
 drivers/gpu/drm/panel/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/gpu/drm/panel/Kconfig b/drivers/gpu/drm/panel/Kconfig
index 84506053a7ca..d84583776d50 100644
--- a/drivers/gpu/drm/panel/Kconfig
+++ b/drivers/gpu/drm/panel/Kconfig
@@ -10,6 +10,7 @@ menu "Display Panels"
 config DRM_PANEL_SIMPLE
 	tristate "support for simple panels"
 	depends on OF
+	depends on BACKLIGHT_CLASS_DEVICE
 	help
 	  DRM panel driver for dumb panels that need at most a regulator and
 	  a GPIO to be powered up. Optionally a backlight can be attached so
-- 
2.1.0.rc2

[PATCH 3/5] drm: rockchip: add reset controller dependency

[Arnd Bergmann]

When the reset controller subsystem is disabled, this driver
fails to build:

drivers/gpu/drm/rockchip/rockchip_drm_vop.c: In function 'vop_initial':
drivers/gpu/drm/rockchip/rockchip_drm_vop.c:1267:2: error: implicit declaration of function 'devm_reset_control_get' [-Werror=implicit-function-declaration]

The easiest solution is to add a dependency in Kconfig to avoid
that case.

Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
 drivers/gpu/drm/rockchip/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/gpu/drm/rockchip/Kconfig b/drivers/gpu/drm/rockchip/Kconfig
index cb21e3821244..35215f6867d3 100644
--- a/drivers/gpu/drm/rockchip/Kconfig
+++ b/drivers/gpu/drm/rockchip/Kconfig
@@ -1,6 +1,7 @@
 config DRM_ROCKCHIP
 	tristate "DRM Support for Rockchip"
 	depends on DRM && ROCKCHIP_IOMMU
+	depends on RESET_CONTROLLER
 	select DRM_KMS_HELPER
 	select DRM_KMS_FB_HELPER
 	select DRM_PANEL
-- 
2.1.0.rc2

[PATCH 4/5] drm: sti: add panel dependency

[Arnd Bergmann]

The newly added sti driver requires the drm_panel helpers,
and we get a link error if they are not enabled

ERROR: "drm_panel_attach" [drivers/gpu/drm/sti/stidvo.ko] undefined!
ERROR: "of_drm_find_panel" [drivers/gpu/drm/sti/stidvo.ko] undefined!

This adds a 'select' statement as we have for the other drivers.

Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
 drivers/gpu/drm/sti/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/gpu/drm/sti/Kconfig b/drivers/gpu/drm/sti/Kconfig
index d6d6b705b8c1..20d5f7787667 100644
--- a/drivers/gpu/drm/sti/Kconfig
+++ b/drivers/gpu/drm/sti/Kconfig
@@ -5,6 +5,7 @@ config DRM_STI
 	select DRM_KMS_HELPER
 	select DRM_GEM_CMA_HELPER
 	select DRM_KMS_CMA_HELPER
+	select DRM_PANEL
 	select FW_LOADER_USER_HELPER_FALLBACK
 	help
 	  Choose this option to enable DRM on STM stiH41x chipset
-- 
2.1.0.rc2

[PATCH] drm: msm: add missing dependencies on OF and COMMON_CLK

[Arnd Bergmann]

The msm gpu drivers depend on both the DT mechanism and the
common clk handling code, if they are not enabled, we get
a number of build errors:

In file included from drivers/gpu/drm/msm/hdmi/hdmi.h:27:0,
                 from drivers/gpu/drm/msm/hdmi/hdmi_bridge.c:18:
drivers/gpu/drm/msm/msm_drv.h:45:24: fatal error: mach/board.h: No such file or directory
 #include <mach/board.h>
                        ^

drivers/gpu/drm/msm/hdmi/hdmi_phy_8960.c:503:2: error: implicit declaration of function 'devm_clk_register' [-Werror=implicit-function-declaration]

Signed-off-by: Arnd Bergmann <arnd@arndb.de>

diff --git a/drivers/gpu/drm/msm/Kconfig b/drivers/gpu/drm/msm/Kconfig
index 5b2a1ff95d3d..bacbbb70f679 100644
--- a/drivers/gpu/drm/msm/Kconfig
+++ b/drivers/gpu/drm/msm/Kconfig
@@ -3,6 +3,7 @@ config DRM_MSM
 	tristate "MSM DRM"
 	depends on DRM
 	depends on ARCH_QCOM || (ARM && COMPILE_TEST)
+	depends on OF && COMMON_CLK
 	select REGULATOR
 	select DRM_KMS_HELPER
 	select DRM_PANEL

[PATCH] drm: msm: add missing dependencies on OF and COMMON_CLK

[Arnd Bergmann]

On Wednesday 28 January 2015 14:48:09 Arnd Bergmann wrote:
> The msm gpu drivers depend on both the DT mechanism and the
> common clk handling code, if they are not enabled, we get
> ...

As should be obvious, this one was meant to be [PATCH 5/5], but
I messed up the subject line.

	Arnd

[PATCH 0/5] drm: add missing dependencies

[Dave Airlie]

On 28 January 2015 at 23:48, Arnd Bergmann <arnd@arndb.de> wrote:
> I did lots of randconfig tests over time, which resulted in many patches,
> five of which are for drm. In each of these cases, the Kconfig dependencies
> are incomplete, which can lead to broken builds, and specifying the
> complete dependencies solves it.
>
> The patches are all independent from one another and solve separate
> issues. Please apply.

Thanks Arnd, I've taken these all into drm-next in case any is wondering.

Dave.