* [PATCH net-next] net: pcs: pcs-mtk-lynxi: correctly report in-band status capabilities
@ 2025-01-02 12:41 Daniel Golle
2025-01-04 16:40 ` patchwork-bot+netdevbpf
0 siblings, 1 reply; 2+ messages in thread
From: Daniel Golle @ 2025-01-02 12:41 UTC (permalink / raw)
To: netdev, linux-mediatek, linux-arm-kernel, linux-kernel,
AngeloGioacchino Del Regno, Matthias Brugger, Paolo Abeni,
Jakub Kicinski, Eric Dumazet, David S. Miller, Russell King,
Heiner Kallweit, Andrew Lunn, Daniel Golle, Alexander Couzens
Cc: Russell King, Eric Woudstra, Frank Wunderlich, John Crispin
Neither does the LynxI PCS support QSGMII, nor is in-band-status supported
in 2500Base-X mode. Fix the pcs_inband_caps() method accordingly.
Fixes: 520d29bdda86 ("net: pcs: pcs-mtk-lynxi: implement pcs_inband_caps() method")
Signed-off-by: Daniel Golle <daniel@makrotopia.org>
---
drivers/net/pcs/pcs-mtk-lynxi.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/drivers/net/pcs/pcs-mtk-lynxi.c b/drivers/net/pcs/pcs-mtk-lynxi.c
index 7de804535229..ed91cd7a406a 100644
--- a/drivers/net/pcs/pcs-mtk-lynxi.c
+++ b/drivers/net/pcs/pcs-mtk-lynxi.c
@@ -93,11 +93,12 @@ static unsigned int mtk_pcs_lynxi_inband_caps(struct phylink_pcs *pcs,
{
switch (interface) {
case PHY_INTERFACE_MODE_1000BASEX:
- case PHY_INTERFACE_MODE_2500BASEX:
case PHY_INTERFACE_MODE_SGMII:
- case PHY_INTERFACE_MODE_QSGMII:
return LINK_INBAND_DISABLE | LINK_INBAND_ENABLE;
+ case PHY_INTERFACE_MODE_2500BASEX:
+ return LINK_INBAND_DISABLE;
+
default:
return 0;
}
--
2.47.1
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH net-next] net: pcs: pcs-mtk-lynxi: correctly report in-band status capabilities
2025-01-02 12:41 [PATCH net-next] net: pcs: pcs-mtk-lynxi: correctly report in-band status capabilities Daniel Golle
@ 2025-01-04 16:40 ` patchwork-bot+netdevbpf
0 siblings, 0 replies; 2+ messages in thread
From: patchwork-bot+netdevbpf @ 2025-01-04 16:40 UTC (permalink / raw)
To: Daniel Golle
Cc: netdev, linux-mediatek, linux-arm-kernel, linux-kernel,
angelogioacchino.delregno, matthias.bgg, pabeni, kuba, edumazet,
davem, linux, hkallweit1, andrew, lynxis, rmk+kernel, ericwouds,
frank-w, john
Hello:
This patch was applied to netdev/net-next.git (main)
by Jakub Kicinski <kuba@kernel.org>:
On Thu, 2 Jan 2025 12:41:21 +0000 you wrote:
> Neither does the LynxI PCS support QSGMII, nor is in-band-status supported
> in 2500Base-X mode. Fix the pcs_inband_caps() method accordingly.
>
> Fixes: 520d29bdda86 ("net: pcs: pcs-mtk-lynxi: implement pcs_inband_caps() method")
> Signed-off-by: Daniel Golle <daniel@makrotopia.org>
> ---
> drivers/net/pcs/pcs-mtk-lynxi.c | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
Here is the summary with links:
- [net-next] net: pcs: pcs-mtk-lynxi: correctly report in-band status capabilities
https://git.kernel.org/netdev/net-next/c/a003c38d9bbb
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2025-01-04 16:42 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-01-02 12:41 [PATCH net-next] net: pcs: pcs-mtk-lynxi: correctly report in-band status capabilities Daniel Golle
2025-01-04 16:40 ` patchwork-bot+netdevbpf
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).