Re: [PATCH v3 08/46] media: sun6i-csi: Tidy up Kconfig

From: "Jernej Škrabec" <jernej.skrabec@gmail.com>
To: linux-kernel@vger.kernel.org, linux-media@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-sunxi@lists.linux.dev,
	Paul Kocialkowski <paul.kocialkowski@bootlin.com>
Cc: Yong Deng <yong.deng@magewell.com>,
	Paul Kocialkowski <paul.kocialkowski@bootlin.com>,
	Mauro Carvalho Chehab <mchehab@kernel.org>,
	Chen-Yu Tsai <wens@csie.org>,
	Samuel Holland <samuel@sholland.org>,
	Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
	Maxime Ripard <mripard@kernel.org>,
	Thomas Petazzoni <thomas.petazzoni@bootlin.com>
Subject: Re: [PATCH v3 08/46] media: sun6i-csi: Tidy up Kconfig
Date: Tue, 15 Mar 2022 20:51:25 +0100	[thread overview]
Message-ID: <1737020.TLkxdtWsSY@kista> (raw)
In-Reply-To: <20220311143532.265091-9-paul.kocialkowski@bootlin.com>

Dne petek, 11. marec 2022 ob 15:34:54 CET je Paul Kocialkowski napisal(a):
> Update the option title and help, group related options together,
> add dependency on VIDEO_DEV since the driver uses it.
> 
> Signed-off-by: Paul Kocialkowski <paul.kocialkowski@bootlin.com>
> ---
>  drivers/media/platform/sunxi/sun6i-csi/Kconfig | 9 +++++----
>  1 file changed, 5 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/media/platform/sunxi/sun6i-csi/Kconfig b/drivers/media/
platform/sunxi/sun6i-csi/Kconfig
> index fd03e48f0c8a..a88978eba455 100644
> --- a/drivers/media/platform/sunxi/sun6i-csi/Kconfig
> +++ b/drivers/media/platform/sunxi/sun6i-csi/Kconfig
> @@ -1,12 +1,13 @@
>  # SPDX-License-Identifier: GPL-2.0-only
>  config VIDEO_SUN6I_CSI
> -	tristate "Allwinner V3s Camera Sensor Interface driver"
> -	depends on PM && VIDEO_V4L2 && COMMON_CLK  && HAS_DMA
> +	tristate "Allwinner A31 Camera Sensor Interface (CSI) Driver"
>  	depends on ARCH_SUNXI || COMPILE_TEST
> +	depends on PM && COMMON_CLK && HAS_DMA
> +	depends on VIDEO_DEV && VIDEO_V4L2
> +	select REGMAP_MMIO
>  	select MEDIA_CONTROLLER
>  	select VIDEO_V4L2_SUBDEV_API
>  	select VIDEOBUF2_DMA_CONTIG
> -	select REGMAP_MMIO
>  	select V4L2_FWNODE
>  	help
> -	   Support for the Allwinner Camera Sensor Interface Controller on 
V3s.
> +	   Support for the Allwinner A31 Camera Sensor Interface (CSI) 
controller.

While at it, it would be nice to somehow indicate that it's compatible with 
more than one SoC.

Best regards,
Jernej

> -- 
> 2.35.1
> 
> 

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel