From: "Heiko Stübner" <heiko@sntech.de>
To: linux-i2c@vger.kernel.org, John Keeping <john@metanate.com>
Cc: John Keeping <john@metanate.com>,
linux-arm-kernel@lists.infradead.org,
linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] i2c: rk3x: enable clock before getting rate
Date: Sun, 21 Nov 2021 19:00:55 +0100 [thread overview]
Message-ID: <1738891.e3IbIVKTtj@diego> (raw)
In-Reply-To: <20211004131539.1253195-1-john@metanate.com>
Am Montag, 4. Oktober 2021, 15:15:39 CET schrieb John Keeping:
> clk_get_rate() is documented as requiring the clock to be enabled.
> Ensure that the bus clock is enabled before calling clk_get_rate() in
> rk3x_i2c_probe() to satisfy this requirement.
>
> Signed-off-by: John Keeping <john@metanate.com>
Reviewed-by: Heiko Stuebner <heiko@sntech.de>
Do you maybe want to repost and include the actual i2c-maintainers
in the recipient list?
Heiko
> ---
> drivers/i2c/busses/i2c-rk3x.c | 7 +++++++
> 1 file changed, 7 insertions(+)
>
> diff --git a/drivers/i2c/busses/i2c-rk3x.c b/drivers/i2c/busses/i2c-rk3x.c
> index 819ab4ee517e..332755fab2a1 100644
> --- a/drivers/i2c/busses/i2c-rk3x.c
> +++ b/drivers/i2c/busses/i2c-rk3x.c
> @@ -1338,8 +1338,15 @@ static int rk3x_i2c_probe(struct platform_device *pdev)
> goto err_pclk;
> }
>
> + ret = clk_enable(i2c->clk);
> + if (ret < 0) {
> + dev_err(&pdev->dev, "Can't enable bus clk: %d\n", ret);
> + goto err_clk_notifier;
> + }
> +
> clk_rate = clk_get_rate(i2c->clk);
> rk3x_i2c_adapt_div(i2c, clk_rate);
> + clk_disable(i2c->clk);
>
> ret = i2c_add_adapter(&i2c->adap);
> if (ret < 0)
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-11-21 18:02 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-04 13:15 [PATCH] i2c: rk3x: enable clock before getting rate John Keeping
2021-11-21 18:00 ` Heiko Stübner [this message]
2021-11-22 7:39 ` Wolfram Sang
2021-11-29 9:40 ` Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1738891.e3IbIVKTtj@diego \
--to=heiko@sntech.de \
--cc=john@metanate.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).