From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 189B5C004D4 for ; Thu, 19 Jan 2023 10:28:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=EQan/OwpIV6GtSQ1NqtbCJmTmqVyaGOxn3uc4oc3VVY=; b=zEeNmDEhTU1r1w wBcsLwBZBtvO+NkQxEknxKGsJ6NSkxBTy0AYoGCyKF62lu/tE7f/7DoNFdP+Tf8C3fNww0FvY6Tnc ST7IklG3361ylT6TZqgG877d7JYbIebdjGUs5Ovx1CNpNsvRgRsvaEjZXmP1r3shvBUZsK57aePKT ZnWap1hxWDj8RXknsHKaObfS+rHhe3HA3ZPxQMYRjR///mle40e2A4+Uc7dDfXFtZjUfGYTmm+VaU FYBq1WT73qrJNdAxYVu6L+QkFgViXJkvvPKsQg29pDyeOYnjuro3w+TG6rkSuo26lzZJNAXtJ8618 FDRqd90+Ye68gEeOFVbg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pIS8w-004RrZ-07; Thu, 19 Jan 2023 10:27:38 +0000 Received: from ams.source.kernel.org ([2604:1380:4601:e00::1]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pIS8s-004RqK-Ic for linux-arm-kernel@lists.infradead.org; Thu, 19 Jan 2023 10:27:36 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 54398B821D4; Thu, 19 Jan 2023 10:27:32 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 52847C433D2; Thu, 19 Jan 2023 10:27:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1674124051; bh=4UpahVsIChSSGcPJAw5CzomIyJAr7tVRZVCLTnoEETs=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=MPc1ipVoU9GPG3AcMlVCzrcTcc2acm276LL0pZeuiCnQn2saW1j83SVjGoXHCM/lK BeuCJ2Ar5AY2FGmWR4pMhQDKvPycwHAOd9cIHXnascJY/ZQF5FoVxTp/Zv6pjsd0pX 4yYcFoFmQvwFVFGSj9ySR7vvbesXSXBMkNxWuZP8ej70zkJ0oEpHwn1iNiBBoUFxUQ 8d6X06efp2qv0HwvkO3+wsWg60EyMDvnYpVkuuN0oarO8MhN9kwmIlsPhWurkZIpzG hUPAFwZBkk4szSb8Hv8+JuIz85yWuUaKmx5PkLJYoOUkGqP0HUd8R/YjvPrWzcebAO c9umiJqIeufiA== Message-ID: <1739f5ba-6d73-cd2c-d088-39428fdb55a7@kernel.org> Date: Thu, 19 Jan 2023 12:27:25 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.2 Subject: Re: [PATCH net-next v3 0/2] Fix CPTS release action in am65-cpts driver Content-Language: en-US To: Siddharth Vadapalli , davem@davemloft.net, edumazet@google.com, kuba@kernel.org, linux@armlinux.org.uk, pabeni@redhat.com, leon@kernel.org Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, vigneshr@ti.com, srk@ti.com References: <20230118095439.114222-1-s-vadapalli@ti.com> From: Roger Quadros In-Reply-To: <20230118095439.114222-1-s-vadapalli@ti.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230119_022734_807409_8224D552 X-CRM114-Status: GOOD ( 15.37 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 18/01/2023 11:54, Siddharth Vadapalli wrote: > Delete unreachable code in am65_cpsw_init_cpts() function, which was > Reported-by: Leon Romanovsky > at: > https://lore.kernel.org/r/Y8aHwSnVK9+sAb24@unreal > > Remove the devm action associated with am65_cpts_release() and invoke the > function directly on the cleanup and exit paths. > > Changes from v2: > 1. Drop Reviewed-by tag from Roger Quadros. > 2. Add cleanup patch for deleting unreachable error handling code in > am65_cpsw_init_cpts(). > 3. Drop am65_cpsw_cpts_cleanup() function and directly invoke > am65_cpts_release(). > > Changes from v1: > 1. Fix the build issue when "CONFIG_TI_K3_AM65_CPTS" is not set. This > error was reported by kernel test robot at: > https://lore.kernel.org/r/202301142105.lt733Lt3-lkp@intel.com/ > 2. Collect Reviewed-by tag from Roger Quadros. > > v2: > https://lore.kernel.org/r/20230116044517.310461-1-s-vadapalli@ti.com/ > v1: > https://lore.kernel.org/r/20230113104816.132815-1-s-vadapalli@ti.com/ > > Siddharth Vadapalli (2): > net: ethernet: ti: am65-cpsw: Delete unreachable error handling code > net: ethernet: ti: am65-cpsw/cpts: Fix CPTS release action > > drivers/net/ethernet/ti/am65-cpsw-nuss.c | 7 ++----- > drivers/net/ethernet/ti/am65-cpts.c | 15 +++++---------- > drivers/net/ethernet/ti/am65-cpts.h | 5 +++++ > 3 files changed, 12 insertions(+), 15 deletions(-) > Reviewed-by: Roger Quadros _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel