public inbox for linux-arm-kernel@lists.infradead.org
 help / color / mirror / Atom feed
From: "Rafael J. Wysocki" <rjw@rjwysocki.net>
To: Sudeep Holla <sudeep.holla@arm.com>,
	Quentin Perret <quentin.perret@arm.com>
Cc: linux-pm@vger.kernel.org, viresh.kumar@linaro.org,
	linux-kernel@vger.kernel.org, qais.yousef@arm.com,
	dietmar.eggemann@arm.com, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] cpufreq: scmi: Fix frequency invariance in slow path
Date: Fri, 11 Jan 2019 11:41:45 +0100	[thread overview]
Message-ID: <1742153.atePz3IjTa@aspire.rjw.lan> (raw)
In-Reply-To: <20190109105945.GA18034@e107155-lin>

On Wednesday, January 9, 2019 11:59:45 AM CET Sudeep Holla wrote:
> On Wed, Jan 09, 2019 at 10:42:36AM +0000, Quentin Perret wrote:
> > The scmi-cpufreq driver calls the arch_set_freq_scale() callback on
> > frequency changes to provide scale-invariant load-tracking signals to
> > the scheduler. However, in the slow path, it does so while specifying
> > the current and max frequencies in different units, hence resulting in a
> > broken freq_scale factor.
> > 
> > Fix this by passing all frequencies in KHz, as stored in the CPUFreq
> > frequency table.
> > 
> > Fixes: 99d6bdf33877 ("cpufreq: add support for CPU DVFS based on SCMI
> > message protocol")
> 
> Good find.
> 
> Acked-by: Sudeep Holla <sudeep.holla@arm.com>

Applied, thanks!


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

      reply	other threads:[~2019-01-11 10:42 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-01-09 10:42 [PATCH] cpufreq: scmi: Fix frequency invariance in slow path Quentin Perret
2019-01-09 10:45 ` Viresh Kumar
2019-01-09 10:56   ` Rafael J. Wysocki
2019-01-09 10:59     ` Quentin Perret
2019-01-09 11:03       ` Rafael J. Wysocki
2019-01-09 11:07         ` Quentin Perret
2019-01-09 10:59     ` Viresh Kumar
2019-01-09 10:59 ` Sudeep Holla
2019-01-11 10:41   ` Rafael J. Wysocki [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1742153.atePz3IjTa@aspire.rjw.lan \
    --to=rjw@rjwysocki.net \
    --cc=dietmar.eggemann@arm.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=qais.yousef@arm.com \
    --cc=quentin.perret@arm.com \
    --cc=sudeep.holla@arm.com \
    --cc=viresh.kumar@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox