From: "Jernej Škrabec" <jernej.skrabec@siol.net>
To: Maxime Ripard <mripard@kernel.org>, Chen-Yu Tsai <wens@csie.org>
Cc: David Airlie <airlied@linux.ie>,
linux-kernel <linux-kernel@vger.kernel.org>,
dri-devel <dri-devel@lists.freedesktop.org>,
Daniel Vetter <daniel@ffwll.ch>,
linux-arm-kernel <linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH] drm/sun4i: hdmi ddc clk: Fix size of m divider
Date: Mon, 13 Apr 2020 18:09:08 +0200 [thread overview]
Message-ID: <1742537.tdWV9SEqCh@jernej-laptop> (raw)
In-Reply-To: <CAGb2v66LxhqTBeA_Br=kUrTq83hocEcAzYYC6nXpASvkkjn+1g@mail.gmail.com>
Dne ponedeljek, 13. april 2020 ob 16:12:39 CEST je Chen-Yu Tsai napisal(a):
> On Mon, Apr 13, 2020 at 6:11 PM Chen-Yu Tsai <wens@csie.org> wrote:
> > On Mon, Apr 13, 2020 at 5:55 PM Jernej Skrabec <jernej.skrabec@siol.net>
wrote:
> > > m divider in DDC clock register is 4 bits wide. Fix that.
> > >
> > > Fixes: 9c5681011a0c ("drm/sun4i: Add HDMI support")
> > > Signed-off-by: Jernej Skrabec <jernej.skrabec@siol.net>
> >
> > Reviewed-by: Chen-Yu Tsai <wens@csie.org>
>
> Cc stable?
I don't think it's necessary:
1. It doesn't change much (anything?) for me when reading EDID. I don't think
it's super important to have precise DDC clock in order to properly read EDID.
2. No matter if it has "Cc stable" tag or not, it will be eventually picked
for stable due to fixes tag.
This was only small observation when I was researching EDID readout issue on
A20 board, but sadly, I wasn't able to figure out why reading it sometimes
fails. I noticed similar issue on SoCs with DE2 (most prominently on OrangePi
PC2 - H5), but there was easy workaround - I just disabled video driver in U-
Boot. However, if A20 display driver gets disabled in U-Boot, it totally
breaks video output on my TV when Linux boots (no output). I guess there is
more fundamental problem with clocks than just field size. I think we should
add more constraints in clock driver, like preset some clock parents and not
allow to change parents when setting rate, but carefully, so simplefb doesn't
break. Such constraints should also solve problems with dual head setups.
Best regards,
Jernej
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-04-13 16:09 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-13 9:54 [PATCH] drm/sun4i: hdmi ddc clk: Fix size of m divider Jernej Skrabec
2020-04-13 10:11 ` Chen-Yu Tsai
2020-04-13 14:12 ` Chen-Yu Tsai
2020-04-13 16:09 ` Jernej Škrabec [this message]
2020-04-15 10:42 ` Maxime Ripard
2020-04-15 17:52 ` Jernej Škrabec
2020-04-22 9:23 ` Maxime Ripard
2020-06-04 5:19 ` Chen-Yu Tsai
2020-06-10 7:12 ` Maxime Ripard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1742537.tdWV9SEqCh@jernej-laptop \
--to=jernej.skrabec@siol.net \
--cc=airlied@linux.ie \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mripard@kernel.org \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox