From: patchwork-bot+netdevbpf@kernel.org
To: Kees Cook <kees@kernel.org>
Cc: kuba@kernel.org, andrew+netdev@lunn.ch, davem@davemloft.net,
edumazet@google.com, pabeni@redhat.com, claudiu.manoil@nxp.com,
vladimir.oltean@nxp.com, wei.fang@nxp.com, xiaoning.wang@nxp.com,
jeroendb@google.com, hramamurthy@google.com, idosch@nvidia.com,
petrm@nvidia.com, mcoquelin.stm32@gmail.com,
alexandre.torgue@foss.st.com, horms@kernel.org,
geoff@infradead.org, wsa+renesas@sang-engineering.com,
aleksander.lobakin@intel.com, pkaligineedi@google.com,
willemb@google.com, joshwash@google.com, 0x1207@gmail.com,
rmk+kernel@armlinux.org.uk, jszhang@kernel.org, petr@tesarici.cz,
netdev@vger.kernel.org, imx@lists.linux.dev,
linux-stm32@st-md-mailman.stormreply.com,
linux-arm-kernel@lists.infradead.org, richardcochran@gmail.com,
jacob.e.keller@intel.com, shannon.nelson@amd.com,
ziweixiao@google.com, shailend@google.com,
yong.liang.choong@linux.intel.com, ahalaney@redhat.com,
kory.maincent@bootlin.com, linux-kernel@vger.kernel.org,
linux-hardening@vger.kernel.org
Subject: Re: [PATCH] net: ethtool: Adjust exactly ETH_GSTRING_LEN-long stats to use memcpy
Date: Fri, 18 Apr 2025 02:10:43 +0000 [thread overview]
Message-ID: <174494224374.79616.15601499519996041916.git-patchwork-notify@kernel.org> (raw)
In-Reply-To: <20250416010210.work.904-kees@kernel.org>
Hello:
This patch was applied to netdev/net-next.git (main)
by Jakub Kicinski <kuba@kernel.org>:
On Tue, 15 Apr 2025 18:02:15 -0700 you wrote:
> Many drivers populate the stats buffer using C-String based APIs (e.g.
> ethtool_sprintf() and ethtool_puts()), usually when building up the
> list of stats individually (i.e. with a for() loop). This, however,
> requires that the source strings be populated in such a way as to have
> a terminating NUL byte in the source.
>
> Other drivers populate the stats buffer directly using one big memcpy()
> of an entire array of strings. No NUL termination is needed here, as the
> bytes are being directly passed through. Yet others will build up the
> stats buffer individually, but also use memcpy(). This, too, does not
> need NUL termination of the source strings.
>
> [...]
Here is the summary with links:
- net: ethtool: Adjust exactly ETH_GSTRING_LEN-long stats to use memcpy
https://git.kernel.org/netdev/net-next/c/151e13ece86d
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
prev parent reply other threads:[~2025-04-18 2:15 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-16 1:02 [PATCH] net: ethtool: Adjust exactly ETH_GSTRING_LEN-long stats to use memcpy Kees Cook
2025-04-16 9:03 ` Kory Maincent
2025-04-16 17:48 ` Kees Cook
2025-04-16 18:57 ` Keller, Jacob E
2025-04-16 9:09 ` Petr Machata
2025-04-17 3:15 ` Harshitha Ramamurthy
2025-04-18 2:10 ` patchwork-bot+netdevbpf [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=174494224374.79616.15601499519996041916.git-patchwork-notify@kernel.org \
--to=patchwork-bot+netdevbpf@kernel.org \
--cc=0x1207@gmail.com \
--cc=ahalaney@redhat.com \
--cc=aleksander.lobakin@intel.com \
--cc=alexandre.torgue@foss.st.com \
--cc=andrew+netdev@lunn.ch \
--cc=claudiu.manoil@nxp.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=geoff@infradead.org \
--cc=horms@kernel.org \
--cc=hramamurthy@google.com \
--cc=idosch@nvidia.com \
--cc=imx@lists.linux.dev \
--cc=jacob.e.keller@intel.com \
--cc=jeroendb@google.com \
--cc=joshwash@google.com \
--cc=jszhang@kernel.org \
--cc=kees@kernel.org \
--cc=kory.maincent@bootlin.com \
--cc=kuba@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-hardening@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=mcoquelin.stm32@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=petr@tesarici.cz \
--cc=petrm@nvidia.com \
--cc=pkaligineedi@google.com \
--cc=richardcochran@gmail.com \
--cc=rmk+kernel@armlinux.org.uk \
--cc=shailend@google.com \
--cc=shannon.nelson@amd.com \
--cc=vladimir.oltean@nxp.com \
--cc=wei.fang@nxp.com \
--cc=willemb@google.com \
--cc=wsa+renesas@sang-engineering.com \
--cc=xiaoning.wang@nxp.com \
--cc=yong.liang.choong@linux.intel.com \
--cc=ziweixiao@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).