[PATCH net] net: dsa: mt7530: sync driver-specific behavior of MT7531 variants

[PATCH net] net: dsa: mt7530: sync driver-specific behavior of MT7531 variants

[Daniel Golle]

MT7531 standalone and MMIO variants found in MT7988 and EN7581 share
most basic properties. Despite that, assisted_learning_on_cpu_port and
mtu_enforcement_ingress were only applied for MT7531 but not for MT7988
or EN7581, causing the expected issues on MMIO devices.

Apply both settings equally also for MT7988 and EN7581 by moving both
assignments form mt7531_setup() to mt7531_setup_common().

This fixes unwanted flooding of packets due to unknown unicast
during DA lookup, as well as issues with heterogenous MTU settings.

Fixes: 7f54cc9772ce ("net: dsa: mt7530: split-off common parts from mt7531_setup")
Signed-off-by: Daniel Golle <daniel@makrotopia.org>
---
See also https://git01.mediatek.com/plugins/gitiles/openwrt/feeds/mtk-openwrt-feeds/+/b4204fb062d60ac57791c90a11d05cf75269dcbd

 drivers/net/dsa/mt7530.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/net/dsa/mt7530.c b/drivers/net/dsa/mt7530.c
index d70399bce5b9..c5d6628d7980 100644
--- a/drivers/net/dsa/mt7530.c
+++ b/drivers/net/dsa/mt7530.c
@@ -2419,6 +2419,9 @@ mt7531_setup_common(struct dsa_switch *ds)
 	struct mt7530_priv *priv = ds->priv;
 	int ret, i;
 
+	ds->assisted_learning_on_cpu_port = true;
+	ds->mtu_enforcement_ingress = true;
+
 	mt753x_trap_frames(priv);
 
 	/* Enable and reset MIB counters */
@@ -2571,9 +2574,6 @@ mt7531_setup(struct dsa_switch *ds)
 	if (ret)
 		return ret;
 
-	ds->assisted_learning_on_cpu_port = true;
-	ds->mtu_enforcement_ingress = true;
-
 	return 0;
 }
 
-- 
2.49.0

Re: [PATCH net] net: dsa: mt7530: sync driver-specific behavior of MT7531 variants

[Chester A. Unal]

On 22 April 2025 06:10:20 GMT+03:00, Daniel Golle <daniel@makrotopia.org> wrote:
>MT7531 standalone and MMIO variants found in MT7988 and EN7581 share
>most basic properties. Despite that, assisted_learning_on_cpu_port and
>mtu_enforcement_ingress were only applied for MT7531 but not for MT7988
>or EN7581, causing the expected issues on MMIO devices.
>
>Apply both settings equally also for MT7988 and EN7581 by moving both
>assignments form mt7531_setup() to mt7531_setup_common().
>
>This fixes unwanted flooding of packets due to unknown unicast
>during DA lookup, as well as issues with heterogenous MTU settings.
>
>Fixes: 7f54cc9772ce ("net: dsa: mt7530: split-off common parts from mt7531_setup")
>Signed-off-by: Daniel Golle <daniel@makrotopia.org>
>---
>See also https://git01.mediatek.com/plugins/gitiles/openwrt/feeds/mtk-openwrt-feeds/+/b4204fb062d60ac57791c90a11d05cf75269dcbd

Reviewed-by: Chester A. Unal <chester.a.unal@arinc9.com>

Chester A.

Re: [PATCH net] net: dsa: mt7530: sync driver-specific behavior of MT7531 variants

[patchwork-bot+netdevbpf]

Hello:

This patch was applied to netdev/net.git (main)
by Jakub Kicinski <kuba@kernel.org>:

On Tue, 22 Apr 2025 04:10:20 +0100 you wrote:
> MT7531 standalone and MMIO variants found in MT7988 and EN7581 share
> most basic properties. Despite that, assisted_learning_on_cpu_port and
> mtu_enforcement_ingress were only applied for MT7531 but not for MT7988
> or EN7581, causing the expected issues on MMIO devices.
> 
> Apply both settings equally also for MT7988 and EN7581 by moving both
> assignments form mt7531_setup() to mt7531_setup_common().
> 
> [...]

Here is the summary with links:
  - [net] net: dsa: mt7530: sync driver-specific behavior of MT7531 variants
    https://git.kernel.org/netdev/net/c/497041d76301

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html

Re: [PATCH net] net: dsa: mt7530: sync driver-specific behavior of MT7531 variants

[Vladimir Oltean]

On Tue, Apr 22, 2025 at 04:10:20AM +0100, Daniel Golle wrote:
> MT7531 standalone and MMIO variants found in MT7988 and EN7581 share
> most basic properties. Despite that, assisted_learning_on_cpu_port and
> mtu_enforcement_ingress were only applied for MT7531 but not for MT7988
> or EN7581, causing the expected issues on MMIO devices.
> 
> Apply both settings equally also for MT7988 and EN7581 by moving both
> assignments form mt7531_setup() to mt7531_setup_common().
> 
> This fixes unwanted flooding of packets due to unknown unicast
> during DA lookup, as well as issues with heterogenous MTU settings.
> 
> Fixes: 7f54cc9772ce ("net: dsa: mt7530: split-off common parts from mt7531_setup")
> Signed-off-by: Daniel Golle <daniel@makrotopia.org>
> ---

Reviewed-by: Vladimir Oltean <olteanv@gmail.com>