Re: [PATCH 1/6] dt-bindings: mfd: add bindings for QIXIS CPLD

Krzysztof Kozlowski
2025-05-07T04:58:53Z

On 06/05/2025 16:16, Ioana Ciornei wrote:
> On Tue, May 06, 2025 at 04:05:46PM +0200, Krzysztof Kozlowski wrote:
>> On 06/05/2025 15:57, Ioana Ciornei wrote:
>>> On Fri, May 02, 2025 at 09:01:59AM +0200, Krzysztof Kozlowski wrote:
>>>> On Wed, Apr 30, 2025 at 06:36:29PM GMT, Ioana Ciornei wrote:
>>>>> This adds device tree bindings for the board management controller -
>>>>> QIXIS CPLD - found on some Layerscape based boards such as LX2160A-RDB,
>>>>> LX2160AQDS, LS1028AQDS etc.
>>>>>
>>>>> Signed-off-by: Ioana Ciornei <ioana.ciornei@nxp.com>
>>>>> ---
>>>>> .../bindings/mfd/fsl,qixis-i2c.yaml | 65 +++++++++++++++++++
>>>>> 1 file changed, 65 insertions(+)
>>>>> create mode 100644 Documentation/devicetree/bindings/mfd/fsl,qixis-i2c.yaml
>>>>>
>>>>> diff --git a/Documentation/devicetree/bindings/mfd/fsl,qixis-i2c.yaml b/Documentation/devicetree/bindings/mfd/fsl,qixis-i2c.yaml
>>>>> new file mode 100644
>>>>> index 000000000000..562878050916
>>>>> --- /dev/null
>>>>> +++ b/Documentation/devicetree/bindings/mfd/fsl,qixis-i2c.yaml
>>>>
>>>> Filename matching compatible.
>>>
>>> How to choose one if there are multiple compatible strings?
>>
>> The fallback or the oldest or the lowest number or whichever you prefer
>> as a base.
>>
>>>
>>>>
>>>>> @@ -0,0 +1,65 @@
>>>>> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
>>>>> +%YAML 1.2
>>>>> +---
>>>>> +$id: http://devicetree.org/schemas/mfd/fsl,qixis-i2c.yaml
>>>>> +$schema: http://devicetree.org/meta-schemas/core.yaml
>>>>> +
>>>>> +title: NXP's QIXIS CPLD board management controller
>>>>> +
>>>>> +maintainers:
>>>>> + - Ioana Ciornei <ioana.ciornei@nxp.com>
>>>>> +
>>>>> +description: |
>>>>> + The board management controller found on some Layerscape boards contains
>>>>> + different IP blocks like GPIO controllers, interrupt controllers, reg-muxes
>>>>> + etc.
>>>>> +
>>>>> +properties:
>>>>> + compatible:
>>>>> + enum:
>>>>> + - fsl,lx2160a-qds-qixis-i2c
>>>>> + - fsl,lx2162a-qds-qixis-i2c
>>>>> + - fsl,ls1028a-qds-qixis-i2c
>>>>
>>>> Keep alphabetical order.
>>>>
>>>> What is actual device name? I2C? Is this an I2C controller or device?
>>
>> I assume you will then drop the redundant part.
>
> Ok, I will drop the i2c part. Are you ok with the below compatible
> strings?
>
> - fsl,lx2160a-qds-qixis-cpld
> - fsl,lx2162a-qds-qixis-cpld
> - fsl,ls1028a-qds-qixis-cpld

Not really, because you keep ignoring comments. What is the device name?
Can qixis be anything else than i2c or cpld? Use that name for the
compatible.

Best regards,
Krzysztof