From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5D3AECA9EAF for ; Mon, 21 Oct 2019 14:40:19 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 2B9F72053B for ; Mon, 21 Oct 2019 14:40:19 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="hIKCImZy" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2B9F72053B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=siol.net Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=DtikfW0j7Rd12pmP215G3rfzu/qO2BYn59eqcoFAGtc=; b=hIKCImZymX3S6m BCdAUYixZOdBDVtM2G1CFYpxRtvt5AA4bW2RBXwOW1kAcbjaIMzo/t0aJnvlXWQsgeBEOhRbwuFwF z3PKjWO/T3KkW9IMvRbdc8vFaMacprdKPpdmJH9xajm2IZb+j16uIV8ewvUkoW7RwITFoCgsUjCBi hoommFW9bKtTJfKSRbzhT2cDVLwTy00xKGKNlJgKBBX0D4v4q0tz9uRvikdzHYXLyUlcK1h1Vf9l8 USa4tClvZYcriFgos8CjEp34ky1vp6JXmEAz45mnCa6dnpp1F4xgyaLgitVJmDY4mH9Z4yHCaznSE oRmv0TskzkxAiaOUbQ5w==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1iMYqy-0006oT-BB; Mon, 21 Oct 2019 14:40:12 +0000 Received: from mailoutvs16.siol.net ([185.57.226.207] helo=mail.siol.net) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1iMYpj-0005Gc-HW for linux-arm-kernel@lists.infradead.org; Mon, 21 Oct 2019 14:38:58 +0000 Received: from localhost (localhost [127.0.0.1]) by mail.siol.net (Zimbra) with ESMTP id 8500F5225B6; Mon, 21 Oct 2019 16:38:43 +0200 (CEST) X-Virus-Scanned: amavisd-new at psrvmta12.zcs-production.pri Received: from mail.siol.net ([127.0.0.1]) by localhost (psrvmta12.zcs-production.pri [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id vka4LJ2PZxFz; Mon, 21 Oct 2019 16:38:43 +0200 (CEST) Received: from mail.siol.net (localhost [127.0.0.1]) by mail.siol.net (Zimbra) with ESMTPS id F02C85225B4; Mon, 21 Oct 2019 16:38:42 +0200 (CEST) Received: from jernej-laptop.localnet (cpe-86-58-59-25.static.triera.net [86.58.59.25]) (Authenticated sender: jernej.skrabec@siol.net) by mail.siol.net (Zimbra) with ESMTPA id 367585225B6; Mon, 21 Oct 2019 16:38:41 +0200 (CEST) From: Jernej =?utf-8?B?xaBrcmFiZWM=?= To: Hans Verkuil Subject: Re: [PATCH v4 0/6] media: Introduce Allwinner H3 deinterlace driver Date: Mon, 21 Oct 2019 16:38:40 +0200 Message-ID: <17463716.B1tr9FcWgj@jernej-laptop> In-Reply-To: <8fbb323d-cd36-73cb-2df8-21e2819fa5af@xs4all.nl> References: <20191017183738.68069-1-jernej.skrabec@siol.net> <8fbb323d-cd36-73cb-2df8-21e2819fa5af@xs4all.nl> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20191021_073855_817917_718DAB09 X-CRM114-Status: GOOD ( 21.74 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: mark.rutland@arm.com, devicetree@vger.kernel.org, linux-sunxi@googlegroups.com, linux-kernel@vger.kernel.org, mripard@kernel.org, wens@csie.org, robh+dt@kernel.org, mchehab@kernel.org, linux-arm-kernel@lists.infradead.org, linux-media@vger.kernel.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Dne ponedeljek, 21. oktober 2019 ob 13:16:24 CEST je Hans Verkuil napisal(a): > Hi Jernej, > > I found something odd in the compliance output: > > On 10/17/19 8:37 PM, Jernej Skrabec wrote: > > Starting with H3, Allwinner began to include standalone deinterlace > > core in multimedia oriented SoCs. This patch series introduces support > > for it. Note that new SoCs, like H6, have radically different (updated) > > deinterlace core, which will need a new driver. > > > > v4l2-compliance report: > > v4l2-compliance SHA: dece02f862f38d8f866230ca9f1015cb93ddfac4, 32 bits > > > > Compliance test for sun8i-di device /dev/video0: > > > > Driver Info: > > Driver name : sun8i-di > > Card type : sun8i-di > > Bus info : platform:sun8i-di > > Driver version : 5.3.0 > > Capabilities : 0x84208000 > > > > Video Memory-to-Memory > > Streaming > > Extended Pix Format > > Device Capabilities > > > > Device Caps : 0x04208000 > > > > Video Memory-to-Memory > > Streaming > > Extended Pix Format > > > > Required ioctls: > > test VIDIOC_QUERYCAP: OK > > > > Allow for multiple opens: > > test second /dev/video0 open: OK > > test VIDIOC_QUERYCAP: OK > > test VIDIOC_G/S_PRIORITY: OK > > test for unlimited opens: OK > > > > Debug ioctls: > > test VIDIOC_DBG_G/S_REGISTER: OK (Not Supported) > > test VIDIOC_LOG_STATUS: OK (Not Supported) > > > > Input ioctls: > > test VIDIOC_G/S_TUNER/ENUM_FREQ_BANDS: OK (Not Supported) > > test VIDIOC_G/S_FREQUENCY: OK (Not Supported) > > test VIDIOC_S_HW_FREQ_SEEK: OK (Not Supported) > > test VIDIOC_ENUMAUDIO: OK (Not Supported) > > test VIDIOC_G/S/ENUMINPUT: OK (Not Supported) > > test VIDIOC_G/S_AUDIO: OK (Not Supported) > > Inputs: 0 Audio Inputs: 0 Tuners: 0 > > > > Output ioctls: > > test VIDIOC_G/S_MODULATOR: OK (Not Supported) > > test VIDIOC_G/S_FREQUENCY: OK (Not Supported) > > test VIDIOC_ENUMAUDOUT: OK (Not Supported) > > test VIDIOC_G/S/ENUMOUTPUT: OK (Not Supported) > > test VIDIOC_G/S_AUDOUT: OK (Not Supported) > > Outputs: 0 Audio Outputs: 0 Modulators: 0 > > > > Input/Output configuration ioctls: > > test VIDIOC_ENUM/G/S/QUERY_STD: OK (Not Supported) > > test VIDIOC_ENUM/G/S/QUERY_DV_TIMINGS: OK (Not Supported) > > test VIDIOC_DV_TIMINGS_CAP: OK (Not Supported) > > test VIDIOC_G/S_EDID: OK (Not Supported) > > > > Control ioctls: > > test VIDIOC_QUERY_EXT_CTRL/QUERYMENU: OK (Not Supported) > > test VIDIOC_QUERYCTRL: OK (Not Supported) > > test VIDIOC_G/S_CTRL: OK (Not Supported) > > test VIDIOC_G/S/TRY_EXT_CTRLS: OK (Not Supported) > > test VIDIOC_(UN)SUBSCRIBE_EVENT/DQEVENT: OK (Not Supported) > > test VIDIOC_G/S_JPEGCOMP: OK (Not Supported) > > Standard Controls: 0 Private Controls: 0 > > > > Format ioctls: > > test VIDIOC_ENUM_FMT/FRAMESIZES/FRAMEINTERVALS: OK > > test VIDIOC_G/S_PARM: OK (Not Supported) > > test VIDIOC_G_FBUF: OK (Not Supported) > > test VIDIOC_G_FMT: OK > > test VIDIOC_TRY_FMT: OK > > test VIDIOC_S_FMT: OK > > test VIDIOC_G_SLICED_VBI_CAP: OK (Not Supported) > > test Cropping: OK (Not Supported) > > test Composing: OK (Not Supported) > > test Scaling: OK > > This claims that the driver supports scaling, but I don't think that is > right. HW does indeed support scaling so there is no bug. I tested that and result looks fine. Best regards, Jernej > > More likely the deinterlacing part is what confuses the compliance test. > > Can you look in v4l2-test-formats.cpp, function testBasicScaling() where it > sets node->can_scale to true? And see if this is due to a driver bug, or due > to a bug in the test? > > Regards, > > Hans > > > Codec ioctls: > > test VIDIOC_(TRY_)ENCODER_CMD: OK (Not Supported) > > test VIDIOC_G_ENC_INDEX: OK (Not Supported) > > test VIDIOC_(TRY_)DECODER_CMD: OK (Not Supported) > > > > Buffer ioctls: > > test VIDIOC_REQBUFS/CREATE_BUFS/QUERYBUF: OK > > test VIDIOC_EXPBUF: OK > > test Requests: OK (Not Supported) > > > > Total for sun8i-di device /dev/video0: 44, Succeeded: 44, Failed: 0, > > Warnings: 0 > > > > Please take a look. > > > > Best regards, > > Jernej > > > > Changes from v3: > > - added Maxime's a-b tag > > - moved and fixed Kconfig entry > > - put clk_set_rate_exclusive() and it's counterpart in PM callbacks > > > > Changes from v2: > > - added acked-by and review-by tags > > - fixed schema path in H3 deinterlace binding > > - moved busy check after format args check > > > > Changes from v1: > > - updated Maxime's e-mail in DT binding > > - removed "items" for single item in DT binding > > - implemented power management > > - replaced regmap with direct io access > > - set exclusive clock rate > > - renamed DEINTERLACE_FRM_CTRL_COEF_CTRL to > > DEINTERLACE_FRM_CTRL_COEF_ACCESS> > > Jernej Skrabec (6): > > dt-bindings: bus: sunxi: Add H3 MBUS compatible > > clk: sunxi-ng: h3: Export MBUS clock > > ARM: dts: sunxi: h3/h5: Add MBUS controller node > > dt-bindings: media: Add Allwinner H3 Deinterlace binding > > media: sun4i: Add H3 deinterlace driver > > dts: arm: sun8i: h3: Enable deinterlace unit > > > > .../bindings/arm/sunxi/sunxi-mbus.txt | 1 + > > .../media/allwinner,sun8i-h3-deinterlace.yaml | 75 ++ > > MAINTAINERS | 7 + > > arch/arm/boot/dts/sun8i-h3.dtsi | 13 + > > arch/arm/boot/dts/sunxi-h3-h5.dtsi | 9 + > > drivers/clk/sunxi-ng/ccu-sun8i-h3.h | 4 - > > drivers/media/platform/Kconfig | 12 + > > drivers/media/platform/sunxi/Makefile | 1 + > > .../media/platform/sunxi/sun8i-di/Makefile | 2 + > > .../media/platform/sunxi/sun8i-di/sun8i-di.c | 1028 +++++++++++++++++ > > .../media/platform/sunxi/sun8i-di/sun8i-di.h | 237 ++++ > > include/dt-bindings/clock/sun8i-h3-ccu.h | 2 +- > > 12 files changed, 1386 insertions(+), 5 deletions(-) > > create mode 100644 > > Documentation/devicetree/bindings/media/allwinner,sun8i-h3-deinterlace.y > > aml create mode 100644 drivers/media/platform/sunxi/sun8i-di/Makefile > > create mode 100644 drivers/media/platform/sunxi/sun8i-di/sun8i-di.c > > create mode 100644 drivers/media/platform/sunxi/sun8i-di/sun8i-di.h _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel