From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 76A61C43334 for ; Wed, 6 Jul 2022 08:58:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:Message-ID:References:In-Reply-To:Subject:To:From: Date:MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=gSOEaEg1+XD1Ue86Dv3qC7iqYS87VO9dGOs8IvFIiJ8=; b=u63Hl3zW+YasdeRBs9iUBH7nqh WelENal/NCnjLiv9JXWK+9uGP8vEn0YG56CTP1l/hFezkTk2l0lHJ34Vk1CkbOxHk6jZqBaEEKaV5 v+MBLBF6ubAaOBEG0jFmgkzUteJ3ldHyCcMDxojdlPUlbDkaS20b0qMSEo0uLFvOYCtnxVb7hpmTM sNk5IYTioRTYRWtssL6s2vq9ClqPZovN5KOd0HSiX8BiWaGsMYLLzVdckwRD4lqwqcrpUrC5cvhxJ TAYcZ+Oo3n3Gj6UbbMbi/fjs2xkMCeBw64T4+CrkNT1ZxFePKOCXPuOh9FzLUFUAglNnoJDrO5LQ0 IqrYmADQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1o90qu-007YRz-82; Wed, 06 Jul 2022 08:57:44 +0000 Received: from ssl.serverraum.org ([176.9.125.105]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1o90qq-007YOD-JB for linux-arm-kernel@lists.infradead.org; Wed, 06 Jul 2022 08:57:42 +0000 Received: from ssl.serverraum.org (web.serverraum.org [172.16.0.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ssl.serverraum.org (Postfix) with ESMTPSA id DE2C722236; Wed, 6 Jul 2022 10:57:33 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=walle.cc; s=mail2016061301; t=1657097854; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=3M+/1GThJ5TiT3Lr6PZgjiW2H7Zb8HKFfY7StVR7M0A=; b=mZVIG7QyY0FcofTloSBowi+7bLc0M/RYL5S/pZTVd+QajZohi5mObALZVSqjYNZ4VJotCb 5izwcgtr8EBhOdhuJ715F1KV7Yca7czm+zvz/IgVVf+2jeqj73RkDtvmylC0ULJYubBhc+ xwLXaJSrDVBNdxJe49nEW3llIb38jts= MIME-Version: 1.0 Date: Wed, 06 Jul 2022 10:57:33 +0200 From: Michael Walle To: Claudiu.Beznea@microchip.com Subject: Re: [PATCH 2/2] ARM: dts: kswitch-d10: enable the USB device port In-Reply-To: <32a2193f-aea1-6237-a993-d0ba89cce431@microchip.com> References: <20220705130637.1386120-1-michael@walle.cc> <20220705130637.1386120-2-michael@walle.cc> <32a2193f-aea1-6237-a993-d0ba89cce431@microchip.com> User-Agent: Roundcube Webmail/1.4.13 Message-ID: <1747f5d89ca65a9e54d95e7dd77c4709@walle.cc> X-Sender: michael@walle.cc X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220706_015740_839792_D5793548 X-CRM114-Status: GOOD ( 12.52 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, alexandre.belloni@bootlin.com, linux-kernel@vger.kernel.org, robh+dt@kernel.org, Cristian.Birsan@microchip.com, krzysztof.kozlowski+dt@linaro.org, linux-arm-kernel@lists.infradead.org Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Claudiu, Am 2022-07-06 10:41, schrieb Claudiu.Beznea@microchip.com: > On 05.07.2022 16:06, Michael Walle wrote: >> EXTERNAL EMAIL: Do not click links or open attachments unless you know >> the content is safe >> >> Now that there is driver support for the USB device, enable it. >> >> Signed-off-by: Michael Walle >> --- >> arch/arm/boot/dts/lan966x-kontron-kswitch-d10-mmt.dtsi | 5 +++++ >> 1 file changed, 5 insertions(+) >> >> diff --git a/arch/arm/boot/dts/lan966x-kontron-kswitch-d10-mmt.dtsi >> b/arch/arm/boot/dts/lan966x-kontron-kswitch-d10-mmt.dtsi >> index 5a6c5f7c371a..d0d26e136c38 100644 >> --- a/arch/arm/boot/dts/lan966x-kontron-kswitch-d10-mmt.dtsi >> +++ b/arch/arm/boot/dts/lan966x-kontron-kswitch-d10-mmt.dtsi >> @@ -200,6 +200,11 @@ &switch { >> status = "okay"; >> }; >> >> +&udc { >> + atmel,vbus-gpio = <&gpio 66 GPIO_ACTIVE_HIGH>; > > Can you also add pinctrl to avoid issues described in: Do I need a pinctrl node even if I just use it as a gpio? Isn't that handled automatically by the .gpio_request_enable op? -michael _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel