From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 401ABC43334 for ; Thu, 21 Jul 2022 07:12:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=EIl6uEPhuoik3W40Lh2SGikbzMJiEBObQGxcK/h1CjQ=; b=pIyyE6S1Ir+wRn C+cn/QJedMpNZt/YmXmAiOg+HtyZ6AXhzEB3rhISvDWBWWT6cjf6qW08v9QUSAXADrznooHit71a7 xwELjhXccrC465WhbfBZmJhTCjxt7is84T186W54b+vy4tquhSciR+DGabv6rkvdo0w3K6+Tv3Z0J oTf5KnDRuEMmORYl/j87wppv11Q8EB7weq3UGEdLe+GWmAKVv3ahjVgP5S2u+VaXf9eCQXMGH0uz3 NZSZvtd9gsXao9C5UHrx55s99RtpzAW6Jb/3lyfohITc0NMqrOynoO51NDSNp8/OjUngeODqIt8eu ReY3PSnmxh9V4I1J1G7g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oEQLV-001Yla-BL; Thu, 21 Jul 2022 07:11:41 +0000 Received: from mail-lj1-x234.google.com ([2a00:1450:4864:20::234]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oEQLS-001YhE-AI for linux-arm-kernel@lists.infradead.org; Thu, 21 Jul 2022 07:11:39 +0000 Received: by mail-lj1-x234.google.com with SMTP id a13so589678ljr.11 for ; Thu, 21 Jul 2022 00:11:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=VBDe4gorRUprlTmBClJI/DlecJjKNCX0yBbr1Si/Kq4=; b=UY8lpCxmvbtL/toGtsqltQnAwxXPAPj/BCPbeGrIolwMwllrvM9dWaWjlPyDIKSFQR N8A4f2HAiYO7ETqOVF6xYsfX8YcjEL2Ts5VkzkYYcT6bbgiSF/5xTTJcb48nsn1wYTtC 3tT1PfchNwMIwVobbX17i2WWsNDAe+okLqFBmvAM5WT1vZMy5siVrVW/I02HtMI4zaFd SpeZPF9BpsR1vPBEwDoJVjQleSxqTT+xjGj113pcLEyxUfRFq4xFnS0bm/GboRE10dI0 I/x5/rrcTMDs/IT7G0+IUi7cSCbkXZR6BiIfInjMFX/BGD8oKFmWlHMGNLCL+u5EKu+c SRVQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=VBDe4gorRUprlTmBClJI/DlecJjKNCX0yBbr1Si/Kq4=; b=czOfNznIbe7QJAFkx060sQbLz7gGbxOCgzMrEyaJOPOGYfP3Sz1YqqEaHJfWB+gIdY 1v07c6N+H5z2S7FYP5lCAzZg6IXiVUOjLkI07at9XPWyAOrWkNU7HxzOBACD1BmYG8LS vaZIaJfUFe4nmI38W3JkBCQdyAyVURnCs+LzduzdywPMSPOc2bwdl0eI34IXFWDy0A/Z 0H8F00ljEK3QL/mr8+xS5B2Ly0vPoZv/5NSRCKvJQlXjOlSpJqpJ5h78L1bWntH68bJx UukFp6k1GyVJd6sLY5Fcf1YCITVxKU7x/O20NsSUi6tAHZFplbGfOfAUbo/PtPvfdsZ4 McJQ== X-Gm-Message-State: AJIora92wMYUxTip6RfuOf2c8rpNDgyAHVR4GvmrT8fuWr07sGhM98sX lXLMJjODkRMl0ME4jmOALckgc1HqxWCSjeYB X-Google-Smtp-Source: AGRyM1sP/W0gXXiVd0E1gcpliLF83/mwjurfkbq28/xa3UPvrWoPr9+eLGizH6pNBoPYCugtoCbZfQ== X-Received: by 2002:a2e:a287:0:b0:25d:b515:430c with SMTP id k7-20020a2ea287000000b0025db515430cmr9235376lja.358.1658387496614; Thu, 21 Jul 2022 00:11:36 -0700 (PDT) Received: from [192.168.115.193] (89-162-31-138.fiber.signal.no. [89.162.31.138]) by smtp.gmail.com with ESMTPSA id 23-20020ac25f57000000b0048159b43083sm255519lfz.201.2022.07.21.00.11.35 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 21 Jul 2022 00:11:36 -0700 (PDT) Message-ID: <174eaacb-27e6-0ce3-3a27-07137a4d1a0d@linaro.org> Date: Thu, 21 Jul 2022 09:11:34 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH v2 1/2] dt-bindings: arm: aspeed: document Ampere Mt.Mitchell BMC compatibles Content-Language: en-US To: Quan Nguyen , openbmc@lists.ozlabs.org, Arnd Bergmann , Olof Johansson , soc@kernel.org, Rob Herring , Krzysztof Kozlowski , Joel Stanley , Andrew Jeffery , linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-aspeed@lists.ozlabs.org, Open Source Submission Cc: Phong Vo , thang@os.amperecomputing.com References: <20220720085230.3801945-1-quan@os.amperecomputing.com> <20220720085230.3801945-2-quan@os.amperecomputing.com> <0a5cbaaa-565a-7215-5e31-12c52f4bbcbd@linaro.org> <4516d7a6-f493-aa51-2700-bbab8ea8533a@os.amperecomputing.com> From: Krzysztof Kozlowski In-Reply-To: <4516d7a6-f493-aa51-2700-bbab8ea8533a@os.amperecomputing.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220721_001138_389925_81F985DE X-CRM114-Status: GOOD ( 16.70 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 21/07/2022 04:46, Quan Nguyen wrote: > > > On 20/07/2022 17:34, Krzysztof Kozlowski wrote: >> On 20/07/2022 10:52, Quan Nguyen wrote: >>> Document Ampere Mt.Mitchell BMC board compatible. >>> >>> Signed-off-by: Quan Nguyen >> >> Thank you for your patch. There is something to discuss/improve. >> >>> --- >>> v2: >>> + Introduce in v2 to add Ampere Mt. Mitchell BMC compatible [Krzysztof] >>> >>> Documentation/devicetree/bindings/arm/aspeed/aspeed.yaml | 1 + >>> 1 file changed, 1 insertion(+) >>> >>> diff --git a/Documentation/devicetree/bindings/arm/aspeed/aspeed.yaml b/Documentation/devicetree/bindings/arm/aspeed/aspeed.yaml >>> index d61408194998..b8146d5c4431 100644 >>> --- a/Documentation/devicetree/bindings/arm/aspeed/aspeed.yaml >>> +++ b/Documentation/devicetree/bindings/arm/aspeed/aspeed.yaml >>> @@ -71,6 +71,7 @@ properties: >>> - enum: >>> - aspeed,ast2600-evb >>> - aspeed,ast2600-evb-a1 >>> + - ampere,mtmitchell-bmc >> >> Put the entry ordered alphabetically. >> > > Thanks Krzysztof for the review. > > Will change to : > - enum: > + - ampere,mtmitchell-bmc > - aspeed,ast2600-evb > - aspeed,ast2600-evb-a1 > > But, should we correct the below as well? ie: to move > "ampere,mtjade-bmc" to before "aspeed,ast2500-evb" ? > Oops, indeed, I added aspeed in wrong place. I'll correct it in my tree. Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel