From: "Rob Herring (Arm)" <robh@kernel.org>
To: Frank Li <Frank.Li@nxp.com>
Cc: Krzysztof Kozlowski <krzk+dt@kernel.org>,
devicetree@vger.kernel.org, Richard Weinberger <richard@nod.at>,
Conor Dooley <conor+dt@kernel.org>,
linux-mtd@lists.infradead.org, imx@lists.linux.dev,
Piotr Wojtaszczyk <piotr.wojtaszczyk@timesys.com>,
linux-arm-kernel@lists.infradead.org,
Miquel Raynal <miquel.raynal@bootlin.com>,
linux-kernel@vger.kernel.org,
Vignesh Raghavendra <vigneshr@ti.com>,
Vladimir Zapolskiy <vz@mleia.com>
Subject: Re: [PATCH v2 1/1] dt-bindings: mtd: convert lpc32xx-slc.txt to yaml format
Date: Wed, 02 Jul 2025 08:28:28 -0500 [thread overview]
Message-ID: <175146290647.1131327.11939010351638573167.robh@kernel.org> (raw)
In-Reply-To: <20250701212455.3106629-1-Frank.Li@nxp.com>
On Tue, 01 Jul 2025 17:24:54 -0400, Frank Li wrote:
> Convert lpc32xx-slc.txt to yaml format.
> - add clocks and partitions to match existed dts.
> - allow nand-on-flash-bbt.
>
> Signed-off-by: Frank Li <Frank.Li@nxp.com>
> ---
> change in v2
> - fix miss 's' at partition.yaml
> - remove ref nand-controller.yaml because existed dts have not nand child
> nodes.
> ---
> .../devicetree/bindings/mtd/lpc32xx-slc.txt | 52 ----------
> .../bindings/mtd/nxp,lpc3220-slc.yaml | 96 +++++++++++++++++++
> 2 files changed, 96 insertions(+), 52 deletions(-)
> delete mode 100644 Documentation/devicetree/bindings/mtd/lpc32xx-slc.txt
> create mode 100644 Documentation/devicetree/bindings/mtd/nxp,lpc3220-slc.yaml
>
My bot found errors running 'make dt_binding_check' on your patch:
yamllint warnings/errors:
dtschema/dtc warnings/errors:
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/mtd/nxp,lpc3220-slc.example.dtb: nand-controller@20020000 (nxp,lpc3220-slc): '#address-cells' is a required property
from schema $id: http://devicetree.org/schemas/mtd/nand-controller.yaml#
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/mtd/nxp,lpc3220-slc.example.dtb: nand-controller@20020000 (nxp,lpc3220-slc): '#size-cells' is a required property
from schema $id: http://devicetree.org/schemas/mtd/nand-controller.yaml#
doc reference errors (make refcheckdocs):
See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20250701212455.3106629-1-Frank.Li@nxp.com
The base for the series is generally the latest rc1. A different dependency
should be noted in *this* patch.
If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:
pip3 install dtschema --upgrade
Please check and re-submit after running the above command yourself. Note
that DT_SCHEMA_FILES can be set to your schema file to speed up checking
your schema. However, it must be unset to test all examples with your schema.
next prev parent reply other threads:[~2025-07-02 14:49 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-01 21:24 [PATCH v2 1/1] dt-bindings: mtd: convert lpc32xx-slc.txt to yaml format Frank Li
2025-07-02 13:28 ` Rob Herring (Arm) [this message]
2025-07-02 14:14 ` Frank Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=175146290647.1131327.11939010351638573167.robh@kernel.org \
--to=robh@kernel.org \
--cc=Frank.Li@nxp.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=imx@lists.linux.dev \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=miquel.raynal@bootlin.com \
--cc=piotr.wojtaszczyk@timesys.com \
--cc=richard@nod.at \
--cc=vigneshr@ti.com \
--cc=vz@mleia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox