From: heiko@sntech.de (Heiko Stübner)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 0/4] Move DP phy switch to PHY driver
Date: Fri, 16 Feb 2018 14:05:22 +0100 [thread overview]
Message-ID: <1752563.I66u68YxnT@diego> (raw)
In-Reply-To: <a9eac594-33d5-6171-51ca-66204008fc1f@ti.com>
Hi Kishon,
Am Freitag, 16. Februar 2018, 12:04:42 CET schrieb Kishon Vijay Abraham I:
> On Friday 10 February 2017 01:14 PM, Chris Zhong wrote:
> > There are 2 Type-c PHYs in RK3399, but only one DP controller. Hence
> > only one PHY can connect to DP controller at one time, the other should
> > be disconnected. The GRF_SOC_CON26 register has a switch bit to do it,
> > set this bit means enable PHY 1, clear this bit means enable PHY 0.
> >
> > If the board has 2 Type-C ports, the DP driver get the phy id from
> > devm_of_phy_get_by_index, and then control this switch according to
> > this id. But some others board only has one Type-C port, it may be PHY 0
> > or PHY 1. The dts node id can not tell us the correct PHY id. Hence move
> > this switch to PHY driver, the PHY driver can distinguish between PHY 0
> > and PHY 1, and then write the correct register bit.
>
> Changed subject of "Documentation: bindings: add uphy-dp-sel for Rockchip
> USB Type-C PHY" as suggested by Rob, rebased "phy: rockchip-typec: support
> DP phy switch" to the latest kernel and merged.
I'm not sure how far along you are with your merging, but you might want to
revert this one.
In your inbox you should find more recent threads about the type-c phy
where Rob strongly suggested moving the whole grf registers out of the
dt and into the driver.
Enric Balletbo did just that and posted a series (including the dp-move)
yesterday (refined in a v2 from today).
Alternatively Enric could rebase his series on top of that recent change.
Heiko
next prev parent reply other threads:[~2018-02-16 13:05 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-10 7:44 [PATCH 0/4] Move DP phy switch to PHY driver Chris Zhong
2017-02-10 7:44 ` [PATCH 1/4] Documentation: bindings: add uphy-dp-sel for Rockchip USB Type-C PHY Chris Zhong
2017-02-16 2:20 ` Rob Herring
2017-02-16 3:14 ` Chris Zhong
2017-02-10 7:44 ` [PATCH 2/4] arm64: dts: rockchip: add rockchip, uphy-dp-sel for Type-C phy Chris Zhong
2017-02-10 7:44 ` [PATCH 3/4] phy: rockchip-typec: support DP phy switch Chris Zhong
2017-03-09 0:39 ` Brian Norris
2017-03-09 1:02 ` Heiko Stübner
2017-03-09 2:19 ` Chris Zhong
2017-03-09 3:10 ` Brian Norris
2017-03-09 8:31 ` Heiko Stübner
2017-03-09 23:35 ` Brian Norris
2017-02-10 7:44 ` [PATCH 4/4] drm/rockchip: cdn-dp: remove the " Chris Zhong
2017-11-28 23:32 ` [PATCH 0/4] Move DP phy switch to PHY driver Doug Anderson
2017-11-30 2:27 ` Chris Zhong
2017-12-01 21:42 ` Doug Anderson
2017-12-01 21:58 ` Heiko Stuebner
2017-12-04 2:47 ` Chris Zhong
2017-12-04 7:46 ` Heiko Stübner
2017-12-04 16:08 ` Doug Anderson
2017-12-04 21:53 ` Heiko Stübner
2018-02-16 11:04 ` Kishon Vijay Abraham I
2018-02-16 13:05 ` Heiko Stübner [this message]
2018-02-16 13:59 ` Kishon Vijay Abraham I
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1752563.I66u68YxnT@diego \
--to=heiko@sntech.de \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).