linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: "Rob Herring (Arm)" <robh@kernel.org>
To: Jay Liu <jay.liu@mediatek.com>
Cc: linux-arm-kernel@lists.infradead.org,
	 Philipp Zabel <p.zabel@pengutronix.de>,
	 Chun-Kuang Hu <chunkuang.hu@kernel.org>,
	 Krzysztof Kozlowski <krzk+dt@kernel.org>,
	 Yongqiang Niu <yongqiang.niu@mediatek.com>,
	devicetree@vger.kernel.org,  CK Hu <ck.hu@mediatek.com>,
	linux-kernel@vger.kernel.org,  Conor Dooley <conor+dt@kernel.org>,
	Maxime Ripard <mripard@kernel.org>,
	 Matthias Brugger <matthias.bgg@gmail.com>,
	 Thomas Zimmermann <tzimmermann@suse.de>,
	linux-mediatek@lists.infradead.org,
	 David Airlie <airlied@gmail.com>,
	 Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
	 Hsin-Yi Wang <hsinyi@chromium.org>,
	dri-devel@lists.freedesktop.org,
	 AngeloGioacchino Del Regno
	<angelogioacchino.delregno@collabora.com>,
	 Simona Vetter <simona@ffwll.ch>
Subject: Re: [PATCH v2 4/7] dt-bindings: display: mediatek: disp-tdshp: Add support for MT8196
Date: Sun, 27 Jul 2025 15:27:40 -0500	[thread overview]
Message-ID: <175364805648.3160.7761307037849167349.robh@kernel.org> (raw)
In-Reply-To: <20250727071609.26037-5-jay.liu@mediatek.com>


On Sun, 27 Jul 2025 15:15:54 +0800, Jay Liu wrote:
> Add disp-tdshp hardware description for MediaTek MT8196 SoC
> 
> Signed-off-by: Jay Liu <jay.liu@mediatek.com>
> Signed-off-by: 20220315152503 created <jay.liu@mediatek.com>
> ---
>  .../display/mediatek/mediatek,disp-tdshp.yaml | 50 +++++++++++++++++++
>  1 file changed, 50 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/display/mediatek/mediatek,disp-tdshp.yaml
> 

My bot found errors running 'make dt_binding_check' on your patch:

yamllint warnings/errors:
./Documentation/devicetree/bindings/display/mediatek/mediatek,disp-tdshp.yaml:23:7: [warning] wrong indentation: expected 4 but found 6 (indentation)
./Documentation/devicetree/bindings/display/mediatek/mediatek,disp-tdshp.yaml:41:5: [warning] wrong indentation: expected 2 but found 4 (indentation)
./Documentation/devicetree/bindings/display/mediatek/mediatek,disp-tdshp.yaml:42:10: [error] missing starting space in comment (comments)
./Documentation/devicetree/bindings/display/mediatek/mediatek,disp-tdshp.yaml:43:10: [error] missing starting space in comment (comments)
./Documentation/devicetree/bindings/display/mediatek/mediatek,disp-tdshp.yaml:45:9: [error] syntax error: expected <block end>, but found '<scalar>' (syntax)

dtschema/dtc warnings/errors:
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/display/mediatek/mediatek,disp-tdshp.yaml: ignoring, error parsing file
./Documentation/devicetree/bindings/display/mediatek/mediatek,disp-tdshp.yaml:45:9: did not find expected key
make[2]: *** Deleting file 'Documentation/devicetree/bindings/display/mediatek/mediatek,disp-tdshp.example.dts'
Documentation/devicetree/bindings/display/mediatek/mediatek,disp-tdshp.yaml:45:9: did not find expected key
make[2]: *** [Documentation/devicetree/bindings/Makefile:26: Documentation/devicetree/bindings/display/mediatek/mediatek,disp-tdshp.example.dts] Error 1
make[2]: *** Waiting for unfinished jobs....
make[1]: *** [/builds/robherring/dt-review-ci/linux/Makefile:1526: dt_binding_check] Error 2
make: *** [Makefile:248: __sub-make] Error 2

doc reference errors (make refcheckdocs):

See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20250727071609.26037-5-jay.liu@mediatek.com

The base for the series is generally the latest rc1. A different dependency
should be noted in *this* patch.

If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:

pip3 install dtschema --upgrade

Please check and re-submit after running the above command yourself. Note
that DT_SCHEMA_FILES can be set to your schema file to speed up checking
your schema. However, it must be unset to test all examples with your schema.



  reply	other threads:[~2025-07-27 20:30 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-07-27  7:15 [PATCH v2 0/7] porting pq compnent for MT8196 Jay Liu
2025-07-27  7:15 ` [PATCH v2 1/7] drm/mediatek: Add CCORR component support " Jay Liu
2025-08-04  8:57   ` AngeloGioacchino Del Regno
2025-08-06  6:24   ` CK Hu (胡俊光)
2025-07-27  7:15 ` [PATCH v2 2/7] drm/mediatek: fix CCORR mtk_ctm_s31_32_to_s1_n function issue Jay Liu
2025-08-06  6:37   ` CK Hu (胡俊光)
2025-08-07  6:19     ` Jay Liu (刘博)
2025-08-07 11:30       ` CK Hu (胡俊光)
2025-07-27  7:15 ` [PATCH v2 3/7] drm/mediatek: Add TDSHP component support for MT8196 Jay Liu
2025-08-06  6:45   ` CK Hu (胡俊光)
2025-07-27  7:15 ` [PATCH v2 4/7] dt-bindings: display: mediatek: disp-tdshp: Add " Jay Liu
2025-07-27 20:27   ` Rob Herring (Arm) [this message]
2025-07-28 12:01   ` Krzysztof Kozlowski
2025-07-29  3:22     ` Jay Liu (刘博)
2025-08-06  6:50   ` CK Hu (胡俊光)
2025-07-27  7:15 ` [PATCH v2 5/7] dt-bindings: display: mediatek: ccorr: " Jay Liu
2025-07-27 20:27   ` Rob Herring (Arm)
2025-07-27 20:35   ` Rob Herring
2025-07-28  6:52     ` Jay Liu (刘博)
2025-07-27  7:15 ` [PATCH v2 6/7] dt-bindings: display: mediatek: dither: " Jay Liu
2025-07-27 20:27   ` Rob Herring (Arm)
2025-08-06  6:53   ` CK Hu (胡俊光)
2025-07-27  7:15 ` [PATCH v2 7/7] dt-bindings: display: mediatek: gamma: " Jay Liu
2025-07-27 20:27   ` Rob Herring (Arm)

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=175364805648.3160.7761307037849167349.robh@kernel.org \
    --to=robh@kernel.org \
    --cc=airlied@gmail.com \
    --cc=angelogioacchino.delregno@collabora.com \
    --cc=chunkuang.hu@kernel.org \
    --cc=ck.hu@mediatek.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=hsinyi@chromium.org \
    --cc=jay.liu@mediatek.com \
    --cc=krzk+dt@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mediatek@lists.infradead.org \
    --cc=maarten.lankhorst@linux.intel.com \
    --cc=matthias.bgg@gmail.com \
    --cc=mripard@kernel.org \
    --cc=p.zabel@pengutronix.de \
    --cc=simona@ffwll.ch \
    --cc=tzimmermann@suse.de \
    --cc=yongqiang.niu@mediatek.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).