From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 67097C64EC4 for ; Fri, 3 Mar 2023 15:49:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=T128iJSFvuHxYjZcJKD2CE5SQ5YblRslZYmVM4ahv4w=; b=gSoFSYPtbgTqEC 4ghCIeUHlEzL/Go9XUARVeAP4mqKJZyu0Tw4VtKreo/3+dFovpCvFbtUx5QaMegxlgwOm1A/wMJen keINjOBAGPoGWj3dDjv5KkeDd4PVSBp80403DPP57rPVU8mDZ8iJl7f9oqd0etQNedC0OpJJ6ApCh cLmLlROIsfOfOHYjcJFyh33YjVNNHc37IyaD01eKTVdhkOc8g3InEWolLcd7F+dYBgSzwQ1sRqGfE WKUco7MnwnOJsspTK8PWom+ZcVVoWvBUO1iObBd+Do2A9me2VZCNQ3YB8haKyKjAfsctu1St7RmLG Z3v8ajMk3gbjwzDHJXQA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pY7dd-006jnz-Q0; Fri, 03 Mar 2023 15:48:05 +0000 Received: from gloria.sntech.de ([185.11.138.130]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pY7da-006jml-6k; Fri, 03 Mar 2023 15:48:03 +0000 Received: from ip5b412258.dynamic.kabel-deutschland.de ([91.65.34.88] helo=diego.localnet) by gloria.sntech.de with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1pY7dO-0005tb-P2; Fri, 03 Mar 2023 16:47:50 +0100 From: Heiko =?ISO-8859-1?Q?St=FCbner?= To: rafael@kernel.org, daniel.lezcano@linaro.org, Daniel Lezcano Cc: linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, Miquel Raynal , Florian Fainelli , Amit Kucheria , Zhang Rui , Markus Mayer , Broadcom internal kernel review list , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , Jernej Skrabec , Mark Brown , "moderated list:BROADCOM BCM7XXX ARM ARCHITECTURE" , "open list:ARM/Rockchip SoC support" Subject: Re: [PATCH v5 06/18] thermal: Remove debug or error messages in get_temp() ops Date: Fri, 03 Mar 2023 16:47:55 +0100 Message-ID: <1753720.VLH7GnMWUR@diego> In-Reply-To: <20230301201446.3713334-7-daniel.lezcano@linaro.org> References: <20230301201446.3713334-1-daniel.lezcano@linaro.org> <20230301201446.3713334-7-daniel.lezcano@linaro.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230303_074802_281523_4E095E2D X-CRM114-Status: GOOD ( 16.67 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Am Mittwoch, 1. M=E4rz 2023, 21:14:34 CET schrieb Daniel Lezcano: > Some get_temp() ops implementation are showing an error or a debug > message if the reading of the sensor fails. > = > The debug message is already displayed from the call site of this > ops. So we can remove it. > = > On the other side, the error should not be displayed because in > production that can raise tons of messages. > = > Finally, some drivers are showing a debug message with the > temperature, this is also accessible through the trace from the core > code in the temperature_update() function. > = > Another benefit is the dev_* messages are accessing the thermal zone > device field from the structure, so we encapsulate even more the code > by preventing these accesses. > = > Remove those messages. > = > Signed-off-by: Daniel Lezcano > Reviewed-by: Miquel Raynal #Armada > Acked-by: Florian Fainelli #brcmstb_thermal.c Acked-by: Heiko Stuebner #rockchip _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel