From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 4CEDDCA0EE7 for ; Wed, 13 Aug 2025 18:05:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Subject:Message-Id: References:In-Reply-To:To:Cc:From:MIME-Version:Content-Transfer-Encoding: Content-Type:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=QALSlaYu8hlddiRkiilLuHilU0aIbh5LLlEPr0Oi69A=; b=z/L5hftm8QmM4S54Oj4bs6LMnN WgvC9sX4fYdIxFQefnJ+pa7sGp5fg5yjADIhoVrZcMVdVC7Y+kYz7LOCgQ/LZwBU1eNphkCHE7bHq K+9A/EKpo6NVwqzTcMCVgyDOyDVwAesmOerIg6MUf2GQVr7kafV5WvWETIPuJ3SyURu4KkdWqLZ/t UXJUA8Bohifq7MpRdGU4hlI2ize3DDyoDSS0xBfHOvil5suxifwp6MkYNYMex8JWOZak3qxd95Eeb c/ALLN73bxswnZN3kHAZeVT5jweHbW1bFLmcHE3Sy1EGzQRWXuOaPmzyWxCLmQDvqHzemSLGwxFnP Wmu0ufag==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1umFr9-0000000EeUB-0s5W; Wed, 13 Aug 2025 18:05:47 +0000 Received: from nyc.source.kernel.org ([147.75.193.91]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1umEWB-0000000ERmM-2siU for linux-arm-kernel@lists.infradead.org; Wed, 13 Aug 2025 16:40:05 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by nyc.source.kernel.org (Postfix) with ESMTP id 44FCFA57E64; Wed, 13 Aug 2025 16:40:02 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id C198EC4CEEB; Wed, 13 Aug 2025 16:40:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1755103201; bh=s8ZXEipGSIJlMDIb18naqDV3kZSHdB/qD0ILmHJeqbs=; h=Date:From:Cc:To:In-Reply-To:References:Subject:From; b=omjkMhQD9oRe4bVtEyTDH44yDFKboKpOGtcbD8GT9O8J352gBe6l8mq2PUjcuwAcU 8ibfOwvFrmjsvzbFS6QHEhUOniPp/bBUG6U0B0RhmxCJy8c9YG8LsX5OJMHzKVllLd M49oGrDfr/dl9kC0aV2OSF6sJ1H2VLKNIMvAhLoHWaHjpZoTuTUy85g4HcymGPfokP ybRp0b5p3By1kpX0tHtrBcx5UIdIhtggKG1tdMEPu3E39ZauYxLd+N3fL3Yh/59aMh bdA0AfNLGPluOs/0AYYw+WNIjuwcsOlzND96burMON257vVCbGDUXo1L/tJ0UKGXrb GDnvh28lixVDQ== Date: Wed, 13 Aug 2025 11:40:00 -0500 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 From: "Rob Herring (Arm)" Cc: Jernej Skrabec , linux-kernel@vger.kernel.org, "David S. Miller" , Andrew Lunn , Andre Przywara , Chen-Yu Tsai , Eric Dumazet , Krzysztof Kozlowski , devicetree@vger.kernel.org, Paolo Abeni , linux-arm-kernel@lists.infradead.org, Samuel Holland , Jakub Kicinski , netdev@vger.kernel.org, linux-sunxi@lists.linux.dev, Conor Dooley To: Chen-Yu Tsai In-Reply-To: <20250813145540.2577789-2-wens@kernel.org> References: <20250813145540.2577789-1-wens@kernel.org> <20250813145540.2577789-2-wens@kernel.org> Message-Id: <175510320095.362031.4736054030445457554.robh@kernel.org> Subject: Re: [PATCH net-next v2 01/10] dt-bindings: net: sun8i-emac: Add A523 GMAC200 compatible X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250813_094003_864798_03D42A3F X-CRM114-Status: GOOD ( 18.19 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, 13 Aug 2025 22:55:31 +0800, Chen-Yu Tsai wrote: > From: Chen-Yu Tsai > > The Allwinner A523 SoC family has a second Ethernet controller, called > the GMAC200 in the BSP and T527 datasheet, and referred to as GMAC1 for > numbering. This controller, according to BSP sources, is fully > compatible with a slightly newer version of the Synopsys DWMAC core. > The glue layer around the controller is the same as found around older > DWMAC cores on Allwinner SoCs. The only slight difference is that since > this is the second controller on the SoC, the register for the clock > delay controls is at a different offset. Last, the integration includes > a dedicated clock gate for the memory bus and the whole thing is put in > a separately controllable power domain. > > Add a compatible string entry for it, and work in the requirements for > a second clock and a power domain. > > Signed-off-by: Chen-Yu Tsai > --- > Changes since v1: > - Switch to generic (tx|rx)-internal-delay-ps properties > --- > .../net/allwinner,sun8i-a83t-emac.yaml | 81 ++++++++++++++++++- > 1 file changed, 79 insertions(+), 2 deletions(-) > My bot found errors running 'make dt_binding_check' on your patch: yamllint warnings/errors: dtschema/dtc warnings/errors: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/net/toshiba,visconti-dwmac.example.dtb: ethernet@28000000 (toshiba,visconti-dwmac): clock-names: ['stmmaceth', 'phy_ref_clk'] is too long from schema $id: http://devicetree.org/schemas/net/allwinner,sun8i-a83t-emac.yaml# /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/net/toshiba,visconti-dwmac.example.dtb: ethernet@28000000 (toshiba,visconti-dwmac): clocks: [[4294967295, 28], [4294967295, 118]] is too long from schema $id: http://devicetree.org/schemas/net/allwinner,sun8i-a83t-emac.yaml# /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/net/toshiba,visconti-dwmac.example.dtb: ethernet@28000000 (toshiba,visconti-dwmac): compatible: 'oneOf' conditional failed, one must be fixed: ['toshiba,visconti-dwmac', 'snps,dwmac-4.20a'] is too long 'allwinner,sun8i-a83t-emac' was expected 'allwinner,sun8i-h3-emac' was expected 'allwinner,sun8i-r40-gmac' was expected 'allwinner,sun8i-v3s-emac' was expected 'allwinner,sun50i-a64-emac' was expected 'toshiba,visconti-dwmac' is not one of ['allwinner,sun20i-d1-emac', 'allwinner,sun50i-a100-emac', 'allwinner,sun50i-h6-emac', 'allwinner,sun50i-h616-emac0', 'allwinner,sun55i-a523-gmac0'] 'allwinner,sun55i-a523-gmac200' was expected from schema $id: http://devicetree.org/schemas/net/allwinner,sun8i-a83t-emac.yaml# /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/net/toshiba,visconti-dwmac.example.dtb: ethernet@28000000 (toshiba,visconti-dwmac): 'resets' is a required property from schema $id: http://devicetree.org/schemas/net/allwinner,sun8i-a83t-emac.yaml# /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/net/toshiba,visconti-dwmac.example.dtb: ethernet@28000000 (toshiba,visconti-dwmac): 'reset-names' is a required property from schema $id: http://devicetree.org/schemas/net/allwinner,sun8i-a83t-emac.yaml# /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/net/toshiba,visconti-dwmac.example.dtb: ethernet@28000000 (toshiba,visconti-dwmac): 'syscon' is a required property from schema $id: http://devicetree.org/schemas/net/allwinner,sun8i-a83t-emac.yaml# /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/net/stm32-dwmac.example.dtb: ethernet@5800a000 (st,stm32mp1-dwmac): clock-names: ['stmmaceth', 'mac-clk-tx', 'mac-clk-rx', 'ethstp', 'eth-ck'] is too long from schema $id: http://devicetree.org/schemas/net/allwinner,sun8i-a83t-emac.yaml# /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/net/stm32-dwmac.example.dtb: ethernet@5800a000 (st,stm32mp1-dwmac): clocks: [[4294967295, 105], [4294967295, 103], [4294967295, 104], [4294967295, 112], [4294967295, 123]] is too long from schema $id: http://devicetree.org/schemas/net/allwinner,sun8i-a83t-emac.yaml# /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/net/stm32-dwmac.example.dtb: ethernet@5800a000 (st,stm32mp1-dwmac): clock-names: ['stmmaceth', 'mac-clk-tx', 'mac-clk-rx', 'ethstp', 'eth-ck'] is too long from schema $id: http://devicetree.org/schemas/net/allwinner,sun8i-a83t-emac.yaml# /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/net/stm32-dwmac.example.dtb: ethernet@5800a000 (st,stm32mp1-dwmac): clocks: [[4294967295, 105], [4294967295, 103], [4294967295, 104], [4294967295, 112], [4294967295, 123]] is too long from schema $id: http://devicetree.org/schemas/net/allwinner,sun8i-a83t-emac.yaml# /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/net/stm32-dwmac.example.dtb: ethernet@5800a000 (st,stm32mp1-dwmac): compatible: 'oneOf' conditional failed, one must be fixed: ['st,stm32mp1-dwmac', 'snps,dwmac-4.20a'] is too long 'allwinner,sun8i-a83t-emac' was expected 'allwinner,sun8i-h3-emac' was expected 'allwinner,sun8i-r40-gmac' was expected 'allwinner,sun8i-v3s-emac' was expected 'allwinner,sun50i-a64-emac' was expected 'st,stm32mp1-dwmac' is not one of ['allwinner,sun20i-d1-emac', 'allwinner,sun50i-a100-emac', 'allwinner,sun50i-h6-emac', 'allwinner,sun50i-h616-emac0', 'allwinner,sun55i-a523-gmac0'] 'allwinner,sun55i-a523-gmac200' was expected from schema $id: http://devicetree.org/schemas/net/allwinner,sun8i-a83t-emac.yaml# /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/net/stm32-dwmac.example.dtb: ethernet@5800a000 (st,stm32mp1-dwmac): 'resets' is a required property from schema $id: http://devicetree.org/schemas/net/allwinner,sun8i-a83t-emac.yaml# /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/net/stm32-dwmac.example.dtb: ethernet@5800a000 (st,stm32mp1-dwmac): 'reset-names' is a required property from schema $id: http://devicetree.org/schemas/net/allwinner,sun8i-a83t-emac.yaml# /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/net/stm32-dwmac.example.dtb: ethernet@5800a000 (st,stm32mp1-dwmac): 'phy-handle' is a required property from schema $id: http://devicetree.org/schemas/net/allwinner,sun8i-a83t-emac.yaml# /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/net/stm32-dwmac.example.dtb: ethernet@5800a000 (st,stm32mp1-dwmac): 'syscon' is a required property from schema $id: http://devicetree.org/schemas/net/allwinner,sun8i-a83t-emac.yaml# /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/net/stm32-dwmac.example.dtb: ethernet@5800a000 (st,stm32mp1-dwmac): Unevaluated properties are not allowed ('reg-names', 'st,syscon' were unexpected) from schema $id: http://devicetree.org/schemas/net/allwinner,sun8i-a83t-emac.yaml# /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/net/mediatek-dwmac.example.dtb: ethernet@1101c000 (mediatek,mt2712-gmac): clock-names:0: 'stmmaceth' was expected from schema $id: http://devicetree.org/schemas/net/allwinner,sun8i-a83t-emac.yaml# /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/net/mediatek-dwmac.example.dtb: ethernet@1101c000 (mediatek,mt2712-gmac): clock-names: ['axi', 'apb', 'mac_main', 'ptp_ref', 'rmii_internal'] is too long from schema $id: http://devicetree.org/schemas/net/allwinner,sun8i-a83t-emac.yaml# /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/net/mediatek-dwmac.example.dtb: ethernet@1101c000 (mediatek,mt2712-gmac): clocks: [[4294967295, 34], [4294967295, 37], [4294967295, 154], [4294967295, 155], [4294967295, 158]] is too long from schema $id: http://devicetree.org/schemas/net/allwinner,sun8i-a83t-emac.yaml# /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/net/mediatek-dwmac.example.dtb: ethernet@1101c000 (mediatek,mt2712-gmac): power-domains: False schema does not allow [[4294967295, 4]] from schema $id: http://devicetree.org/schemas/net/allwinner,sun8i-a83t-emac.yaml# /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/net/mediatek-dwmac.example.dtb: ethernet@1101c000 (mediatek,mt2712-gmac): clock-names: ['axi', 'apb', 'mac_main', 'ptp_ref', 'rmii_internal'] is too long from schema $id: http://devicetree.org/schemas/net/allwinner,sun8i-a83t-emac.yaml# /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/net/mediatek-dwmac.example.dtb: ethernet@1101c000 (mediatek,mt2712-gmac): clocks: [[4294967295, 34], [4294967295, 37], [4294967295, 154], [4294967295, 155], [4294967295, 158]] is too long from schema $id: http://devicetree.org/schemas/net/allwinner,sun8i-a83t-emac.yaml# /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/net/mediatek-dwmac.example.dtb: ethernet@1101c000 (mediatek,mt2712-gmac): compatible: 'oneOf' conditional failed, one must be fixed: ['mediatek,mt2712-gmac', 'snps,dwmac-4.20a'] is too long 'allwinner,sun8i-a83t-emac' was expected 'allwinner,sun8i-h3-emac' was expected 'allwinner,sun8i-r40-gmac' was expected 'allwinner,sun8i-v3s-emac' was expected 'allwinner,sun50i-a64-emac' was expected 'mediatek,mt2712-gmac' is not one of ['allwinner,sun20i-d1-emac', 'allwinner,sun50i-a100-emac', 'allwinner,sun50i-h6-emac', 'allwinner,sun50i-h616-emac0', 'allwinner,sun55i-a523-gmac0'] 'allwinner,sun55i-a523-gmac200' was expected from schema $id: http://devicetree.org/schemas/net/allwinner,sun8i-a83t-emac.yaml# /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/net/mediatek-dwmac.example.dtb: ethernet@1101c000 (mediatek,mt2712-gmac): 'resets' is a required property from schema $id: http://devicetree.org/schemas/net/allwinner,sun8i-a83t-emac.yaml# /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/net/mediatek-dwmac.example.dtb: ethernet@1101c000 (mediatek,mt2712-gmac): 'reset-names' is a required property from schema $id: http://devicetree.org/schemas/net/allwinner,sun8i-a83t-emac.yaml# /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/net/mediatek-dwmac.example.dtb: ethernet@1101c000 (mediatek,mt2712-gmac): 'phy-handle' is a required property from schema $id: http://devicetree.org/schemas/net/allwinner,sun8i-a83t-emac.yaml# /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/net/mediatek-dwmac.example.dtb: ethernet@1101c000 (mediatek,mt2712-gmac): 'syscon' is a required property from schema $id: http://devicetree.org/schemas/net/allwinner,sun8i-a83t-emac.yaml# /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/net/mediatek-dwmac.example.dtb: ethernet@1101c000 (mediatek,mt2712-gmac): Unevaluated properties are not allowed ('mediatek,pericfg', 'mediatek,tx-delay-ps' were unexpected) from schema $id: http://devicetree.org/schemas/net/allwinner,sun8i-a83t-emac.yaml# doc reference errors (make refcheckdocs): See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20250813145540.2577789-2-wens@kernel.org The base for the series is generally the latest rc1. A different dependency should be noted in *this* patch. If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure 'yamllint' is installed and dt-schema is up to date: pip3 install dtschema --upgrade Please check and re-submit after running the above command yourself. Note that DT_SCHEMA_FILES can be set to your schema file to speed up checking your schema. However, it must be unset to test all examples with your schema.