* [PATCH] arm64: dts: rockchip: Add vcc-supply to SPI flash on Pinephone Pro
@ 2025-08-27 14:34 Peter Robinson
2025-08-28 9:59 ` Ondřej Jirman
2025-08-28 13:30 ` Heiko Stuebner
0 siblings, 2 replies; 3+ messages in thread
From: Peter Robinson @ 2025-08-27 14:34 UTC (permalink / raw)
To: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Heiko Stuebner,
Diederik de Haas, devicetree, linux-arm-kernel, linux-rockchip,
linux-kernel, Dragan Simic, Ondrej Jirman
Cc: Peter Robinson
As documented in the PinephonePro-Schematic-V1.0-20211127.pdf,
page 11, the SPI Flash's VCC pin is connected to VCC_1V8 power
source. This fixes the following warning:
spi-nor spi1.0: supply vcc not found, using dummy regulator
Signed-off-by: Peter Robinson <pbrobinson@gmail.com>
---
arch/arm64/boot/dts/rockchip/rk3399-pinephone-pro.dts | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/arm64/boot/dts/rockchip/rk3399-pinephone-pro.dts b/arch/arm64/boot/dts/rockchip/rk3399-pinephone-pro.dts
index be90e049a302c..24e4365a2e588 100644
--- a/arch/arm64/boot/dts/rockchip/rk3399-pinephone-pro.dts
+++ b/arch/arm64/boot/dts/rockchip/rk3399-pinephone-pro.dts
@@ -772,6 +772,7 @@ flash@0 {
compatible = "jedec,spi-nor";
reg = <0>;
spi-max-frequency = <10000000>;
+ vcc-supply = <&vcc_1v8>;
};
};
--
2.51.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] arm64: dts: rockchip: Add vcc-supply to SPI flash on Pinephone Pro
2025-08-27 14:34 [PATCH] arm64: dts: rockchip: Add vcc-supply to SPI flash on Pinephone Pro Peter Robinson
@ 2025-08-28 9:59 ` Ondřej Jirman
2025-08-28 13:30 ` Heiko Stuebner
1 sibling, 0 replies; 3+ messages in thread
From: Ondřej Jirman @ 2025-08-28 9:59 UTC (permalink / raw)
To: Peter Robinson
Cc: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Heiko Stuebner,
Diederik de Haas, devicetree, linux-arm-kernel, linux-rockchip,
linux-kernel, Dragan Simic
On Wed, Aug 27, 2025 at 03:34:58PM +0100, Peter Robinson wrote:
> As documented in the PinephonePro-Schematic-V1.0-20211127.pdf,
> page 11, the SPI Flash's VCC pin is connected to VCC_1V8 power
> source. This fixes the following warning:
>
> spi-nor spi1.0: supply vcc not found, using dummy regulator
>
> Signed-off-by: Peter Robinson <pbrobinson@gmail.com>
Reviewed-by: Ondřej Jirman <megi@xff.cz>
Thank you,
o.
> ---
> arch/arm64/boot/dts/rockchip/rk3399-pinephone-pro.dts | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/arch/arm64/boot/dts/rockchip/rk3399-pinephone-pro.dts b/arch/arm64/boot/dts/rockchip/rk3399-pinephone-pro.dts
> index be90e049a302c..24e4365a2e588 100644
> --- a/arch/arm64/boot/dts/rockchip/rk3399-pinephone-pro.dts
> +++ b/arch/arm64/boot/dts/rockchip/rk3399-pinephone-pro.dts
> @@ -772,6 +772,7 @@ flash@0 {
> compatible = "jedec,spi-nor";
> reg = <0>;
> spi-max-frequency = <10000000>;
> + vcc-supply = <&vcc_1v8>;
> };
> };
>
> --
> 2.51.0
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] arm64: dts: rockchip: Add vcc-supply to SPI flash on Pinephone Pro
2025-08-27 14:34 [PATCH] arm64: dts: rockchip: Add vcc-supply to SPI flash on Pinephone Pro Peter Robinson
2025-08-28 9:59 ` Ondřej Jirman
@ 2025-08-28 13:30 ` Heiko Stuebner
1 sibling, 0 replies; 3+ messages in thread
From: Heiko Stuebner @ 2025-08-28 13:30 UTC (permalink / raw)
To: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Diederik de Haas,
devicetree, linux-arm-kernel, linux-rockchip, linux-kernel,
Dragan Simic, Ondrej Jirman, Peter Robinson
Cc: Heiko Stuebner
On Wed, 27 Aug 2025 15:34:58 +0100, Peter Robinson wrote:
> As documented in the PinephonePro-Schematic-V1.0-20211127.pdf,
> page 11, the SPI Flash's VCC pin is connected to VCC_1V8 power
> source. This fixes the following warning:
>
> spi-nor spi1.0: supply vcc not found, using dummy regulator
>
>
> [...]
Applied, thanks!
[1/1] arm64: dts: rockchip: Add vcc-supply to SPI flash on Pinephone Pro
commit: 497aa80ec7ee145b3606e7434d57091974d78598
Best regards,
--
Heiko Stuebner <heiko@sntech.de>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2025-08-28 17:27 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-08-27 14:34 [PATCH] arm64: dts: rockchip: Add vcc-supply to SPI flash on Pinephone Pro Peter Robinson
2025-08-28 9:59 ` Ondřej Jirman
2025-08-28 13:30 ` Heiko Stuebner
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).