From: Will Deacon <will@kernel.org>
To: kvmarm@lists.linux.dev, linux-arm-kernel@lists.infradead.org,
Fuad Tabba <tabba@google.com>
Cc: catalin.marinas@arm.com, kernel-team@android.com,
Will Deacon <will@kernel.org>,
maz@kernel.org, oliver.upton@linux.dev, joey.gouly@arm.com,
suzuki.poulose@arm.com, yuzenghui@huawei.com,
vdonnefort@google.com, qperret@google.com,
sebastianene@google.com, keirf@google.com, smostafa@google.com
Subject: Re: [PATCH v3 0/3] arm64: sysreg: Fix sysreg field definitions and generation script
Date: Thu, 11 Sep 2025 17:11:13 +0100 [thread overview]
Message-ID: <175759836827.886602.11949922116281673131.b4-ty@kernel.org> (raw)
In-Reply-To: <20250829095143.123476-1-tabba@google.com>
On Fri, 29 Aug 2025 10:51:40 +0100, Fuad Tabba wrote:
> The sysreg definitions file has a few errors. In Enum Security,
> NSACR_RFR is set to 0b0001 instead of the spec value of 0b0010.
> Additionaly, the sign of the Enums DoubleLock and EIESB are wrong
> (should be Signed and Unsigned, respectively).
>
> Moreover, the file has some redundant definitions, e.g.,
> RCWSMASK_EL1. While these redundant definitions are not wrong per se,
> they add unnecessary code into the generated header file and could be a
> source of future bugs.
>
> [...]
Applied to arm64 (for-next/sysregs), thanks!
[1/3] arm64: sysreg: Fix and tidy up sysreg field definitions
https://git.kernel.org/arm64/c/2c2529e47062
[2/3] arm64: sysreg: Correct sign definitions for EIESB and DoubleLock
https://git.kernel.org/arm64/c/f4d4ebc84995
[3/3] arm64: sysreg: Add validation checks to sysreg header generation script
https://git.kernel.org/arm64/c/382cbbe7fb2a
Cheers,
--
Will
https://fixes.arm64.dev
https://next.arm64.dev
https://will.arm64.dev
next prev parent reply other threads:[~2025-09-11 16:11 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-29 9:51 [PATCH v3 0/3] arm64: sysreg: Fix sysreg field definitions and generation script Fuad Tabba
2025-08-29 9:51 ` [PATCH v3 1/3] arm64: sysreg: Fix and tidy up sysreg field definitions Fuad Tabba
2025-08-29 10:07 ` Mark Rutland
2025-08-29 9:51 ` [PATCH v3 2/3] arm64: sysreg: Correct sign definitions for EIESB and DoubleLock Fuad Tabba
2025-08-29 10:10 ` Mark Rutland
2025-08-29 9:51 ` [PATCH v3 3/3] arm64: sysreg: Add validation checks to sysreg header generation script Fuad Tabba
2025-08-29 10:14 ` Mark Rutland
2025-09-11 16:11 ` Will Deacon [this message]
-- strict thread matches above, loose matches on Subject: below --
2025-09-09 7:23 [PATCH v3 0/3] arm64: sysreg: Fix sysreg field definitions and " Fuad Tabba
2025-09-09 8:49 ` Fuad Tabba
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=175759836827.886602.11949922116281673131.b4-ty@kernel.org \
--to=will@kernel.org \
--cc=catalin.marinas@arm.com \
--cc=joey.gouly@arm.com \
--cc=keirf@google.com \
--cc=kernel-team@android.com \
--cc=kvmarm@lists.linux.dev \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=maz@kernel.org \
--cc=oliver.upton@linux.dev \
--cc=qperret@google.com \
--cc=sebastianene@google.com \
--cc=smostafa@google.com \
--cc=suzuki.poulose@arm.com \
--cc=tabba@google.com \
--cc=vdonnefort@google.com \
--cc=yuzenghui@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox