public inbox for linux-arm-kernel@lists.infradead.org
 help / color / mirror / Atom feed
From: "Rob Herring (Arm)" <robh@kernel.org>
To: Gary Yang <gary.yang@cixtech.com>
Cc: devicetree@vger.kernel.org, linux-gpio@vger.kernel.org,
	 cix-kernel-upstream@cixtech.com, krzk+dt@kernel.org,
	 linux-kernel@vger.kernel.org, conor+dt@kernel.org,
	linus.walleij@linaro.org,  linux-arm-kernel@lists.infradead.org
Subject: Re: [v2 2/3] dt-bindings: pinctrl: Add cix,sky1-pinctrl
Date: Fri, 12 Sep 2025 09:23:54 -0500	[thread overview]
Message-ID: <175768614788.1334014.18023232974115676473.robh@kernel.org> (raw)
In-Reply-To: <20250912060650.2180691-3-gary.yang@cixtech.com>


On Fri, 12 Sep 2025 14:06:49 +0800, Gary Yang wrote:
> The pin-controller is used to control the Soc pins.
> There are two pin-controllers on Cix Sky1 platform.
> One is used under S0 state, the other is used under
> S5 state.
> 
> Signed-off-by: Gary Yang <gary.yang@cixtech.com>
> ---
>  .../bindings/pinctrl/cix,sky1-pinctrl.yaml    | 85 +++++++++++++++++++
>  1 file changed, 85 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/pinctrl/cix,sky1-pinctrl.yaml
> 

My bot found errors running 'make dt_binding_check' on your patch:

yamllint warnings/errors:

dtschema/dtc warnings/errors:
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/pinctrl/cix,sky1-pinctrl.example.dtb: wifi-vbat-gpio-pins: pins-wifi-vbat-gpio: {'pinmux': [2816], 'bias-pull-up': True, 'drive-strength': 4} is not of type 'array'
	from schema $id: http://devicetree.org/schemas/gpio/gpio-consumer.yaml#

doc reference errors (make refcheckdocs):

See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20250912060650.2180691-3-gary.yang@cixtech.com

The base for the series is generally the latest rc1. A different dependency
should be noted in *this* patch.

If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:

pip3 install dtschema --upgrade

Please check and re-submit after running the above command yourself. Note
that DT_SCHEMA_FILES can be set to your schema file to speed up checking
your schema. However, it must be unset to test all examples with your schema.



  parent reply	other threads:[~2025-09-12 14:24 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-09-12  6:06 [v2 0/3] Add pinctrl support for sky1 Gary Yang
2025-09-12  6:06 ` [v2 1/3] pinctrl: cix: Add pin-controller " Gary Yang
2025-09-12 11:59   ` Linus Walleij
     [not found]     ` <TYUPR06MB5876BB28E3C30EEB9BB05997EF15A@TYUPR06MB5876.apcprd06.prod.outlook.com>
2025-09-15  8:35       ` Linus Walleij
     [not found]         ` <PUZPR06MB5887DA8FE0E128993F11E2B3EF16A@PUZPR06MB5887.apcprd06.prod.outlook.com>
2025-09-30 12:34           ` Linus Walleij
2025-09-12  6:06 ` [v2 2/3] dt-bindings: pinctrl: Add cix,sky1-pinctrl Gary Yang
2025-09-12  7:39   ` Linus Walleij
2025-09-12 14:19   ` Rob Herring
2025-09-12 14:23   ` Rob Herring (Arm) [this message]
2025-09-12  6:06 ` [v2 3/3] arm64: dts: cix: Add pinctrl nodes for sky1 Gary Yang
2025-09-12  7:45 ` [v2 0/3] Add pinctrl support " Linus Walleij

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=175768614788.1334014.18023232974115676473.robh@kernel.org \
    --to=robh@kernel.org \
    --cc=cix-kernel-upstream@cixtech.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=gary.yang@cixtech.com \
    --cc=krzk+dt@kernel.org \
    --cc=linus.walleij@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox