From: Stephen Boyd <sboyd@kernel.org>
To: Alok Tiwari <alok.a.tiwari@oracle.com>,
linux-clk@vger.kernel.org, vz@mleia.com
Cc: alok.a.tiwari@oracle.com, darren.kenny@oracle.com,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] clk: nxp: Fix pll0 rate check condition in LPC18xx CGU driver
Date: Sun, 21 Sep 2025 12:58:16 -0700 [thread overview]
Message-ID: <175848469633.4354.18141546693422292683@lazor> (raw)
In-Reply-To: <20250706201158.1371209-1-alok.a.tiwari@oracle.com>
Quoting Alok Tiwari (2025-07-06 13:11:55)
> The conditional check for the PLL0 multiplier 'm' used a logical AND
> instead of OR, making the range check ineffective. This patch replaces
> && with || to correctly reject invalid values of 'm' that are either
> less than or equal to 0 or greater than LPC18XX_PLL0_MSEL_MAX.
>
> This ensures proper bounds checking during clk rate setting and rounding.
>
> Fixes: b04e0b8fd544 ("clk: add lpc18xx cgu clk driver")
> Signed-off-by: Alok Tiwari <alok.a.tiwari@oracle.com>
> ---
Applied to clk-next
prev parent reply other threads:[~2025-09-21 19:58 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-06 20:11 [PATCH] clk: nxp: Fix pll0 rate check condition in LPC18xx CGU driver Alok Tiwari
2025-09-21 19:58 ` Stephen Boyd [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=175848469633.4354.18141546693422292683@lazor \
--to=sboyd@kernel.org \
--cc=alok.a.tiwari@oracle.com \
--cc=darren.kenny@oracle.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=vz@mleia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox